Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210913130034.103362-1-yan2228598786@gmail.com>
In-Reply-To: <20210913130034.103362-1-yan2228598786@gmail.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Mon, 13 Sep 2021 09:26:56 -0700
Message-ID: <CANn89i+EvheAER7uHvacU0=DRsQoXkCi3P9_v0VXoTkZU7K2TA@mail.gmail.com>
Subject: Re: [PATCH] net: tcp_drop adds `reason` v5
To:     Zhongya Yan <yan2228598786@gmail.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        David Miller <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>, Yonghong Song <yhs@fb.com>,
        2228598786@qq.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 13, 2021 at 6:01 AM Zhongya Yan <yan2228598786@gmail.com> wrote:
>
> Description information in the reason field of tcp_drop, "Tcp" is changed to "TCP"
> Feel free to suggest changes
>

This is a cryptic changelog.
Have you forgotten to copy/paste important information ?

We would like something that explains what the patch is about, and
eventually how to use the new functionality.

Do not assume future readers of linux TCP stack will have instant
access to all your prior versions

Also patch is about tcp,  net: prefix in patch title should be tcp:

Thanks.