Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 13 Sep 2021 13:53:17 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     kernel test robot <lkp@intel.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nathan Chancellor <nathan@kernel.org>
Cc:     llvm@lists.linux.dev, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: drivers/infiniband/hw/qib/qib_sysfs.c:413:1: error:
 static_assert expression is not an integral constant expression
Message-ID: <20210913165317.GX2505917@nvidia.com>
References: <202109112002.NZceUwiC-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202109112002.NZceUwiC-lkp@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pInG9Hnlo8CLEfVCQ63M1UC6a0xOcj6FlSAsjo3fEL7eeg1wJlwwjva38Vxq?=
 =?us-ascii?Q?cN9KUP0YDkyggDdauTGtaZppZCaA5WB7ggLKvMMWGqNsuGeynMQTpPpp5Id+?=
 =?us-ascii?Q?b9vTUDYutd6tEsUslJICPg0Uw7N0ruu/dvBpMetD5Be4xvbwcu01+IktlMaO?=
 =?us-ascii?Q?+iWNbZYj6c0o9OfzFlggas3sFGFtGBhL3B4VfT+yG7nvuKZHfbJdslVAPr+5?=
 =?us-ascii?Q?iw/nc4XN+QHcHn6YKEedLtQxSGr8Ih/cRDeKH83pn7wDrXsyp9xDANrBUbys?=
 =?us-ascii?Q?hcrJgdSU0/VjliG0gLOux2q1+yFiqLr9Fc2K26qTnKx83+gqBsXERWNbnbqA?=
 =?us-ascii?Q?aTpCrcfl/MnnD3O9QQMesJxEL+NyW4tlzuLdMZSzrD6LTX9NsAXH6MHxdKXp?=
 =?us-ascii?Q?GpFZWtS5Bbn7k0VcwKumnlZqw5CE5ApAzVKE3lrLP9f2RoqQvBCarDUwaocF?=
 =?us-ascii?Q?9Snc68nlO7l7eEY8XFcPiV41oM5e/4r+aZ4Hrrfp1rt4+Azwe6gDFn1xUMdH?=
 =?us-ascii?Q?jFiPk+NeuDYyAIqjHDUVPqqfwBgoDd3HD+75Dvx3E8L8O3F00LeOpmUDsxD/?=
 =?us-ascii?Q?I8SAhCHuS8RGuJ+DMc0g6/tAXMivvOHl4kDXYL2qZk5QuglbNueuDXt7kCNj?=
 =?us-ascii?Q?s37jNXDVWoA0EyZRg8BAPZdKrwBqVGtDUDgaENI0PF8wXGXxfS1AZQvM+ybZ?=
 =?us-ascii?Q?Ml4Kwb++p5FyCRyHVBNxFkdqcF8DJ8xs0uhBbMrpvPXYElnHm++6yEg9l7ig?=
 =?us-ascii?Q?MeLAT1XIOUNrpXwi4RTlqYGrotvOKsVfyWi9OOGq5tIMiuVSC2LWpIaKzw8z?=
 =?us-ascii?Q?e0a6EuiTKkzn8CnOyy2GYqAYWmA+4mU/ErnRoUrb7qjCwDB2Nxvb1uzdDc/+?=
 =?us-ascii?Q?9tIbms5RWu5E131yvPjnKSFzDODd7qtSbfNQVgn8KQDw4Q5MK7Z+JokChHge?=
 =?us-ascii?Q?oSLA0M5HeiQMl7C57KVeBHknpssHoeLHNtrjOLM/2SGFXFVwZmBZYxFS1JrH?=
 =?us-ascii?Q?NC8iurIaOyKG91srIYLSO5EvY5fDyAVUirtgA6AOdllLELrKcEjbnV8TEHye?=
 =?us-ascii?Q?Cc0CNlJiisZV5ZG91m98cLsxtRnPC9XNonNGs3Ju826XZS/OOhDRizzG3bYn?=
 =?us-ascii?Q?D1Tg97Mm10kYX8+KgLt0+65sTXeXawpFr9Gm4WXcAbhjSw2uoU1oyia0Op3C?=
 =?us-ascii?Q?XOwbI+5B28AOedKKHxoe2vruks7oiNMJ+2VLA/4z6dC1qLjXwwH8AUkSB6Gp?=
 =?us-ascii?Q?cf+jx6nDtUtElX5nJ6/8CMgHeZ67g01IETc4r5lxxOcZggUfZFOFWuavM2JI?=
 =?us-ascii?Q?b+5KwhaxGVRSAHFBmZp4iFFH?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e24b66cd-ca0a-495f-3e29-08d976d6fd28
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 16:53:19.3301
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8TEKGM7IWCtcpwIz79lvXKw1PiQ08n/9C6RHENVhvla363JnyU/tFAFLcj/RUCvq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5240
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Sep 11, 2021 at 08:17:08PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   926de8c4326c14fcf35f1de142019043597a4fac
> commit: 84f969e1c48ed3825986e91a0786e363d57f69d1 IB/qib: Fix null pointer subtraction compiler warning
> date:   3 days ago
> config: x86_64-randconfig-a014-20210911 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=84f969e1c48ed3825986e91a0786e363d57f69d1
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 84f969e1c48ed3825986e91a0786e363d57f69d1
>         # save the attached .config to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/infiniband/hw/qib/qib_sysfs.c:413:1: error: static_assert expression is not an integral constant expression
>    QIB_DIAGC_ATTR(rc_resends);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/infiniband/hw/qib/qib_sysfs.c:406:16: note: expanded from macro 'QIB_DIAGC_ATTR'
>            static_assert(&((struct qib_ibport *)0)->rvp.n_##N != (u64 *)NULL);    \
>            ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    include/linux/build_bug.h:77:50: note: expanded from macro 'static_assert'
>    #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
>                                     ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    include/linux/build_bug.h:78:56: note: expanded from macro '__static_assert'
>    #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
>                                                           ^~~~
>    drivers/infiniband/hw/qib/qib_sysfs.c:413:1: note: cannot access field of null pointer
>    drivers/infiniband/hw/qib/qib_sysfs.c:406:43: note: expanded from macro 'QIB_DIAGC_ATTR'
>            static_assert(&((struct qib_ibport *)0)->rvp.n_##N != (u64 *)NULL);    \
>                                                     ^
>    drivers/infiniband/hw/qib/qib_sysfs.c:414:1: error: static_assert expression is not an integral constant expression
>    QIB_DIAGC_ATTR(seq_naks);
>    ^~~~~~~~~~~~~~~~~~~~~~~~

Nick/Nathan

Clang is being a real PITA here - do you know of a solution?

This macro would like to know that the passed in member name has a u64
type, all the things I've come up with fail on clang - but many work
fine on gcc. Frankly I think this case is a clang bug myself..

Thanks,
Jason