Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210831174822.83870-1-pedro@terraco.de> <8e7ff5a2-0629-228f-c9d5-35d39bf92ce2@xs4all.nl>
In-Reply-To: <8e7ff5a2-0629-228f-c9d5-35d39bf92ce2@xs4all.nl>
From:   Pedro Terra Delboni <pedro@terraco.de>
Date:   Mon, 13 Sep 2021 14:01:15 -0300
Message-ID: <CAHKDPP9J9Y1O2LDp1MYFtbuLGBcYcbJ2v9mP-H41e3zE0feFPw@mail.gmail.com>
Subject: Re: [PATCH v7] media: vimc: Enable set resolution at the scaler src pad
To:     Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc:     Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Gabriela Bittencourt <gabrielabittencourt00@gmail.com>,
        Gabriel Francisco Mandaji <gfmandaji@gmail.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello Hans,

On Mon, Sep 13, 2021 at 5:28 AM Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>
> Hi Pedro,
>
> Your 'From' email is Pedro Terra <pedro@terraco.de>, but...
>
> On 31/08/2021 19:48, Pedro Terra wrote:
> > Modify the scaler subdevice to accept setting the resolution of the source
> > pad (previously the source resolution would always be 3 times the sink for
> > both dimensions). Now any resolution can be set at src (even smaller ones)
> > and the sink video will be scaled to match it.
> >
> > Test example: With the vimc module up (using the default vimc topology)
> > media-ctl -d platform:vimc -V '"Sensor A":0[fmt:SBGGR8_1X8/640x480]'
> > media-ctl -d platform:vimc -V '"Debayer A":0[fmt:SBGGR8_1X8/640x480]'
> > media-ctl -d platform:vimc -V '"Scaler":0[fmt:RGB888_1X24/640x480]'
> > media-ctl -d platform:vimc -V '"Scaler":0[crop:(100,50)/400x150]'
> > media-ctl -d platform:vimc -V '"Scaler":1[fmt:RGB888_1X24/300x700]'
> > v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=300,height=700
> > v4l2-ctl -z platform:vimc -d "Raw Capture 0" -v pixelformat=BA81
> > v4l2-ctl --stream-mmap --stream-count=10 -z platform:vimc -d "RGB/YUV Capture" \
> >       -stream-to=test.raw
> >
> > The result will be a cropped stream that can be checked with the command
> > ffplay -loglevel warning -v info -f rawvideo -pixel_format rgb24 \
> >       -video_size "300x700" test.raw
> >
> > Co-developed-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
> > Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
> > Co-developed-by: Gabriel Francisco Mandaji <gfmandaji@gmail.com>
> > Signed-off-by: Gabriel Francisco Mandaji <gfmandaji@gmail.com>
> > Signed-off-by: Pedro "pirate" Terra <pirate@terraco.de>
>
> ... that differs from what is used in this Signed-off-by.
>
> checkpatch.pl complains about that.
>
> Which of the two should I use? I can fix it myself in the pull request,
> but I need to know which one I should use.
I would like to stay with pedro@terraco.de.
>
> For future patches, please use consistent email addresses.
I will, sorry for the trouble.
>
> Regards,
>
>         Hans

Thank you very much,
Pedro