Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp230033pxb; Mon, 13 Sep 2021 17:47:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTFk00gzdvIor5nYxyBffkZFIbJBH13eRYYP2OowhdKcZnP9iLx1OS3tps61dJKqv1d+7m X-Received: by 2002:a17:906:308d:: with SMTP id 13mr15631513ejv.570.1631580470115; Mon, 13 Sep 2021 17:47:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631580470; cv=none; d=google.com; s=arc-20160816; b=B+LQ3+jPwih0tveh/KSzQQsVAqnnzvBMi1cyyGyKF1Bx15kTHZZ7Mm7mQeYj6QTbaZ YK4ALo2uj5iU4KIjNwQndPZCWXU/acgKdHvzoK9GlbkwVxe6PlA29Z5frc4UiQL3p6rW cDc1bfFTMXbUNSwMd/Go+kOu0g4yR20x6xPHUXSnCj9+QIkoCDflFvUIjFoT1aU68+wm 0gS+RjHAHg500CAzVaahehtSc+Gk6ytykeQ7qDBQnKoFKyDpZlb8oqtQJPyUO43LAOrk myAzT/OkR5MDDpVv6Eq+iOJx021iTzvOcli9WbXbc4lY34N5wWH6B/ugPpeZ+bR+dUTR k/xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TOoZ6YPgXH5WtzaP8SahRYuZ+H7K6nOGgWjJnWG5BdQ=; b=DNZnTUYWjO2J8WKCqOH7iqAlFNRNmZAy7E+aiJMHkxVIt90hz4uwSp2bRV0VCLVgKI Lkh4ne7RRzuEcEU4fb/47p01OPCuPzE8vyRVSR0hnd8PUeThvM0wSdVsX+ddNDyAI2hu PYCBjRVMzbrEFaPik3X68M+N/EMr1oh4mk5IvbScykQ3TTAIMbE1Jkn7PwhrFs15deTh HtkI3jBNpMQPhENuLJVAfg18r7t0aITqJ1hTYHJ00NNhr4ZvZrSDrGK1m0s9SsTZHuOx TSYBm/XEbsMiR7P9Myw7pRgUjmfquahrILmDI4AIMGN3GqCnT8pR7OeKOYjZ9P4OD9tJ O3AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kCzjSSdC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si8787170edb.272.2021.09.13.17.47.23; Mon, 13 Sep 2021 17:47:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kCzjSSdC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244231AbhIMR5I (ORCPT + 99 others); Mon, 13 Sep 2021 13:57:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:48304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239619AbhIMR5G (ORCPT ); Mon, 13 Sep 2021 13:57:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A1F0360E97; Mon, 13 Sep 2021 17:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631555750; bh=9hCsDfa152YCgrx2lvwHetmU1uS6j7bALqOO6SjfsBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kCzjSSdCZH9GmfVIx8YGg35ecGbRj3kGBdijAGtlqO4WEMWosxchtOBbWUhJmwpON K7EzWyw9tObM0NefsDXNfHs2mxJK2wX64M/hPyNxVCNGVD8smZG58IyQyJmn4x96qd ByzHGLy7UtvE/gMluPvdMqS+E/mz0lyOIoDq7manEo0IFLzJH8q+/QxjdwWOHI/yVY KQDTwQcTLPORF+OaSc8OIczMKQSu+C3xASC24gWQ8Uq8UzAFsplvWgiLYlS2MtP9SJ 6srSvyePYxQ9pn8Uewqrr/utN6RCvCZmopoWSVSTDMWODkEIAvnTSVdPGn0VVD3m8n gePHJqb3mmCFw== Date: Mon, 13 Sep 2021 10:55:36 -0700 From: Nathan Chancellor To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi Cc: Jason Ekstrand , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Matthew Auld , "Michael J. Ruhl" , Nick Desaulniers , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, llvm@lists.linux.dev Subject: Re: [PATCH 0/3] drm/i915: Enable -Wsometimes-uninitialized Message-ID: References: <20210824225427.2065517-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210824225427.2065517-1-nathan@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 24, 2021 at 03:54:24PM -0700, Nathan Chancellor wrote: > Commit 46e2068081e9 ("drm/i915: Disable some extra clang warnings") > disabled -Wsometimes-uninitialized as noisy but there have been a few > fixes to clang that make the false positive rate fairly low so it should > be enabled to help catch obvious mistakes. The first two patches fix > revent instances of this warning then enables it for i915 like the rest > of the tree. > > Cheers, > Nathan > > Nathan Chancellor (3): > drm/i915/selftests: Do not use import_obj uninitialized > drm/i915/selftests: Always initialize err in > igt_dmabuf_import_same_driver_lmem() > drm/i915: Enable -Wsometimes-uninitialized > > drivers/gpu/drm/i915/Makefile | 1 - > drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 7 ++++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > > base-commit: fb43ebc83e069625cfeeb2490efc3ffa0013bfa4 > -- > 2.33.0 > > Ping, could this be picked up for an -rc as these are very clearly bugs? Cheers, Nathan