Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Date:   Mon, 13 Sep 2021 12:42:15 -0700
From:   Davidlohr Bueso <dbueso@suse.de>
To:     Christian Brauner <christian.brauner@ubuntu.com>
Cc:     CGEL <cgel.zte@gmail.com>, jamorris@linux.microsoft.com,
        keescook@chromium.org, ktkhai@virtuozzo.com, legion@kernel.org,
        linux-kernel@vger.kernel.org, ran.xiaokai@zte.com.cn,
        varad.gautam@suse.com
Subject: Re: [PATCH V2] ipc: add set_ownership() and permissions() callbacks
 for posix mqueue sysctl
In-Reply-To: <20210913144047.4v5jquhyysnnlfvh@wittgenstein>
References: <20210824120523.s5qnzt643yvgugpv@wittgenstein>
 <20210827101206.5810-1-ran.xiaokai@zte.com.cn>
 <20210913144047.4v5jquhyysnnlfvh@wittgenstein>
User-Agent: Roundcube Webmail
Message-ID: <c74f33bde7d03d71343cc9251b298ff4@suse.de>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021-09-13 07:40, Christian Brauner wrote:
> On Fri, Aug 27, 2021 at 03:12:06AM -0700, CGEL wrote:
>> From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
>> 
>> When a non-root user process creates a user namespace and ipc 
>> namespace
>> with command "unshare -Ur -i", and map the root user inside
>> the user namesapce to the global owner of user namespace.
>> The newly created user namespace OWNS the ipc namespace,
>> So the root user inside the user namespace should have full access
>> rights to the ipc namespace resources and should be writable to
>> the ipc mqueue sysctls.
>> 
>> v2:
>>   - update commit msg.
>>   - fix the coding style issue.
>> Signed-off-by: Ran Xiaokai <ran.xiaokai@zte.com.cn>
>> ---
> 
> David,
> 
> are you happy with this too? If so I'd pick this up.

LGTM:

Acked-by: Davidlohr Bueso <dbueso@suse.de>