Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210905124439.GA15026@xsang-OptiPlex-9020> <CALvZod77aP7qdwc5FkaZJf4FikeD0NwSuoJB4N94Uf0yqZFQpQ@mail.gmail.com>
 <20210907033000.GA88160@shbuild999.sh.intel.com> <CALvZod6M_sySPM1KaWzb=tkLxXJksVDrSheckXaiBpMC3cNeqw@mail.gmail.com>
 <20210912111756.4158-1-hdanton@sina.com> <20210912132914.GA56674@shbuild999.sh.intel.com>
 <CALvZod4VbdSux5RaQuhqbC7ENm39UbdkJF8LhYedbFwHKyJgfw@mail.gmail.com>
 <CALvZod7Oa7q=P0gzfA3F26bHPrNz+F-d6G9qKpSiHy9g=msM_w@mail.gmail.com>
 <YT+ptg1Lf1kGLyUX@slm.duckdns.org> <CALvZod7mBLbkqZJzZz=XNGTDB4mxCd6dwM40aCv6t8fWbdUJdw@mail.gmail.com>
 <YT+wKFZg0OS0YFrF@slm.duckdns.org>
In-Reply-To: <YT+wKFZg0OS0YFrF@slm.duckdns.org>
From:   Shakeel Butt <shakeelb@google.com>
Date:   Mon, 13 Sep 2021 13:13:57 -0700
Message-ID: <CALvZod7BFZ1M4KWYWEhRHdZCeLV8Km=NqpkCZ=k67mBNSgX0cQ@mail.gmail.com>
Subject: Re: [memcg] 45208c9105: aim7.jobs-per-min -14.0% regression
To:     Tejun Heo <tj@kernel.org>
Cc:     Feng Tang <feng.tang@intel.com>, Hillf Danton <hdanton@sina.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Xing Zhengjun <zhengjun.xing@linux.intel.com>,
        Linux MM <linux-mm@kvack.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 13, 2021 at 1:10 PM Tejun Heo <tj@kernel.org> wrote:
>
> On Mon, Sep 13, 2021 at 01:09:11PM -0700, Shakeel Butt wrote:
> > Thanks a lot for the explanation. Are there any concerns to call
> > cgroup_rstat_flush_irqsafe(root_mem_cgroup->css.cgroup) in system_wq?
> > This will be called every 2 seconds, so, we can assume the updated
> > tree would be small most of the time.
>
> I can't think of a reason why this would be problematic.
>

Thanks again.

Feng, is it possible to re-run these benchmarks with
queue_work(system_wq) instead of queue_work(system_unbound_wq)?