Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <169a507329c2273f64c1c7ebab0a3530b19e971e.camel@kernel.org>
Subject: Re: [PATCH v2 1/1] tpm/tpm_i2c_infineon: Fix init endian vendor
 check
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Florian Eckert <fe@dev.tdt.de>, peterhuewe@gmx.de, jgg@ziepe.ca,
        Eckert.Florian@googlemail.com
Cc:     linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 13 Sep 2021 23:31:13 +0300
In-Reply-To: <20210913120521.18572-1-fe@dev.tdt.de>
References: <20210913120521.18572-1-fe@dev.tdt.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2021-09-13 at 14:05 +0200, Florian Eckert wrote:
> On my embedded system I use this tpm infineon chip via i2c bus.
> The system is a MIPS architecture and therefore works in big endian mode.
>=20
> The problem is, that the chip type is not correctly recognized,
> because the vendor ID is wrongly aligned in the memory.
>=20
> By declaring the vendor ID variable as a `__le32` type, the TPM chip is
> then correctly recognized by the driver and feels then responsible.

Please no hyphens just normal single quotes.

You should have always in a commit message some explanation what
the patch does in imperative form, e.g. "Change type of xxx ...
because ...".

I cannot from find a variable named "vendor ID" from
tpm_tis_i2c_init(). Maybe you are referring to the variable,
of which name is "vendor"?

Finally, the commit message lacks explanation what is changed, i.e.
tpm2_tis_i2c_init() in this case.

Did you find the commit ID where this regression was introduceD?

/Jarkko