Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762998AbWLKTmJ (ORCPT ); Mon, 11 Dec 2006 14:42:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763027AbWLKTmJ (ORCPT ); Mon, 11 Dec 2006 14:42:09 -0500 Received: from smtp.osdl.org ([65.172.181.25]:57990 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762998AbWLKTmH (ORCPT ); Mon, 11 Dec 2006 14:42:07 -0500 Date: Mon, 11 Dec 2006 11:36:34 -0800 (PST) From: Linus Torvalds To: Andy Whitcroft cc: Herbert Poetzl , Olaf Hering , Andi Kleen , Andrew Morton , linux-kernel@vger.kernel.org, Steve Fox Subject: Re: 2.6.19-git13: uts banner changes break SLES9 (at least) In-Reply-To: <457DAF99.4050106@shadowen.org> Message-ID: References: <457D750C.9060807@shadowen.org> <20061211163333.GA17947@aepfle.de> <20061211180414.GA18833@aepfle.de> <20061211181813.GB18963@aepfle.de> <20061211182908.GC7256@MAIL.13thfloor.at> <457DAF99.4050106@shadowen.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 896 Lines: 24 On Mon, 11 Dec 2006, Andy Whitcroft wrote: > > I am afraid to report that this second version also fails for me, as you point > out CIFS can break us if defined. Olaf, will you admit that the SLES9 code is crap now? Andy, does just replacing the "__initdata" with "const" fix it for you? That should hopefully mean that IN PRACTICE the Linux version string will be the first one to be triggered, if only because init/main.c is linked reasonably early, and all the other "Linux version" strings will hopefully be in the same rodata section. Sad, sad. We shouldn't need to work around tools that are so _obviously_ broken like this. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/