Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763148AbWLKWEt (ORCPT ); Mon, 11 Dec 2006 17:04:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763151AbWLKWEt (ORCPT ); Mon, 11 Dec 2006 17:04:49 -0500 Received: from ozlabs.org ([203.10.76.45]:33282 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763141AbWLKWEs (ORCPT ); Mon, 11 Dec 2006 17:04:48 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <17789.54777.283849.950002@cargo.ozlabs.ibm.com> Date: Tue, 12 Dec 2006 09:04:41 +1100 From: Paul Mackerras To: Linus Torvalds Cc: Olaf Hering , Herbert Poetzl , Andy Whitcroft , Andi Kleen , Andrew Morton , linux-kernel@vger.kernel.org, Steve Fox , linuxppc-dev@ozlabs.org Subject: Re: 2.6.19-git13: uts banner changes break SLES9 (at least) In-Reply-To: References: <457D750C.9060807@shadowen.org> <20061211163333.GA17947@aepfle.de> <20061211180414.GA18833@aepfle.de> <20061211181813.GB18963@aepfle.de> <20061211182908.GC7256@MAIL.13thfloor.at> <20061211185536.GA19338@aepfle.de> X-Mailer: VM 7.19 under Emacs 21.4.1 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1515 Lines: 36 Linus Torvalds writes: > On Mon, 11 Dec 2006, Olaf Hering wrote: > > > > arch/powerpc/boot/wrapper:156: version=`${CROSS}strings "$kernel" | grep '^Linux version [-0-9.]' | \ > > This is also obviously broken (and really sad), but actually ends up being > better than what get_kernel_version apparently does, by at least adding > the requirement that the string "Linux version" be slightly more correct. > > However, it's also TOTALLY BROKEN. It's the minimum effort for the barely acceptable outcome. :) The wrapper script, although it currently lives in arch/powerpc/boot, is designed and intended to be standalone, so that people can use it outside the kernel tree, and possibly even without having the kernel source easily to hand. Therefore I didn't want to use any kernel header files. Apparently the only reason "mkimage" wants to know the kernel version is to put it as a comment in the image, which can be displayed to the user when booting with u-boot (the bootloader used on some embedded platforms). So it's not critical if the grep fails, and it's slightly more useful to do the grep than it would be to not even try to provide any version string to mkimage. If there is a reliable way to get the version string, great, I'll use that. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/