Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] lib, stackdepot: Add helper to print stack entries
 into buffer.
To:     Vlastimil Babka <vbabka@suse.cz>, geert@linux-m68k.org,
        akpm@linux-foundation.org, ryabinin.a.a@gmail.com,
        glider@google.com, andreyknvl@gmail.com, dvyukov@google.com,
        maarten.lankhorst@linux.intel.com, mripard@kernel.org,
        tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        intel-gfx@lists.freedesktop.org, linux-mm@kvack.org
References: <20210910141001.1622130-1-imran.f.khan@oracle.com>
 <20210910141001.1622130-2-imran.f.khan@oracle.com>
 <464d76e2-37f0-87f3-a9d5-2101367a8ca3@suse.cz>
From:   imran.f.khan@oracle.com
Message-ID: <ba2f09de-1de7-3a72-1c1e-fe048c50b8e0@oracle.com>
Date:   Tue, 14 Sep 2021 14:26:42 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <464d76e2-37f0-87f3-a9d5-2101367a8ca3@suse.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0xFWmFQMXEyUGRrUG9wNE9UWTBxY1dEdDNHL2lCU2xWeUNIUnlGR2RwSjQx?=
 =?utf-8?B?QXpEOEQvaUI3NDBCdm5OQ1Y0KzRDQTRNUUlvYWo2MDFqZ0tNVXRPbTJ6NkRV?=
 =?utf-8?B?VzVpYVJmZVRDVzBOTWlaS1UyMW03NDVFWEpQTnVuVVZXbU1Tb20vWU96MHdO?=
 =?utf-8?B?TWlVcVl0VEpnMUJlVlZvTi9says2VTNHM2d3Q3N1ZVlIcllYN0lmSFBiRjBo?=
 =?utf-8?B?ZEZ5V2szNm9ndDNwSDNwV1NpWmc3TGVuWnhRZnMyUHBsZW5jUnUvaU5qMzZ3?=
 =?utf-8?B?Rm91b05qSjBSZTBzUW5EUGx5bHFzdG9VWCtPQ2J2dXJlV0JoK0JKaHh3aU5V?=
 =?utf-8?B?dlJyQkY4RURrNFo3NCtlZzE3ekhzbjBKb2srajZkUmRlc1RTbUZQeGFlL1E4?=
 =?utf-8?B?TGQ4QndCZmxLbWdmNUFzeWRRdHZlQ3JjQ2hGSDB1RVR4ZkRvWEdVSlkwZ24y?=
 =?utf-8?B?eXVkS1VtWDRBV3lNeXZyaUp4R1lkcG12WHhtbi9lVTdsc0FVUmdxOVRETjJj?=
 =?utf-8?B?dmIvZnVoQzJpTFA0UlVmUFk5REpZVG5LdUF1bjAzdy9xNWs3VUZwSnpFM2Fr?=
 =?utf-8?B?emdsN2hvNkgyakpvbjMvTmZsYlNoZE5wZFM1c2lFMWorU0hiSitzaTV5eHV6?=
 =?utf-8?B?b3A0RExNMXFFTjF0L1E5azV2SmxUa1EvKzdGa1JFSFEraUVIZXRMdE5mNy9i?=
 =?utf-8?B?UHRTdm1KdDdmSm93cmU5UjZQRGdNTjN1aDM4T00ydi9WOVV3UEtHbTBPc2No?=
 =?utf-8?B?bzY0ZTB1aVhabmN5V1IxYjBKK0RoRFBmMCs0K0wvU3J2ZVlRUmtRL0JLOWNv?=
 =?utf-8?B?TkFHM05KRVg3b0tTZG12a2hGQjA0QmpxTkhZVXp5NDlOY0ZpUVRTYVBtUVJr?=
 =?utf-8?B?eGU0YXlsWjVIQUhOaWpOaS9TY1YrYUt0c1NVeGhuUVdIRU9CMndYNHVsaHFs?=
 =?utf-8?B?OTAwdHRsL3hYT3I1Q2V6MUlUcU5OUVJJSmc5WmtYU3AxZXFhWlZQZk43UDlR?=
 =?utf-8?B?cGxWZlEwSFc1SURwQzRLMU1LS3ZZT0kvdGY2WmJaOWNBYU9uUUoyUWRHbW1F?=
 =?utf-8?B?bS9MZ200RmVWMWlQU05hYURkTmRZVk9zVksvc3ZzY0hMcEVlMUpzZUdLbytU?=
 =?utf-8?B?VmovK0JzSmdsQlRoOFJCOTZ6YURwWnlEVlprZy84Tk96czFMUlNaS2Y5M1hX?=
 =?utf-8?B?d2NmdFhMWVRiQjRmYVplSVRHY1BuNkVFbFBtTFp2K1kxdkw2WHlrdUVhNVc1?=
 =?utf-8?B?QlhMeVBNMDBDdHZHZkpSZ0FYYUlKMVN4SzlBQjU2NUV6M2V2U0JaOFpySndX?=
 =?utf-8?B?Yk1WZUxGWTJwdFhsaEZ6Y1pZUmJqUEVmd0VsZ0dMUWZIVjFmdXJSNFptMUQ4?=
 =?utf-8?B?cDIyNWR0c3Axdko2U1FORkZERFUxOVFRL2J4WEF0d2IyMGYveU8zQ2FDYUxa?=
 =?utf-8?B?Wk8vM0FtS1Y1a3Zycml5STl2NW5XSmZxN2VmaUxvSFROaGQ2RmU5dUY4d2NE?=
 =?utf-8?B?enVPSXMxRnoxaHVuK01ENGlzc0hPZTF1WjdJWU9pMHB3d0grWU82K3RtSG5j?=
 =?utf-8?B?emFsZEpLOGhJQUlPRlBpSENRT2NXTG9OMnQxV3RHTjRCbGpUWjltbVFweW9w?=
 =?utf-8?B?ZGVsVFRCbUE0cjg5eE9VMGtNUDdFaFUrMDVJeDJBZEFuODkxdjBTZ0pGNllz?=
 =?utf-8?B?dWEzVUdQeEFmRWFkeHhEcGVxQWtZVklkK1ZaT2o0eUZEN3FUWUZ4TXQ1VjBq?=
 =?utf-8?Q?j7lR1LW2/5ArHsKdBIHIoYrAW4bICs6xI3rq2OK?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78124754-25b4-427b-69df-08d97737e047
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2021 04:26:52.0921
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GzMHop/RCgdoRRx/B6hX6fjObG62Yvc+09+4SQcw14GjpInjg6j6l9Q7omNKTjZBqeGB/ns+UXyC2EthVF0Oqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4690
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10106 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 phishscore=0
 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109140024
X-Proofpoint-ORIG-GUID: j7XcZsDbV9BpgKsMYMbBc1AV4Wcv5DYT
X-Proofpoint-GUID: j7XcZsDbV9BpgKsMYMbBc1AV4Wcv5DYT
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 13/9/21 6:51 pm, Vlastimil Babka wrote:
> On 9/10/21 16:10, Imran Khan wrote:
>> To print stack entries into a buffer, users of stackdepot,
>> first get a list of stack entries using stack_depot_fetch
>> and then print this list into a buffer using stack_trace_snprint.
>> Provide a helper in stackdepot for this purpose.
>> Also change above mentioned users to use this helper.
>>
>> Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
>> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> 
> 
Thanks for the review.

A comment below:
> 
>> --- a/lib/stackdepot.c
>> +++ b/lib/stackdepot.c
>> @@ -214,6 +214,29 @@ static inline struct stack_record *find_stack(struct stack_record *bucket,
>>   	return NULL;
>>   }

[...]

>> + */
>> +int stack_depot_snprint(depot_stack_handle_t handle, char *buf, size_t size,
>> +		       int spaces)
>> +{
>> +	unsigned long *entries;
>> +	unsigned int nr_entries;
>> +
>> +	nr_entries = stack_depot_fetch(handle, &entries);
>> +	return stack_trace_snprint(buf, size, entries, nr_entries, 0);
> 
> stack_trace_snprint() has a WARN_ON(!entries).
> So maybe we should not call it if nr_entries is 0 (because e.g. handle was
> 0) as the warnings are not useful in that case.
> 
Agree. I have addressed this feedback in v2 of patch.


Thanks
-- Imran