Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937695AbWLKWnI (ORCPT ); Mon, 11 Dec 2006 17:43:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S937699AbWLKWnI (ORCPT ); Mon, 11 Dec 2006 17:43:08 -0500 Received: from hellhawk.shadowen.org ([80.68.90.175]:2551 "EHLO hellhawk.shadowen.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937695AbWLKWnF (ORCPT ); Mon, 11 Dec 2006 17:43:05 -0500 Message-ID: <457DDEF2.6030504@shadowen.org> Date: Mon, 11 Dec 2006 22:42:58 +0000 From: Andy Whitcroft User-Agent: Icedove 1.5.0.8 (X11/20061116) MIME-Version: 1.0 To: Linus Torvalds CC: Herbert Poetzl , Olaf Hering , Andi Kleen , Andrew Morton , linux-kernel@vger.kernel.org, Steve Fox Subject: Re: 2.6.19-git13: uts banner changes break SLES9 (at least) References: <457D750C.9060807@shadowen.org> <20061211163333.GA17947@aepfle.de> <20061211180414.GA18833@aepfle.de> <20061211181813.GB18963@aepfle.de> <20061211182908.GC7256@MAIL.13thfloor.at> <457DAF99.4050106@shadowen.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 26 Linus Torvalds wrote: > > On Mon, 11 Dec 2006, Andy Whitcroft wrote: >> I am afraid to report that this second version also fails for me, as you point >> out CIFS can break us if defined. > > Olaf, will you admit that the SLES9 code is crap now? > > Andy, does just replacing the "__initdata" with "const" fix it for you? > That should hopefully mean that IN PRACTICE the Linux version string will > be the first one to be triggered, if only because init/main.c is linked > reasonably early, and all the other "Linux version" strings will hopefully > be in the same rodata section. Yes that does make things 'work' again. This all seems pretty fragile :(. > > Sad, sad. We shouldn't need to work around tools that are so _obviously_ > broken like this. -apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/