Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp399381pxb; Mon, 13 Sep 2021 23:14:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzeinGOoAPT0L3/cqm5KwbHj2ovyZRiyfgiDc1WgERWawjTPY9YoAftqji8YVlh60MNhBp X-Received: by 2002:a17:906:4994:: with SMTP id p20mr16990320eju.38.1631600052345; Mon, 13 Sep 2021 23:14:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631600052; cv=none; d=google.com; s=arc-20160816; b=iJrwT7WgRBzbuAuFJvek6Hv+Rk9h7Nb7DjovsawifJkuqcwebOxVwjSOTELDbcc7Yj 2zNxiqrfueB3y1w3H/Qi1rCJJxHrwRvpUl2MDczZqqonVSkD7LJhA+eSc2l4B2qfvNnz 1yKNblFQcob8xstEEmxPKi6mP9rtwGNCrag4iny7COIAAK4n2xwjsVYuUknxp2UH5P// 9jbhm7jW6TBXmy4Dn792eg/qFyf1lj3bgNyJoEJC5FbvLfzG0P8uiVMh2vy0jY1ifTh/ dUPUM5EYxvzCVuNfK5CzzpbfF23UtN4exzzr7kqmBTqQQ7MchSDqZ0IAGOZlm7ojsR/g n91A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=qmQ8kdaDHExntoQ79COOera/juraCQKZQV6uAin9DIo=; b=xPs6Dxffn2U/VR2bbNJLO5rNoCDz4DkaaZPnnTSWaslatirQUzFV2TWDlPBCIS700M etggm7ww4oKdbei3Ia2YhWPxYNMNQqM1XYh+FGXZ+cQ0nusxLAzQXVi1fQV+WJHkctgw gMyiMRBSyiGXETy4FjjBUkcD6LR6yLh47fLEKtjGK/ScLfijjxiHNKg9hm6LVPkbGNXV IhoJD9du247VY5Z9URQFs5iwBe0F5ANXBGHUUZmkEKMKUKPjKFXwBVxBhRl0u66b9vEP YrhBq4iT+XhOVz3pzOhPydv23zAgSIdActohvh3DS9iqMOT8qMTno38WGlXoGZJRVpT/ 9gDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z2si2853067ejl.182.2021.09.13.23.13.48; Mon, 13 Sep 2021 23:14:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239894AbhINGNm (ORCPT + 99 others); Tue, 14 Sep 2021 02:13:42 -0400 Received: from verein.lst.de ([213.95.11.211]:58595 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237875AbhINGNl (ORCPT ); Tue, 14 Sep 2021 02:13:41 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 751A167357; Tue, 14 Sep 2021 08:12:22 +0200 (CEST) Date: Tue, 14 Sep 2021 08:12:22 +0200 From: Christoph Hellwig To: Sam Ravnborg Cc: Andreas Larsson , David Miller , sparclinux@vger.kernel.org, Christoph Hellwig , linux-kernel@vger.kernel.org, software@gaisler.com Subject: Re: [PATCH] sparc32: Page align size in arch_dma_alloc Message-ID: <20210914061222.GA26679@lst.de> References: <20210908074822.16793-1-andreas@gaisler.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 08, 2021 at 06:04:54PM +0200, Sam Ravnborg wrote: > Hi Andreas, > > On Wed, Sep 08, 2021 at 09:48:22AM +0200, Andreas Larsson wrote: > > Commit 53b7670e5735 ("sparc: factor the dma coherent mapping into > > helper") lost the page align for the calls to dma_make_coherent and > > srmmu_unmapiorange. The latter cannot handle a non page aligned len > > argument. > > I wonder how you managed to track this down - well done. > > > > Signed-off-by: Andreas Larsson > Reviewed-by: Sam Ravnborg > > I assume David or Christoph picks it up. I'll happily pick it up if that is ok. Dave?