Date: Mon, 11 Dec 2006 15:05:56 -0800
From: Greg KH <gregkh@suse.de>
To: Maneesh Soni <maneesh@in.ibm.com>
Cc: Alan Stern <stern@rowland.harvard.edu>, Oliver Neukum <oliver@neukum.org>,
       linux-usb-devel@lists.sourceforge.net,
       kernel list <linux-kernel@vger.kernel.org>
Subject: Re: race in sysfs between sysfs_remove_file() and read()/write() #2
Message-ID: <20061211230556.GB4709@suse.de>
References: <20061204130406.GA2314@in.ibm.com> <Pine.LNX.4.44L0.0612041101410.3606-100000@iolanthe.rowland.org> <20061211104306.GA22628@in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061211104306.GA22628@in.ibm.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1292
Lines: 33

On Mon, Dec 11, 2006 at 04:13:06PM +0530, Maneesh Soni wrote:
> On Mon, Dec 04, 2006 at 11:06:41AM -0500, Alan Stern wrote:
> > On Mon, 4 Dec 2006, Maneesh Soni wrote:
> > 
> > > hmm, I guess Greg has to say the final word. The question is either to fail
> > > the IO (-ENODEV) or fail the file removal (-EBUSY). If we are not going to
> > > fail the removal then your patch is the way to go.
> > >
> > > Greg?
> > 
> > Oliver is right that we cannot allow device_remove_file() to fail.  In
> > fact we can't even allow it to block until all the existing open file
> > references are closed.
> > 
> > Our major questions have to do with the details of the patch itself.  In
> > particular, we are worried about possible races with the VFS and the
> > handling of the inode's usage count.  Can you examine the patch carefully
> > to see if it is okay?
> > 
> 
> Sorry for late reply.. I reviewed the patch and it looks ok me.

Thanks for the review.  Oliver, care to resend it to me so I can give it
some testing in the -mm tree?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/