Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next] net: core: fix the order in dev_put() and
 rtnl_lock()
To:     Eric Dumazet <eric.dumazet@gmail.com>,
        Yajun Deng <yajun.deng@linux.dev>, davem@davemloft.net,
        kuba@kernel.org
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210914030150.5838-1-yajun.deng@linux.dev>
 <903c5bed-5958-8888-b55d-9c175664b2a1@gmail.com>
From:   Nikolay Aleksandrov <nikolay@nvidia.com>
Message-ID: <10890d5f-4486-0fee-0d8e-3c1c92f78937@nvidia.com>
Date:   Tue, 14 Sep 2021 10:52:37 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <903c5bed-5958-8888-b55d-9c175664b2a1@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTJmanhSZ3J6VWpXd2NGaEJMSGNjdmVJN1kxVXNNM2pTYnRJNjRlaEpQRVFC?=
 =?utf-8?B?RFZ2NlNaaTBQWGFubVNBS0JvTjRyNklwbE1GbFdHVlVHYWZJd0hMK2hUdDUw?=
 =?utf-8?B?NDYxYUNuOERQR1FaN3BSK01FblRSakpzc0REaXBnb1YvU0w5VUlseGlqK1NO?=
 =?utf-8?B?R1RNRG9LMkQvRVpDTUxLYUtRRHhZNVBKQ3dQRDRERVlrUG9BdWxRZEFUb01S?=
 =?utf-8?B?Rkp0cFlGNFNQTUE2VkhocUFyR3pub3JjcWlTN2NXNXVrbGhab2FENnZ0Q2dY?=
 =?utf-8?B?NWcyZ2ZrR2RUbXRTZXFsT0VVZnJqcHF0NDkra01FYW5NOEh3UnMyMXlGMG1K?=
 =?utf-8?B?OGtETkRiYk9XK3Y3b0Z0Qmo4VUhuaDZDckNvaU5Wclh2WmxiV1RFNVp0YjZV?=
 =?utf-8?B?Ykd1b2dtaTNBWGhjSjZOQkRya1RtbGdNLzFvaXp4REVLcElIeVRLNjRBSUNx?=
 =?utf-8?B?RGNzdTNPWFB3bTgvWGpVR2hVYUFkRGY4ZUoxWkhRWWpmZ0pNdXYrTkFaZWJ2?=
 =?utf-8?B?cm9tWHNGTEN6WVFHdkVlblZ1SW9UbXRteWpsUFhsWTUxcEVGckNtY2o3U3RT?=
 =?utf-8?B?WDlLcG5odFRsSDl4aVpqMm1qSWt5ejdtaFdxVWlUUnVUVWtkb2M0OXo3cStW?=
 =?utf-8?B?OGlyOXhxd0lLdXoxNEF4UU9KWklQdDRHcWU0aElxTGwyc2VrVi9FVnMwcVNn?=
 =?utf-8?B?Wm5GU1BJN25GVjhpZkZ5OElid0o2eU1xd2xlb2FNbW01Um5wT1plNmxTWGVM?=
 =?utf-8?B?Nks1SjZudFhEZ002Qm1QcG5scm1BR2JnMG5WSWlnS3dsMjEzdU9uTEdldkZ4?=
 =?utf-8?B?UUlielBpWStPVytWNUJlT09mNnJZTnBMZUpFaGNNS2Z5azMxS2wwbHRkdTdG?=
 =?utf-8?B?YXYzY1JwR0RVTERndWlwWGtCbzFlM2RiUE04K3FBRkkxUTFaeng1ekZaWkdQ?=
 =?utf-8?B?NGFMQnQ3ZFZzM2lTKzFXN1VSMWdYZjMwVXQ2TmtiajlBT0tyNEJqNmxLWUdr?=
 =?utf-8?B?WGdoYURTaGlTdFZ6enNkc0pDNXpXRlVSNEdYZTkxNklIU1F6b0o0eERGQ3RP?=
 =?utf-8?B?R3Q1SXBGWDljODhVU0w4dzN1VFZ3NmNFMmIyejVVanJlUFgrdmhhMncrK2gz?=
 =?utf-8?B?SzNZVHJLNnVLYzhPVG9tbXlsa1BXTDhVUWFMdGhkWEdpR2lDRjZXRkFPVEM4?=
 =?utf-8?B?bmZqNzRmSHZoczBsa3pia2JHZUk5YkFmMzRGYmRRTXRPdGFhSHB6ZnY2TW50?=
 =?utf-8?B?OEJ3dVR3QXBrbVlIUGZyNjNoNnNiQ3k3K093SFlONnRISUVGNklnSVg3WWFP?=
 =?utf-8?B?RVAwbCtkWDhDRGZVb3ZZYjhDM3lrZk81NXlrZDU4ZEUwdXlTRlhQZEdsN3ZY?=
 =?utf-8?B?Q3M4cXFveGhRU3cyZlQxWXlXVlFmejg1U0VCYjBtZ1pEcUZBWnFNS3hYWEV5?=
 =?utf-8?B?NkQwblNRcnZXK2xTOE8rakN5NDhaVDhvYVR6dG41US9EcmVXdktPdW5OQXFQ?=
 =?utf-8?B?N3J3U1pvYlFkckhjMWJtMHdsK1J2cDhLZUJhTFA4RlorR2M2T0F6VERNL2tw?=
 =?utf-8?B?disybWpDWDYzSnYzZ1JmWVA3Q05LSEE4cFZtK3U2d2ZGSUJYNTdMZmFnUHR3?=
 =?utf-8?B?ek9YSzNCUVFZcFhHOURDVGY4MUxZZHo2MG1oWXFaWE9ZRXFQNFNDWk9RV1A3?=
 =?utf-8?B?RTBRR1pMeWF1VUdyVmZJdlE0YTRiajdad1NuM0RZOHRZSVNZQUNNYjBTdk05?=
 =?utf-8?Q?PhDJODxpouK87g5Zzli2PiDCHaMoZO7zRc65+hl?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3230dad-ad29-441c-957b-08d97754a502
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5278.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2021 07:52:48.1806
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lvP6CedixJuIO6uRC8FIswSVMhU9X/PwKQlXhI/g5uXGZoaFLIvxtXPg78hAFSevM9CrLBnfnLLlox31w+BCEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5461
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14/09/2021 08:18, Eric Dumazet wrote:
> 
> 
> On 9/13/21 8:01 PM, Yajun Deng wrote:
>> The dev_put() should be after rtnl_lock() in case for race.
>>
>> Fixes: 893b19587534 ("net: bridge: fix ioctl locking")
>> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
>> ---
>>  net/core/dev_ioctl.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c
>> index 0e87237fd871..9796fa35fe88 100644
>> --- a/net/core/dev_ioctl.c
>> +++ b/net/core/dev_ioctl.c
>> @@ -384,8 +384,8 @@ static int dev_ifsioc(struct net *net, struct ifreq *ifr, void __user *data,
>>  		dev_hold(dev);
>>  		rtnl_unlock();
>>  		err = br_ioctl_call(net, netdev_priv(dev), cmd, ifr, NULL);
>> -		dev_put(dev);
>>  		rtnl_lock();
>> +		dev_put(dev);
>>  		return err;
>>  
>>  	case SIOCSHWTSTAMP:
>>
> 
> What race exactly are you trying to avoid ?
> 
> This patch does not look needed to me.
> 

+1 

There isn't a race there