Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp512999pxb; Tue, 14 Sep 2021 02:46:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrzE1oS7+cidskyf6KHjgqY7jn2fKvtgFxDiJSVXIM7sIAkxdMuL8cVj0s+rnNjfm22r1g X-Received: by 2002:a17:906:38db:: with SMTP id r27mr17968153ejd.338.1631612779707; Tue, 14 Sep 2021 02:46:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631612779; cv=none; d=google.com; s=arc-20160816; b=pAitZFzgh8W+V6lDkTtrZSt4pITyIHkJU4e37QACBoJsq8Rc/aZ2AU9J/f12magxr9 lYwEy6xY/ZY4B0xsbc42wT31eUxeKMXX3DgjX7HL3lLbyIl83jUQY3rgvVZ0DR9cP7gi rxn1l0evWSl6d4KwM/TcNGgi7dhMTJGS++4AanQZimlgDBLPwjwoMjCKMWUnSteeQWSU Q51KN3zXBvKzKWU4nXq6hVjXTMTdv6sYsKnQrhdjRg8Ur+Zv1K2A+si+iN+05D2Nw4pq j8x5VyuFEi11epgNzeYkcFn3d5EWOHnz1y9OyrEWnhNfRLS3UQmUFMd79/JuK01I1hSo 9rNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=BSElTKq3CKNAeCOkK+MwTeKSoX4cREwMxKvFuJod8j0=; b=mMoL42TMj8U/FAB3KjqF8jHc01UhVOqEEvhRHIzK1XdspxWEma79hU61+pPwIWrWpB fWWENsGj2N4VGcVhIbO0+ja6m5dt5SEfx0Szq928+XE9aIfh66Px4eJq1bibIZ5u/QOZ qPcgTVDl3f+GPJzzhSdMYL7js5NrT1eROY813Y/Uh2psLr8iReY1ppJ0VrhHOHNQ+5vd Mub6lWtAXnykJNvmRlvfHB7ADWQyakqGQdcPdE3SOvPkXxi4cTy1yhCj6WZgVm5AosGm 4TSraKRuucP1SCLH8gc6gOfn7ZGUy5XrUI8qvawP+ojbm5RNmAHVoc4W/Qd724P8ZBbt QdpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z26si12928889ejc.486.2021.09.14.02.45.55; Tue, 14 Sep 2021 02:46:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbhINJpk (ORCPT + 99 others); Tue, 14 Sep 2021 05:45:40 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:45623 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbhINJpj (ORCPT ); Tue, 14 Sep 2021 05:45:39 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04407;MF=ashimida@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0UoNByb2_1631612648; Received: from localhost(mailfrom:ashimida@linux.alibaba.com fp:SMTPD_---0UoNByb2_1631612648) by smtp.aliyun-inc.com(127.0.0.1); Tue, 14 Sep 2021 17:44:20 +0800 From: Dan Li To: catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dan Li Subject: [PATCH] [RFC]arm64:Mark __stack_chk_guard as __ro_after_init Date: Tue, 14 Sep 2021 17:44:02 +0800 Message-Id: <1631612642-102881-1-git-send-email-ashimida@linux.alibaba.com> X-Mailer: git-send-email 2.7.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org __stack_chk_guard is setup once while init stage and never changed after that. Although the modification of this variable at runtime will usually cause the kernel to crash (so dose the attacker), it should be marked as _ro_after_init, and it should not affect performance if it is placed in the ro_after_init section. This should also be the case on the ARM platform, or am I missing something? Signed-off-by: Dan Li --- arch/arm64/kernel/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index c8989b9..c858b85 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -60,7 +60,7 @@ #if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_STACKPROTECTOR_PER_TASK) #include -unsigned long __stack_chk_guard __read_mostly; +unsigned long __stack_chk_guard __ro_after_init; EXPORT_SYMBOL(__stack_chk_guard); #endif -- 2.7.4