Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp526050pxb; Tue, 14 Sep 2021 03:07:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9uho44ngu4+s8gdyiEFBKfVDn5EBq+V83gRfuXcG0TtZcoADJVbjQPT2VzQJFCyb70ajR X-Received: by 2002:a02:3b67:: with SMTP id i39mr13842815jaf.100.1631614055888; Tue, 14 Sep 2021 03:07:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631614055; cv=none; d=google.com; s=arc-20160816; b=IbQxnRrcgd7nKQHkhAQKPH5fWDRmlGCpJqLSuRgjIsPthFc9FQqTA4ZpU5bUqQ2E5Y 0OfwQNPxFQrTONzBmEPonEmT5YywTjHkkE8i4kya8eohWb1d0jwXcvmtnKOXuyVu6RBE PKnT8LDgckTP2opI1yuxGxSmDhR3tOsrQH2v+l+REJBTgs/kE9OWiZeLLq2DwwH0dJ/U fP/7M7fFoIuYMN29nFqOBZsixrAhcKOb8+Z/1G7TdbRY//GFcmpDMMNRJ6QuEnUQ2Zdd 2cI2aFurcpaOEubl76fAdMMKIsxt6RcXc9qT/1pONwDlrQHx4b5MusvOA7QjqUdKoGHg S/7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=z1muzdOPWzB0ytDKcRa+QFyNrcjjCHiCUrUvKj8zYFM=; b=XzBkziPTlmqQoUkXudwKh+1BmJVhNgFKVNF+Mhb4mi4G6mUtcmb5/5hkFGl8q9eH5k cCr+hSWMTjP8OfKnioBIcxm0maW5nWCbGq1o+rAYo4yTdkCIqXqpXGMCMkHxw9sHmW4j zV8hisIL724mVhMWa9WgfU2tY31CAKjY8s/vALNY1JrGou9zVqMhxVAa+2atPd/jmvnL bTM3ur73UjGyqUUeIRX92lXj9sR6X221ujbD2nmiXvVkZ3EY5d6IDwZWLmXd6GeuPzuR yiaLWEndQ7w0Uj9FlZzqncdmo/dv63lF6zFXxEIh+HskPK6l3u1QM6ZEWqBkdzd2m5r7 WkhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZV9YpuPT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i12si10717138ilu.99.2021.09.14.03.07.15; Tue, 14 Sep 2021 03:07:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZV9YpuPT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230223AbhINKGq (ORCPT + 99 others); Tue, 14 Sep 2021 06:06:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230282AbhINKGp (ORCPT ); Tue, 14 Sep 2021 06:06:45 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C046C061762 for ; Tue, 14 Sep 2021 03:05:28 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id bb10so7834020plb.2 for ; Tue, 14 Sep 2021 03:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z1muzdOPWzB0ytDKcRa+QFyNrcjjCHiCUrUvKj8zYFM=; b=ZV9YpuPTdGrvhLZWC7YTDjzQ+oyE4Tnvnl2GIQvc69ojO1KtUMsUfiP9jbd3N04ASM JSv+PVbTCW622AwkynaZ0Dj/sHs9nNGOzTgnmEOuguzXMzE+UMuDLtnQA+7BM07LZfB6 q5TmSMD1rnsXyGKCFILbsVrXFHZn1SlA0lfUa4GVO25uojNy0n+O0Y7EMjBj8B0HaVFX 0r81qzhcYX1QCmSPgFTKdnq6ytpycu4hgs/q7/XFqfX/4g8tGPY2dALaQtmcn44vk8I+ DPDSduio6Ba8YeMc1isvG99CxKGYwUeAoBDymzxWpAI2oHcMj/2uqQduBfu6/o7PUv61 NS2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z1muzdOPWzB0ytDKcRa+QFyNrcjjCHiCUrUvKj8zYFM=; b=FQpVIzJyxGyWloFPY6vIq+N2b9kf1uAjBg+koChSK9yEV2Hk7VF1QAnWF/m55CUgsL 4BQZvmFU3e216SO0i86Lp7adCDI/cQ7FFr+mOhaFi18dM/qwa+h7P/A7e5ioJdQRbhwf 0vY23N1ldqc+5js37F8z89PKahGh/eZRKxuluym9eYpjHIlC5Mh46Q5vfgELRVGWasLX FUo0V9gxRt2mHSJsOKHy/Q6QGelMYbcGif3XSh+oYKlSIoadqQGUg8b7yMbsGG2XVnsV jteFhseWcNUVGkg9JteUSbHNsI0b0M/pMJOekC6P3K4XUcYzgLKYPcXVF2yNRgORd95I EnRw== X-Gm-Message-State: AOAM530m4+s6eJKc1EvvHl1lt5HE0gVzOLvV3FfM2HS0y/IMrWyc+lj1 JoKa+Rw7bM5+LN8J0wOsDLI8BA== X-Received: by 2002:a17:90a:b392:: with SMTP id e18mr1151791pjr.205.1631613927864; Tue, 14 Sep 2021 03:05:27 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([204.124.181.224]) by smtp.gmail.com with ESMTPSA id d5sm1082133pjs.53.2021.09.14.03.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 03:05:27 -0700 (PDT) Date: Tue, 14 Sep 2021 18:05:17 +0800 From: Leo Yan To: Peter Zijlstra Cc: Arnaldo Carvalho de Melo , Adrian Hunter , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , "H. Peter Anvin" , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Michael Petlan , "Frank Ch. Eigler" , Song Liu , x86@kernel.org, Daniel =?iso-8859-1?Q?D=EDaz?= , Andrii Nakryiko , Alexei Starovoitov , Sedat Dilek , Andi Kleen , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org Subject: Re: [PATCH v5 4/9] perf/x86: Add compiler barrier after updating BTS Message-ID: <20210914100517.GC1538480@leoy-ThinkPad-X240s> References: <20210809111407.596077-1-leo.yan@linaro.org> <20210809111407.596077-5-leo.yan@linaro.org> <20210829105657.GC14461@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On Tue, Sep 14, 2021 at 11:51:36AM +0200, Peter Zijlstra wrote: > On Sun, Aug 29, 2021 at 06:56:57PM +0800, Leo Yan wrote: > > Hi Peter, or any x86 maintainer, > > > > On Mon, Aug 09, 2021 at 07:14:02PM +0800, Leo Yan wrote: > > > Since BTS is coherent, simply add a compiler barrier to separate the BTS > > > update and aux_head store. > > > > Could you reivew this patch and check if BTS needs the comipler > > barrier in this case? Thanks. > > Yes, a compiler barrier is sufficient. > > You want me to pick it up? Maybe other maintainers are more suitable than me to answer this :) Yeah, I think it's great if you could pick it. Thanks, Leo