Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Sep 2021 18:08:47 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Suzuki K Poulose <suzuki.poulose@arm.com>
Cc:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Mike Leach <mike.leach@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] coresight: Update comments for removing
 cs_etm_find_snapshot()
Message-ID: <20210914100847.GD1538480@leoy-ThinkPad-X240s>
References: <20210912125748.2816606-1-leo.yan@linaro.org>
 <20210912125748.2816606-3-leo.yan@linaro.org>
 <f6700a4d-80e1-cd53-232c-0e26f7179d1b@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f6700a4d-80e1-cd53-232c-0e26f7179d1b@arm.com>
Precedence: bulk

On Tue, Sep 14, 2021 at 10:27:26AM +0100, Suzuki Kuruppassery Poulose wrote:

[...]

> > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > index d23c7690f29a..ce14eb83925c 100644
> > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> > @@ -1573,9 +1573,8 @@ tmc_update_etr_buffer(struct coresight_device *csdev,
> >   	/*
> >   	 * In snapshot mode we simply increment the head by the number of byte
> > -	 * that were written.  User space function  cs_etm_find_snapshot() will
> > -	 * figure out how many bytes to get from the AUX buffer based on the
> > -	 * position of the head.
> > +	 * that were written.  User space will figure out how many bytes to get
> > +	 * from the AUX buffer based on the position of the head.
> >   	 */
> >   	if (etr_perf->snapshot)
> >   		handle->head += size;
> > 
> 
> 
> Thanks for the revised patch, I have queued both the patches.

Cool, and thanks Suzuki!