Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Sep 2021 14:07:41 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc:     linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-clk@vger.kernel.org, linux-staging@lists.linux.dev,
        Yong Deng <yong.deng@magewell.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Helen Koike <helen.koike@collabora.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 17/22] dt-bindings: media: Add Allwinner A31 ISP bindings
 documentation
Message-ID: <20210914120741.gmrqdlev2p7r6f5l@gilmour>
References: <20210910184147.336618-1-paul.kocialkowski@bootlin.com>
 <20210910184147.336618-18-paul.kocialkowski@bootlin.com>
 <20210913081808.esgqvz4eeatp4hkp@gilmour>
 <YUBS1sdHKUMZx6gx@aptenodytes>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="gqq67qthp5eyfcss"
Content-Disposition: inline
In-Reply-To: <YUBS1sdHKUMZx6gx@aptenodytes>
Precedence: bulk


--gqq67qthp5eyfcss
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 14, 2021 at 09:44:22AM +0200, Paul Kocialkowski wrote:
> Hi,
>=20
> On Mon 13 Sep 21, 10:18, Maxime Ripard wrote:
> > On Fri, Sep 10, 2021 at 08:41:42PM +0200, Paul Kocialkowski wrote:
> > > This introduces YAML bindings documentation for the Allwinner A31 Ima=
ge
> > > Signal Processor (ISP).
> > >=20
> > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > > ---
> > >  .../media/allwinner,sun6i-a31-csi.yaml        |   2 +-
> > >  .../media/allwinner,sun6i-a31-isp.yaml        | 111 ++++++++++++++++=
++
> > >  2 files changed, 112 insertions(+), 1 deletion(-)
> > >  create mode 100644 Documentation/devicetree/bindings/media/allwinner=
,sun6i-a31-isp.yaml
> > >=20
> > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-=
a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-=
csi.yaml
> > > index f4a686b77a38..c60f6b5403fa 100644
> > > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi=
=2Eyaml
> > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi=
=2Eyaml
> > > @@ -1,4 +1,4 @@
> > > -# SPDX-License-Identifier: GPL-2.0
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > >  %YAML 1.2
> > >  ---
> > >  $id: http://devicetree.org/schemas/media/allwinner,sun6i-a31-csi.yam=
l#
> > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-=
a31-isp.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-=
isp.yaml
> > > new file mode 100644
> > > index 000000000000..a0f82f150e90
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-isp=
=2Eyaml
> > > @@ -0,0 +1,111 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/media/allwinner,sun6i-a31-isp.yam=
l#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Allwinner A31 Image Signal Processor Driver (ISP) Device Tree=
 Bindings
> > > +
> > > +maintainers:
> > > +  - Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - allwinner,sun6i-a31-isp
> > > +      - allwinner,sun8i-v3s-isp
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  interrupts:
> > > +    maxItems: 1
> > > +
> > > +  clocks:
> > > +    items:
> > > +      - description: Bus Clock
> > > +      - description: Module Clock
> > > +      - description: DRAM Clock
> > > +
> > > +  clock-names:
> > > +    items:
> > > +      - const: bus
> > > +      - const: mod
> > > +      - const: ram
> > > +
> > > +  resets:
> > > +    maxItems: 1
> > > +
> > > +  ports:
> > > +    $ref: /schemas/graph.yaml#/properties/ports
> > > +
> > > +    properties:
> > > +      port@0:
> > > +        $ref: /schemas/graph.yaml#/$defs/port-base
> > > +        description: CSI0 input port
> > > +
> > > +        properties:
> > > +          reg:
> > > +            const: 0
> > > +
> > > +          endpoint:
> > > +            $ref: video-interfaces.yaml#
> > > +            unevaluatedProperties: false
> > > +
> > > +        additionalProperties: false
> > > +
> > > +      port@1:
> > > +        $ref: /schemas/graph.yaml#/$defs/port-base
> > > +        description: CSI1 input port
> > > +
> > > +        properties:
> > > +          reg:
> > > +            const: 0
> > > +
> > > +          endpoint:
> > > +            $ref: video-interfaces.yaml#
> > > +            unevaluatedProperties: false
> > > +
> > > +        additionalProperties: false
> >=20
> > port@0 and port@1 required?
>=20
> I'd say just one of them, does that make sense?

Don't we have some SoC with both? If so, we should have an anyOf here.

maxime

--gqq67qthp5eyfcss
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYUCQjQAKCRDj7w1vZxhR
xZnQAP0T5rrW8HglxlUdmhQBMd2gsP7z48fcaN5uOKJXVZgVogD9FAslehFY8qhg
xTl+YmcTWItiWy/6SBH6p5vjuNGCHQk=
=ePfT
-----END PGP SIGNATURE-----

--gqq67qthp5eyfcss--