Date: Mon, 11 Dec 2006 20:52:22 -0700
From: Matthew Wilcox <matthew@wil.cx>
To: Arnaldo Carvalho de Melo <acme@mandriva.com>
Cc: "James E.J. Bottomley" <James.Bottomley@SteelEye.com>,
       Andrew Morton <akpm@osdl.org>, linux-scsi@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH][SCSI]: Save some bytes in struct scsi_target
Message-ID: <20061212035221.GF21070@parisc-linux.org>
References: <20061212031718.GC6218@mandriva.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061212031718.GC6218@mandriva.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1166
Lines: 29

On Tue, Dec 12, 2006 at 01:17:18AM -0200, Arnaldo Carvalho de Melo wrote:
> }; /* size: 368, cachelines: 12 */
> }; /* size: 364, cachelines: 12 */

Saving space is always good ;-)

> -	unsigned int		create:1; /* signal that it needs to be added */
> +	char			scsi_level;
> +	unsigned char		create:1; /* signal that it needs to be added */
>  	unsigned int		pdt_1f_for_no_lun;	/* PDT = 0x1f */
>  						/* means no lun present */
>  
> -	char			scsi_level;

However, pdt_1f_for_no_lun is really only one bit, saving another 4 bytes.

>  	struct execute_work	ew;
>  	enum scsi_target_state	state;

enums are a bit of a pain.  Even though scsi_target_state uses only two
values, it's represented as an int.  Unless you're on arm-eabi, when
it'll use less.  And even then, it won't use less than a byte, as it has
to be addressable.  I wonder if we can turn scsi_target_state into a
bit.  That'll save another 8 bytes total.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/