Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        Hannes Reinecke <hare@suse.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        Keith Busch <kbusch@kernel.org>,
        Ming Lei <ming.lei@redhat.com>,
        Wen Xiong <wenxiong@us.ibm.com>,
        James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH v7 1/3] nvme-fc: Update hardware queues before using them
Thread-Topic: [PATCH v7 1/3] nvme-fc: Update hardware queues before using them
Thread-Index: AQHXqUm6T6C82dUskkeD5PNmrxWv4qujjQWA
Date:   Tue, 14 Sep 2021 13:52:47 +0000
Message-ID: <6C03188F-7715-4DF9-AC7E-52FC975ED214@oracle.com>
References: <20210914092008.40370-1-dwagner@suse.de>
 <20210914092008.40370-2-dwagner@suse.de>
In-Reply-To: <20210914092008.40370-2-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wzof+FX/dn/QHkWExb3Y+tp7zAukqmkXu94js1aQovKxZUL+RUuuVaS3lb3O?=
 =?us-ascii?Q?j4OMA5rFtt42vVaFVnqqAUL0HRR6snKNX+CslheEsXLqcnggscShah/5gBYO?=
 =?us-ascii?Q?ATYiHR7haYfIm+XubWEsSBa+1Djum2Dr3O1spygxZ1ge5+QDkTMnNk8mSXzp?=
 =?us-ascii?Q?w4jBR1HuxWYa6Bd4tUVE8zqvsjOlQSjHW+tLcZCUJ7O79/ANRrzE72Qj9h3e?=
 =?us-ascii?Q?gAy4Ga92WWF5GgWwm7UYXAI/DgvX+rqvEdjE+Gov7VGbpiYvtRijJbeuxGAF?=
 =?us-ascii?Q?arNuBmsLMsNYvIUxhzclKTLoRr3pLwW/lRtqrpZaY3pOx6j/u7Z/zakCe6Mq?=
 =?us-ascii?Q?ZgLneycAbzZ0Zcgu7CD76zdBMgF+UMelcWIVfN2Wh+OTFlpQHBHJ3e+FgKQg?=
 =?us-ascii?Q?Sz0tvfq9vVIe8h4PGYUOLNtip40JgEldXxXjml6qs0gfLZtznZP0+orAvyR/?=
 =?us-ascii?Q?A/WZxeKp2Xkqu1G2yCIN6ykSzBqFTJkCdzKunfHegiG+m+AWjRedK0cYHQy4?=
 =?us-ascii?Q?FhgB04NadtS6mp9MmCU05DNrXqO6ANZCAkBFQ5zOvp3G2kyKkp9wfIT+Bg/d?=
 =?us-ascii?Q?ozM1v1WSsKEEiyMIzQWlkBwpeY1OveXf6q8IrWG8/nxMapaEw4qDMOO/fzcq?=
 =?us-ascii?Q?1UlDYkt5ieelwCph51q/TqW0aOLOGHMO85mZIVt/44faJooEyEDfH3dewBDG?=
 =?us-ascii?Q?34yVRVzyZhhXKvSInfl6eqkII/9VZF2HoBvlQb/24fxZYKxHcanv7HCUnheC?=
 =?us-ascii?Q?gSF3AqE97tzEcO4wH9CGd2mb0M9cXSh1zZQkSWihnTbArkP2+ifsNdSWgaAb?=
 =?us-ascii?Q?hQTXQ+qd51gHq6gSI381l9Gza6uzhymqUxxAJoiXvuUZtaVag/uE1Z+ukJE6?=
 =?us-ascii?Q?qqYY2aGOo2C2R1wdiR9MV93WXgeAp8+sYOdsNuZarMscfx9DoXX8tFW3d2g1?=
 =?us-ascii?Q?lMmaD7TAcWSl/fbYa5WJ8SGkTvWEIWJv2wxWbx7qMY4NuqoqTDp8f7JppHnX?=
 =?us-ascii?Q?pmQNLPgpeOlw9CXd7ASJPwVsND2iHC7PRIccERvSFzW4+97/mWkZ9UUzOCrV?=
 =?us-ascii?Q?bnEOLAorB0PcjbMlyR1vdll3tnGqn+Aj/0wynYBoIVWidZEIGya30navz7LI?=
 =?us-ascii?Q?bbRo2fmkEERcsXM+Yp0Y2JriOKSsYD7lVxtOYuuqW6kT65oomTYaJIRhPPjc?=
 =?us-ascii?Q?7oGfkEW+Y3UyXlXsYewjLKb3oYXHFsb4p9ZgEJh+LADWGhUpSmIUjifo11Go?=
 =?us-ascii?Q?naewU41gagnSLyuGo6Gk7DxZRRcb27W9zWQCgs6NiFrXg4lttnNmGVSWAsrD?=
 =?us-ascii?Q?r0eGt8kBYqx/49tq4TjxpomH9X7GrXmTR72vUePeD3MBjQ=3D=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <67529CA79E2B904DAD2C163C5A19C1F1@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2934.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2acbd7d-0b94-4e8d-b0cf-08d97786efb0
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2021 13:52:47.9643
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eY3O25tAaN3ii8r5mpYtoVfGX3FyeZYIw2pvkPF6A3VV24CHJUOKRkB5zZw/nMDUK/gYDNESv4N6pe0EoTUVteHF1w/8nEugnYVxTSg9zbY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3126
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10106 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109140086
X-Proofpoint-GUID: Z-FArGX88vDMXqOtRacozcKd9fU54kOn
X-Proofpoint-ORIG-GUID: Z-FArGX88vDMXqOtRacozcKd9fU54kOn
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 14, 2021, at 4:20 AM, Daniel Wagner <dwagner@suse.de> wrote:
>=20
> In case the number of hardware queues changes, we need to update the
> tagset and the mapping of ctx to hctx first.
>=20
> If we try to create and connect the I/O queues first, this operation
> will fail (target will reject the connect call due to the wrong number
> of queues) and hence we bail out of the recreate function. Then we
> will to try the very same operation again, thus we don't make any
> progress.
>=20
> Reviewed-by: James Smart <jsmart2021@gmail.com>
> Reviewed-by: Ming Lei <ming.lei@redhat.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/nvme/host/fc.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>=20
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index b08a61ca283f..b5d9a5507de5 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -2951,14 +2951,6 @@ nvme_fc_recreate_io_queues(struct nvme_fc_ctrl *ct=
rl)
> 	if (ctrl->ctrl.queue_count =3D=3D 1)
> 		return 0;
>=20
> -	ret =3D nvme_fc_create_hw_io_queues(ctrl, ctrl->ctrl.sqsize + 1);
> -	if (ret)
> -		goto out_free_io_queues;
> -
> -	ret =3D nvme_fc_connect_io_queues(ctrl, ctrl->ctrl.sqsize + 1);
> -	if (ret)
> -		goto out_delete_hw_queues;
> -
> 	if (prior_ioq_cnt !=3D nr_io_queues) {
> 		dev_info(ctrl->ctrl.device,
> 			"reconnect: revising io queue count from %d to %d\n",
> @@ -2968,6 +2960,14 @@ nvme_fc_recreate_io_queues(struct nvme_fc_ctrl *ct=
rl)
> 		nvme_unfreeze(&ctrl->ctrl);
> 	}
>=20
> +	ret =3D nvme_fc_create_hw_io_queues(ctrl, ctrl->ctrl.sqsize + 1);
> +	if (ret)
> +		goto out_free_io_queues;
> +
> +	ret =3D nvme_fc_connect_io_queues(ctrl, ctrl->ctrl.sqsize + 1);
> +	if (ret)
> +		goto out_delete_hw_queues;
> +
> 	return 0;
>=20
> out_delete_hw_queues:
> --=20
> 2.29.2
>=20

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering