Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hannes Reinecke <hare@suse.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        Keith Busch <kbusch@kernel.org>,
        Ming Lei <ming.lei@redhat.com>,
        Wen Xiong <wenxiong@us.ibm.com>,
        James Smart <jsmart2021@gmail.com>
Subject: Re: [PATCH v7 3/3] nvme-fc: Remove freeze/unfreeze around
 update_nr_hw_queues
Thread-Topic: [PATCH v7 3/3] nvme-fc: Remove freeze/unfreeze around
 update_nr_hw_queues
Thread-Index: AQHXqUm6rrULTUaw/k+KK4RXW1oSXqujjb4A
Date:   Tue, 14 Sep 2021 13:55:23 +0000
Message-ID: <4B62612F-EAA9-4E2B-9CCC-6C5C60C73EEC@oracle.com>
References: <20210914092008.40370-1-dwagner@suse.de>
 <20210914092008.40370-4-dwagner@suse.de>
In-Reply-To: <20210914092008.40370-4-dwagner@suse.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tLRZN7Q3sOyA2dJFEHHHEgKlfL5zaoiOTjDx6Rz+FAHF/OeIgGJQolPRQ2Rg?=
 =?us-ascii?Q?pHDLrdo9sT5hNkzQ+/ziVPMJ5WgKacXJeJVmwCyEZpeu/D7wygdxJN4eXa1d?=
 =?us-ascii?Q?ayYFrNBiKk/9fclssTuTDfIEs2oFaMTUlVSBQJJXwaj26a7je+p7tPRSs2xc?=
 =?us-ascii?Q?xUFUx6Fo/hJk7wQbhyh1Chm0+hHz8FhlUJxBNgtR74e9nmSLE05lglYnR7Uq?=
 =?us-ascii?Q?PtE1JRxUS83d3TkS7mlCNraUGLvnV9QoxarJqwR1FpXZYUdiWrLWoCVl+r0c?=
 =?us-ascii?Q?N9rGWDX1OtWcjRivlMkPUn8kR1MS1AIm7CCO0yXzBTK9+jB03jRv4RlegLGx?=
 =?us-ascii?Q?ACrba8wqnv8PLLgZpG+dy/lsRZ1Hubj/Rtyc9331taMe6Dj3cOQdWlX2qPvP?=
 =?us-ascii?Q?Z85A/lqThZy7XftlEE0+7DVclKyiU0iMxMchthg/i1ebsKETCWNSyxrN7Ao4?=
 =?us-ascii?Q?QIBXHVO/mh0OAWpzDtrkU4QSozRjcaX1GufQ2n9ZXL2S2XdCN45qIbb8xiVn?=
 =?us-ascii?Q?xrFbgyt5cdAeyabcLw+ISVwMhdZ50LBQDhfqfDUjarvEEL42j6BhtftqFsW5?=
 =?us-ascii?Q?CNwsV2OUoX9vCG8/VP1p6Ky8HmXCGaEv2xR4pclZslf2tL8SGx9oXNROikgg?=
 =?us-ascii?Q?DeSuC/B1JOU/Q+YJM3M8vEfr6WpE/sP/TpMFNEx8ruzYd1/nL76miwbxzTef?=
 =?us-ascii?Q?fX1HLOXM1eVGU21xKlel1zPcZ3/2lPONd3xFv0AGhIyTX34cMCzFrYNOV4uG?=
 =?us-ascii?Q?dA/2SSiLOVnqpOCM0DY00ZDvDaVAyeiYbTAKSunsD0seJ4+wRgyXWy7HUvzv?=
 =?us-ascii?Q?85wpweGoZVTf1osMV8T6WJazbplmWKp5u0S+QkPCj5scBsxKmCXHznt6FTcf?=
 =?us-ascii?Q?K5ti97f+kWC6guGS7Wu+amZTs576z5Fvk3oD6PXaMApeg1bn1QLGiFIc1Auv?=
 =?us-ascii?Q?kBB1bRCTCSenPGR5mC3P7itH1f++BEVM6kSn/UvajxBfVkSxfhBeEQirITaY?=
 =?us-ascii?Q?/DvBfecUgYMqprjfUKXohjNEKX/JUtCGjzjJyxPEZjmaC2IgyJwY/4jPLfaD?=
 =?us-ascii?Q?lVpaHb6QINjT3e63Ug4KG+1jTQ/llMJwtausYyjsVs7/apPvu285UoMpgy+e?=
 =?us-ascii?Q?SiSXsJWwD7dzQZ0lMj2T/lt5eApsvvRSBq3dju+cVNwWmXM3sTSOTuwFSS2E?=
 =?us-ascii?Q?Fd3Qw+u7MAMoxgcxQlP8NMJC6tB9NhcZSFxybFwFJj+Thsqpjn8gViWxoTm4?=
 =?us-ascii?Q?eh52Tg16aTUPqHSvnc/4iDJS5oMMqGs2jJnp2M+S9IeSaI6oMENJwByKvLNM?=
 =?us-ascii?Q?RGXjTvKLlMNF5n2hpbl++O0uGQNU7EjJMUiVmOTYD6aOrA=3D=3D?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20DB8EF8DD235A41A97C602B88CD249C@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2934.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9eff3b43-fd99-484f-d588-08d977874c64
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2021 13:55:23.4973
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X4stMUxYNcgqDDMIwOztYmEoAcybJxmTNKYgdTnLHzlU6c4STkgNa+bMXhdjhYaQI6+dGlDQGPteKcMahD4hlaUxgwTNm59XHCbizUCko0c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5518
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10106 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0
 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109140087
X-Proofpoint-GUID: S3bPV2QS2jWecu45PBy9O1N316AAxOEJ
X-Proofpoint-ORIG-GUID: S3bPV2QS2jWecu45PBy9O1N316AAxOEJ
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Sep 14, 2021, at 4:20 AM, Daniel Wagner <dwagner@suse.de> wrote:
>=20
> From: James Smart <jsmart2021@gmail.com>
>=20
> Remove the freeze/unfreeze around changes to the number of hardware
> queues. Study and retest has indicated there are no ios that can be
> active at this point so there is nothing to freeze.
>=20
> nvme-fc is draining the queues in the shutdown and error recovery path
> in __nvme_fc_abort_outstanding_ios.
>=20
> This patch primarily reverts 88e837ed0f1f "nvme-fc: wait for queues to
> freeze before calling update_hr_hw_queues". It's not an exact revert as
> it leaves the adjusting of hw queues only if the count changes.
>=20
> Signed-off-by: James Smart <jsmart2021@gmail.com>
> [dwagner: added explanation why no IO is pending]
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> drivers/nvme/host/fc.c | 2 --
> 1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
> index 6ebe68396712..aa14ad963d91 100644
> --- a/drivers/nvme/host/fc.c
> +++ b/drivers/nvme/host/fc.c
> @@ -2957,9 +2957,7 @@ nvme_fc_recreate_io_queues(struct nvme_fc_ctrl *ctr=
l)
> 		dev_info(ctrl->ctrl.device,
> 			"reconnect: revising io queue count from %d to %d\n",
> 			prior_ioq_cnt, nr_io_queues);
> -		nvme_wait_freeze(&ctrl->ctrl);
> 		blk_mq_update_nr_hw_queues(&ctrl->tag_set, nr_io_queues);
> -		nvme_unfreeze(&ctrl->ctrl);
> 	}
>=20
> 	ret =3D nvme_fc_create_hw_io_queues(ctrl, ctrl->ctrl.sqsize + 1);
> --=20
> 2.29.2
>=20

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering