Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp706910pxb; Tue, 14 Sep 2021 07:06:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFk1yqdhaiGxCXfJKx4yd63e+GgG7s0eegNyJ6ezEb+iGzwNl0MSwP59uFJ3OBmKknf3xh X-Received: by 2002:a5d:8a0e:: with SMTP id w14mr13730357iod.94.1631628373366; Tue, 14 Sep 2021 07:06:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631628373; cv=none; d=google.com; s=arc-20160816; b=esyaioSqEa7W3kYaeUkQ/cA0I+9dEX52qvZh+AHbKwKuuQ2sPcL7/5Sb/CHfvWc8vC zQNtSDvL/IASR0AvV/CXtidgp7E+35TZKnBP0DHa3jKtdMUl96mVLu51EDmyZk8KsRLT +xk5GoOvbSblY1DgFdr4YZNixtoWUoXYVQZVz3Od4gNcizagA40RYAQK6WdTWBUjvkHT zQDb/SDlcsIkGeRsUaPZAGYGUA6JQWvjm4MqA/qq3kfI9G8SKgqPJLQvyJr/oAhTd8xU YCYPL257nHqxHuqu+FJMtBSj2i192jATwKptdx/dPzgRaoaA5R7iAeU0w4Hyub1bgwlx IWog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=B0g/vugI7KSWU1duUBy+kHWUSxesWlpjw4t6LKYwCRo=; b=R3uRrwCdOoFbj/InImGZey+ayw7BimE5OHa1o7LV+5BfdGGMc3v5HtKUFLIlMfrARc jUYowQkpan36iNPRZqFP3OU3XyeD98tjTayYo+R8O4kw7rZ0kP0bfptITxWAOIME8uAO q4i7Z5YE/uJjqQauemizZzx1H70NeidB024Qt5q5KaJSkry9ofkvTOWcYhdinJi02mck 3+WL8zHYnvHcYWx9APHPh0Hl9ZVWGW6rJjGHMPDWRu7tYPS1ExkD/OH0/dV4p69PyIAv l9Z+A/diFAgw+dZ11BhsJlRaz8DyRBq+PR1vAJawTZeYSjq6/Nt/ECKa7Ue4Xd4JF90w v1Qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sh0LzS3s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c32si10087608jaa.44.2021.09.14.07.05.53; Tue, 14 Sep 2021 07:06:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sh0LzS3s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233494AbhINOF4 (ORCPT + 99 others); Tue, 14 Sep 2021 10:05:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:41830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233438AbhINOFz (ORCPT ); Tue, 14 Sep 2021 10:05:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 48B5D6109E; Tue, 14 Sep 2021 14:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631628277; bh=iQJMVWDJXIz4+Xnw+Zmg2wTPTmdj6J/jGV1015/5YnY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=sh0LzS3sjwfoLX0GTTG4bYX4blk6Ke37ZobsjjU36s3FXmpuukuAVFMlrgFE8TZhx EeJTMn0gyT3HSSR4sdkvIe7StpiDB7V85s8j29p5SpXCMfl73qNxySVT8Ie60y2vcV vpix8KeCPPe3P81A+ergZLI6GmhIf4aMDBVK6jpzZa3jwvCpze4fyg8qmaNhURy5Wf aiHr6ir8zwQlRN1fT/mqpLFTqaLxoP/fDxYZ5qICbI5RjU8kbA9HYnpJsD8/cwosjB jIfwjYdhrAcZvCqucxW3WWay2IaphC8JawlfMJP8AiOGLWbBeG+Fw3+RZR7Y1aDhJR 6oIELkkIGQ5Hw== Received: by mail-ed1-f47.google.com with SMTP id t6so18690146edi.9; Tue, 14 Sep 2021 07:04:37 -0700 (PDT) X-Gm-Message-State: AOAM5310p/B6mj6bG67L2XaY/HsdqnmaocVzCvDZ9IrnxLOBCdONFl0S W+sFC8mrsvUTDXFH5XlItBwpJl6xlzk4xm2Wbw== X-Received: by 2002:a05:6402:b23:: with SMTP id bo3mr16054495edb.145.1631628275923; Tue, 14 Sep 2021 07:04:35 -0700 (PDT) MIME-Version: 1.0 References: <20210722121242.47838-1-manivannan.sadhasivam@linaro.org> <20210722121242.47838-3-manivannan.sadhasivam@linaro.org> In-Reply-To: <20210722121242.47838-3-manivannan.sadhasivam@linaro.org> From: Rob Herring Date: Tue, 14 Sep 2021 09:04:24 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 2/3] PCI: qcom-ep: Add Qualcomm PCIe Endpoint controller driver To: Manivannan Sadhasivam Cc: Kishon Vijay Abraham I , Lorenzo Pieralisi , Bjorn Helgaas , devicetree@vger.kernel.org, PCI , "linux-kernel@vger.kernel.org" , linux-arm-msm , hemantk@codeaurora.org, Siddartha Mohanadoss , Bjorn Andersson , Sriharsha Allenki , skananth@codeaurora.org, vpernami@codeaurora.org, Veerabhadrarao Badiganti Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 7:13 AM Manivannan Sadhasivam wrote: > > Add driver support for Qualcomm PCIe Endpoint controller driver based on > the Designware core with added Qualcomm specific wrapper around the > core. The driver support is very basic such that it supports only > enumeration, PCIe read/write, and MSI. There is no ASPM and PM support > for now but these will be added later. > > The driver is capable of using the PERST# and WAKE# side-band GPIOs for > operation and written on top of the DWC PCI framework. > > Co-developed-by: Siddartha Mohanadoss > Signed-off-by: Siddartha Mohanadoss > [mani: restructured the driver and fixed several bugs for upstream] > Signed-off-by: Manivannan Sadhasivam > --- > drivers/pci/controller/dwc/Kconfig | 10 + > drivers/pci/controller/dwc/Makefile | 1 + > drivers/pci/controller/dwc/pcie-qcom-ep.c | 710 ++++++++++++++++++++++ > 3 files changed, 721 insertions(+) > create mode 100644 drivers/pci/controller/dwc/pcie-qcom-ep.c Reviewed-by: Rob Herring