Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp787440pxb; Tue, 14 Sep 2021 08:43:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxq/gpGkg4b6b6PUjCTufDpcXy5FxgaGGSCXJhsNxKOUUw06w3BQUUgWGSrgPrDzQYfUxJN X-Received: by 2002:a2e:750e:: with SMTP id q14mr15786816ljc.338.1631634234066; Tue, 14 Sep 2021 08:43:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631634234; cv=none; d=google.com; s=arc-20160816; b=ABArPzuTtJBOoSN67gN6ETF11G0ze7OEYuUpNKAlNQFTLH4kv5XB7Cuew1M4jQ9bms R+mL+CuVi/gkXE0bqgMAMuK6hNwxZFPCpkS2kxqY3OQLYjNzg6j4xyQ+uqG6c+9O0+XI ps3nkZ0nDmKVjdE2BQPmp5e0P+64BPyk0OoM8xiZK/mbAO8gsS3qObhkeXvgZ/mYF+2/ QxL+FFlx2g87qONnGFBDeh5zlU2x1eNhG44VwifGZ2ecRPhOR4yrd2RTVL3zyM2LeZsO aGT4rFOPPP5R3ghuX3D7aQSGE9Yuo7i3KXd0qC1F4NXquVbg+nyVsyob8wtMkvk988Wk MC0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=w/PWCz+gVwOhYtT53nLZDbZBZ8m1bVTQyVZSM3uoo0uoXnQ2X9FQidWCrbtwepUlqo 1jE67PX65sJzo4DYzGsaMT96QYZJvzr0oYym4+a1IzfWHY82dUb+yIa1K6l7wT1tEBo4 SpLDxdMuT7jp8BRqpUIwsAWM1bnn7ouCl5fu8cem99+BHMzOU0Ohsgwx6oyYpwpmBfMj rqd6U4lVBm0utred38e+axtMsjcA/OGEn06SEhfVIBzq5WgRqCM0iyCEEgTlziD4zliu sDZf10p9oeWe9y3mS0hHVYMsoNA1unxC4iPxyJY+eTx2vwY302Yejdxc3TfukFR+vvI4 j9ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=BpcuMcoH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u15si13793088lfr.39.2021.09.14.08.43.18; Tue, 14 Sep 2021 08:43:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=BpcuMcoH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234534AbhINPmw (ORCPT + 99 others); Tue, 14 Sep 2021 11:42:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231966AbhINPmw (ORCPT ); Tue, 14 Sep 2021 11:42:52 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 897E1C061574 for ; Tue, 14 Sep 2021 08:41:34 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id y6so24775840lje.2 for ; Tue, 14 Sep 2021 08:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=BpcuMcoHH1B5L3A9rysqIc0UNfq5noiLE14zKeR1TSa0gFC85lOw2Beo8dO5honWby rYyCHFnHkKNi7MCpw7JrIjMcXxBeTw1cz/rDSABmNfOTKR6Ymn6YfZNGpWuykLc9dauc iTDBkLKWwlR9RhIlCft6lceQmUvWAku/ar3t0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dgZDRvewpIcHvEl+aClDgx6dxTBkhTg+5FlC2P6kQVc=; b=Wy+d4ay4dVoQffr09pRGZ3sB/W1QA6GdMYMAruL0unEYHo96LuXXfoYk6j0Gab8Sat HflqESjlADV/iNvhpIt/woGlCZALVsvnI/6GP2QmUUsUJJXUvCdmrblJqPP6K7At1t9U FFjs8ViH62w0cb9wceZnnrZThv9ChRugMjTt87s4k4l4coFZjgxjBLxNaM37qNaPStYB HXszvKPiXek0N1a6BkdPF67ZwfHcf9Fe+3FLAQGSqTFep9MMqwQQ//jcef03p3CQytRJ rrNsNqeZ7WLhR7oEeG+JANBsrKal1BaUzNcfh1T6rgE1wB5gGDuPXrGAwdASYx3/AkUf qwRw== X-Gm-Message-State: AOAM530d3fjthqwsUcVoFy88xyffj+lZZFG42bokACT34q4FlNzYRLHO IIE+vIx/rQgNPVzQfQ0W1sXnkFENnMKC/tIlAfQ= X-Received: by 2002:a2e:97cb:: with SMTP id m11mr16267031ljj.240.1631634091876; Tue, 14 Sep 2021 08:41:31 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id d7sm878420lfn.27.2021.09.14.08.41.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 08:41:30 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id r3so24760310ljc.4 for ; Tue, 14 Sep 2021 08:41:29 -0700 (PDT) X-Received: by 2002:a2e:a7d0:: with SMTP id x16mr15637818ljp.494.1631634089537; Tue, 14 Sep 2021 08:41:29 -0700 (PDT) MIME-Version: 1.0 References: <20210914121036.3975026-1-ardb@kernel.org> <20210914121036.3975026-2-ardb@kernel.org> In-Reply-To: <20210914121036.3975026-2-ardb@kernel.org> From: Linus Torvalds Date: Tue, 14 Sep 2021 08:41:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 1/8] arm64: add CPU field to struct thread_info To: Ard Biesheuvel Cc: Linux Kernel Mailing List , Keith Packard , Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Benjamin Herrenschmidt , Christophe Leroy , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Kees Cook , Andy Lutomirski , Arnd Bergmann , Linux ARM , linuxppc-dev , linux-riscv , linux-s390 Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 5:10 AM Ard Biesheuvel wrote: > > The CPU field will be moved back into thread_info even when > THREAD_INFO_IN_TASK is enabled, so add it back to arm64's definition of > struct thread_info. The series looks sane to me, but it strikes me that it's inconsistent - here for arm64, you make it unconditional, but for the other architectures you end up putting it inside a #ifdef CONFIG_SMP. Was there some reason for this odd behavior? Linus