Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210914154441.1726853-1-andreas@rammhold.de>
In-Reply-To: <20210914154441.1726853-1-andreas@rammhold.de>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Tue, 14 Sep 2021 09:01:16 -0700
Message-ID: <CAKwvOdnW8kNHFC2sSOASm63m1D5vULF9-UOy2mJrF2tPdgh6pQ@mail.gmail.com>
Subject: Re: [PATCH] gen_compile_commands: add missing sys import
To:     andreas@rammhold.de
Cc:     Nathan Chancellor <nathan@kernel.org>, llvm@lists.linux.dev,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Sep 14, 2021 at 8:44 AM <andreas@rammhold.de> wrote:
>
> From: Andreas Rammhold <andreas@rammhold.de>
>
> The sys.exit was being used at multiple locations within the script but
> never imported. This lead to the script exiting with a error instead of
> with the nicely formatted (useful) error output.
>
> Signed-off-by: Andreas Rammhold <andreas@rammhold.de>

Hi Andreas,
Thanks for the patch. Someone beat you to the punch though:
https://lore.kernel.org/lkml/20210908032847.18683-1-kortanzh@gmail.com/.

This is good; it means folks are playing with this. :)

> ---
>  scripts/clang-tools/gen_compile_commands.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py
> index 0033eedce003e..1d1bde1fd45eb 100755
> --- a/scripts/clang-tools/gen_compile_commands.py
> +++ b/scripts/clang-tools/gen_compile_commands.py
> @@ -13,6 +13,7 @@ import logging
>  import os
>  import re
>  import subprocess
> +import sys
>
>  _DEFAULT_OUTPUT = 'compile_commands.json'
>  _DEFAULT_LOG_LEVEL = 'WARNING'
> --
> 2.32.0
>


-- 
Thanks,
~Nick Desaulniers