Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp821485pxb; Tue, 14 Sep 2021 09:24:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsV62/C2fH5P+00QuWqHo0qTBDjSMfA9ghN0eiu7Vf4uDPn9UXvPt0YTRQaJHENVOki89R X-Received: by 2002:a05:6512:3983:: with SMTP id j3mr6602945lfu.529.1631636695218; Tue, 14 Sep 2021 09:24:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631636695; cv=none; d=google.com; s=arc-20160816; b=cOukQnSwlXai6rjEH7T7WIIWJ2XxUF7SuFgk4mXQmyrSZ5DaVwIQLKsjgXMho/Aj3Y iHRsVij5lxinyEmvyf7Q0oibsdvJlx+0mocdNBOjIkPxv42m04T585Mne1jW3FoslSlr NSTcmAM5EHp4T5zG77dBjpUJngnX+xKbU3BVV5JXspjIcIFW7fD7Ram66s30w8miCdiz +/oUCA46HeeONvJQqk/WwRxPwH5xKkPiRXN8WZBnp/j1ql/ay5rf3+JnAp2Z1SANSM8h CDYYuzblMFebG9NSu9GhW4H42YWAQ4KAMA8JUSyeO7UhCv1GAG+5bwutVbY5hf1zFs+J speQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=1FvZRHk3SBPfHYet08WVNMbl9U9iubGfahKVS5kswgA=; b=lskux1erh/RqxDcfkpxQ2eGCvANWDBijf2Q/lbBbnhE5FJivHH0CUM6ZIo8utIER33 myuuIK18rEDhdQVNwG3zYf/whH4KTnA+qV60VZaN4cz9IeB3yZw0cGDTsO3UXwB013vO 8y0xt7TIKTu+wsDoO+xQMliPl/TFkTMPxrvuxkeo6sC5VcE3Jq7lmzP7wcjmD3rOIWea sXNTb14QbiHPKO3c09U+WGN4LBpKce+2GKrdGy/EXBVeU2z/SUVBNXRTwSccqzWVdQON d3l3qkdmJiNi8qVp/ixFRwO522A98B1JcuI2KqYgZQpNzW7311p7ZMlOuIt2Ct8Ya12Z KOcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=jc4VIL8A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j28si1081427lfk.584.2021.09.14.09.24.27; Tue, 14 Sep 2021 09:24:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=jc4VIL8A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229529AbhINQV2 (ORCPT + 99 others); Tue, 14 Sep 2021 12:21:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbhINQV1 (ORCPT ); Tue, 14 Sep 2021 12:21:27 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B2BAC061574; Tue, 14 Sep 2021 09:20:10 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id b7so280049pfo.11; Tue, 14 Sep 2021 09:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1FvZRHk3SBPfHYet08WVNMbl9U9iubGfahKVS5kswgA=; b=jc4VIL8AuuvPriT9n13HDBh5j6ZGD7KA06UejblD3JhzLbO5fAnpivCvtJQ2E37qHo jUQwIYB23+YszX35Yk3eoM8QSBlZUFfpdQgPflf528djjT7wwouIiSERkL78Chl1UXcN g+QqwKq2pRC+SGgCbnl/HwPF7q5FScmOqEhIBLgtiBm/rspHX2g3SKI/FAMPooYMfoTb 0lgosZAGSu2CrpN93F4J+d5UqiABgG6FE0dwOIg2dFhmlOxW2krtwQ0Vd/Uoio3dbx3W zYD8MsBZwc0rp9/FetxAIjvq0xbr5Jc2xuDyNDlplDip0VgzIySG2AGYfmqhVUNx8hs5 UhgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=1FvZRHk3SBPfHYet08WVNMbl9U9iubGfahKVS5kswgA=; b=IgsfBpHOLY5XhlC2JCmLUMUcmFaRbzS7lpG62B+OZFqvXq5N9+FBFUWuRUTfOKme7k m5LdikxWy0Zot9SyGuc7yBGGjZw9b1vxI0t4bZcs5J69pAXoycAo/mbP4ww73wtmCC/6 RLOpDU+mVA993grPNNI30NukNd42vQtM2Mo1YZvTmvKwqP69ID3P07wtyZJrkoHEQNVS wlKlfhalgN2UbdYEKbr1s8crs3aw49u92jhxA5agR04JjrV79QM0HIy4gF544A0wmj/W X6aN+ixyByYotM23agjVmhzmvHGIEhTS+YSz5fX94aPnIHexdxBFmHZhDJTXDBXI9oFk Lq7w== X-Gm-Message-State: AOAM531HxgpoqAp90HeMCd6AQ58YnL0Qvtet+hQPYnuAd0UWrDgkvxF5 ezPCMla4YFt9b0PpISDkrnWd3gih8LA= X-Received: by 2002:a62:ee11:0:b029:3e0:88dc:193f with SMTP id e17-20020a62ee110000b02903e088dc193fmr5514807pfi.78.1631636409520; Tue, 14 Sep 2021 09:20:09 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-e24f-43ff-fee6-449f.res6.spectrum.com. [2603:800c:1a02:1bae:e24f:43ff:fee6:449f]) by smtp.gmail.com with ESMTPSA id x15sm11839238pgt.34.2021.09.14.09.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 09:20:09 -0700 (PDT) Sender: Tejun Heo Date: Tue, 14 Sep 2021 06:20:07 -1000 From: Tejun Heo To: Li Jinlin Cc: axboe@kernel.dk, paolo.valente@linaro.org, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linfeilong@huawei.com, louhongxiang@huawei.com Subject: Re: [PATCH v3] blk-cgroup: fix UAF by grabbing blkcg lock before destroying blkg pd Message-ID: References: <20210914042605.3260596-1-lijinlin3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210914042605.3260596-1-lijinlin3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 12:26:05PM +0800, Li Jinlin wrote: ... > Fix by garbbing the matching blkcg lock before trying to > destroy blkg policy data. > > Suggested-by: Tejun Heo > Signed-off-by: Li Jinlin Acked-by: Tejun Heo Thanks. -- tejun