Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1631629496.git.mchehab+huawei@kernel.org> <cf40784dd4169897f7a28cc4d9393e8eaae5b873.1631629496.git.mchehab+huawei@kernel.org>
In-Reply-To: <cf40784dd4169897f7a28cc4d9393e8eaae5b873.1631629496.git.mchehab+huawei@kernel.org>
From:   Rajat Jain <rajatja@google.com>
Date:   Tue, 14 Sep 2021 10:31:23 -0700
Message-ID: <CACK8Z6HzNiVXxcW+yokW+db6-A5VgxixdzE-5B=tR1_Ph9JORw@mail.gmail.com>
Subject: Re: [PATCH v2 01/29] ABI: sysfs-bus-usb: better document variable argument
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Sep 14, 2021 at 7:32 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> On almost all ABI documents, variable arguments are declared
> as <foo_bar>. Change it here too, in order to allow replacing
> such wildcards by regexes on a scriptable way.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

In case it matters:
Acked-by: Rajat Jain <rajatja@google.com>

> ---
>  Documentation/ABI/testing/sysfs-bus-usb | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-usb b/Documentation/ABI/=
testing/sysfs-bus-usb
> index 73eb23bc1f34..42103f0f54d6 100644
> --- a/Documentation/ABI/testing/sysfs-bus-usb
> +++ b/Documentation/ABI/testing/sysfs-bus-usb
> @@ -166,14 +166,14 @@ Description:
>                 The file will be present for all speeds of USB devices, a=
nd will
>                 always read "no" for USB 1.1 and USB 2.0 devices.
>
> -What:          /sys/bus/usb/devices/.../(hub interface)/portX
> +What:          /sys/bus/usb/devices/.../<hub_interface>/port<X>
>  Date:          August 2012
>  Contact:       Lan Tianyu <tianyu.lan@intel.com>
>  Description:
> -               The /sys/bus/usb/devices/.../(hub interface)/portX
> +               The /sys/bus/usb/devices/.../<hub_interface>/port<X>
>                 is usb port device's sysfs directory.
>
> -What:          /sys/bus/usb/devices/.../(hub interface)/portX/connect_ty=
pe
> +What:          /sys/bus/usb/devices/.../<hub_interface>/port<X>/connect_=
type
>  Date:          January 2013
>  Contact:       Lan Tianyu <tianyu.lan@intel.com>
>  Description:
> @@ -182,7 +182,7 @@ Description:
>                 The file will read "hotplug", "hardwired" and "not used" =
if the
>                 information is available, and "unknown" otherwise.
>
> -What:          /sys/bus/usb/devices/.../(hub interface)/portX/location
> +What:          /sys/bus/usb/devices/.../<hub_interface>/port<X>/location
>  Date:          October 2018
>  Contact:       Bj=C3=B8rn Mork <bjorn@mork.no>
>  Description:
> @@ -192,7 +192,7 @@ Description:
>                 raw location value as a hex integer.
>
>
> -What:          /sys/bus/usb/devices/.../(hub interface)/portX/quirks
> +What:          /sys/bus/usb/devices/.../<hub_interface>/port<X>/quirks
>  Date:          May 2018
>  Contact:       Nicolas Boichat <drinkcat@chromium.org>
>  Description:
> @@ -216,7 +216,7 @@ Description:
>                    used to help make enumeration work better on some high=
 speed
>                    devices.
>
> -What:          /sys/bus/usb/devices/.../(hub interface)/portX/over_curre=
nt_count
> +What:          /sys/bus/usb/devices/.../<hub_interface>/port<X>/over_cur=
rent_count
>  Date:          February 2018
>  Contact:       Richard Leitner <richard.leitner@skidata.com>
>  Description:
> @@ -230,10 +230,10 @@ Description:
>                 Any time this value changes the corresponding hub device =
will send a
>                 udev event with the following attributes::
>
> -                 OVER_CURRENT_PORT=3D/sys/bus/usb/devices/.../(hub inter=
face)/portX
> +                 OVER_CURRENT_PORT=3D/sys/bus/usb/devices/.../<hub_inter=
face>/port<X>
>                   OVER_CURRENT_COUNT=3D[current value of this sysfs attri=
bute]
>
> -What:          /sys/bus/usb/devices/.../(hub interface)/portX/usb3_lpm_p=
ermit
> +What:          /sys/bus/usb/devices/.../<hub_interface>/port<X>/usb3_lpm=
_permit
>  Date:          November 2015
>  Contact:       Lu Baolu <baolu.lu@linux.intel.com>
>  Description:
> --
> 2.31.1
>