Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp879115pxb; Tue, 14 Sep 2021 10:37:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeBMwgbS5URJuvcdXFE0rsmrhTdhoyOcy1XQBPuEd4IcTgAqXTtF9tXBTXVKgUs6q6Mr2V X-Received: by 2002:a05:6602:2211:: with SMTP id n17mr14674477ion.142.1631641052133; Tue, 14 Sep 2021 10:37:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631641052; cv=none; d=google.com; s=arc-20160816; b=x+7k6zENYVxN3wz5q5XEYnvqHTMBA0cpZlpiqRi62Gsjuw+KKFoqFPbnOgo+dUNfQe 8cZBjPenORvBiZTQcMxkVyViMtQ01vDiiXTSwUwILrj3D0sM5gF7MeYQFL2M+M4O+o30 3hK4Xf4aavpB3b1Aak61lqoYzdt5lfFbZq6w06F2PomfL799qyWOmi+Rg08Rm3xyr+L5 qwYO3LWBh+x1mZbp3gA6TPasYqPk1guAgeXU0qoR9EiklkyFsj6S6DfNaj9Clu8Cs+ss QJO7ItMh/bw2EdMss0F3zj61CZ/o0TnaUaSDhrZ2oEp9SglTe5Bv7U0kbu1L5EGb2YjB ZzdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TCWXyI0dCA3o9LNo2Tto0ba1D/bVTK0K8ReDaSSLteo=; b=bUZTdLLJ5u9kKrglYGvgNlxgfuVNTg32o51/5IW6u9Uak1TiBC5VsogS7Uersd3fo9 oM6cBoM9f3Pzf1kBoIbbIbprgztl12Dqbrd378EcohWBDQbDTZP4AQumpchKauDyigu3 Lb0nTavONy3Hb7a3Tqj99GobYjybl+W086PdVo+v8jdb/eoCyASR5/tFz8gW39MnWizk Fh3pbZdcUSkko0v8mzEUt7MYBN/q/LRaKTWK2FWvW//9Xkmsz6GA7qjta8ro0iPiJkKX BPwR4EEeCptYPSCTW4jeqwGmemrLTAStmh+cwjHpcDh5/PpWFpbDEM+UVnrPWiMLheeN G91A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=b7nxWKD6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w6si13644473ilu.79.2021.09.14.10.37.11; Tue, 14 Sep 2021 10:37:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=b7nxWKD6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229795AbhINRge (ORCPT + 99 others); Tue, 14 Sep 2021 13:36:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbhINRgd (ORCPT ); Tue, 14 Sep 2021 13:36:33 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D8AEC061574 for ; Tue, 14 Sep 2021 10:35:16 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id n18so13406744pgm.12 for ; Tue, 14 Sep 2021 10:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TCWXyI0dCA3o9LNo2Tto0ba1D/bVTK0K8ReDaSSLteo=; b=b7nxWKD6YEmrKpo4dDKxI+5EbtQtIWWCN/82l4Lkzwkyd/S/qHq1dm973Zo7LzF/OU MEyVcWvRsrwLgf1pGJhS7goyb4b1mW2+H0mz7yoEDowZAQ8vpX7+8BcGplLhEJUkLS7D AdQ7GuYw8N54jt3JZUQ+sPNYxkeHHO67vs3ok= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TCWXyI0dCA3o9LNo2Tto0ba1D/bVTK0K8ReDaSSLteo=; b=NFLToSgmNNa6mZLGam0nqIW1EjeC4GVs6TTR+5fXNZjHl1DhlefGBosdB6nlfGX5hK XT1p+iDxc2YUILM1chsuWpbyLGLSqCBi/5B2zL6jqJL1QefT28HjsNhrI3vs0hG2NQvO HqgM5JO9ipuSTuy9dZ6rt8zXdxI2vdsvhvBaut24cm77HBtTQcvtvLj5mPosRkjXJ1ke PWLGgNgAiP2qGHImiygPdI/4RWgKocXFbqnjG/jZQKVZUngaW/wZYZPjr3VM18Jw81Ey 9WfZ4NG4dyRyhdHeRmHkaSakJUn6av1MPykzEsI0tGq3rs+PbeqJg/kqlYsrnBqJaufc SDow== X-Gm-Message-State: AOAM532WtAcfVGpVlL6/p2OoKh7+kjld2Qiq2mRrSlrBciVkyt7HV2pW Pax8EEYWTTGu/mWvyox4fpn/yg== X-Received: by 2002:a63:1748:: with SMTP id 8mr16027568pgx.350.1631640915889; Tue, 14 Sep 2021 10:35:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x26sm11044067pfm.77.2021.09.14.10.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 10:35:15 -0700 (PDT) Date: Tue, 14 Sep 2021 10:35:14 -0700 From: Kees Cook To: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , Linux Doc Mailing List , Jonathan Corbet , Anton Vorontsov , Colin Cross , Ilya Dryomov , Tom Rix , Tony Luck , Vaibhav Jain , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/29] ABI: pstore: Fix What field Message-ID: <202109141035.B5444836@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 04:32:25PM +0200, Mauro Carvalho Chehab wrote: > If both /sys/fs/pstore/... and /dev/pstore/... are possible, > it should use, instead, two What: fields. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Kees Cook -- Kees Cook