Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bart Van Assche <bvanassche@acm.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Bean Huo <beanhuo@micron.com>
Subject: RE: [PATCH v5 1/2] scsi: ufs: Probe for temperature notification
 support
Thread-Topic: [PATCH v5 1/2] scsi: ufs: Probe for temperature notification
 support
Thread-Index: AQHXqTVBrRkhJGwiQEK7GP2aT950iaujnFsAgABXVkA=
Date:   Tue, 14 Sep 2021 20:02:38 +0000
Message-ID: <DM6PR04MB657572A17D9E6F8FCE3F7A69FCDA9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210914065320.8554-1-avri.altman@wdc.com>
 <20210914065320.8554-2-avri.altman@wdc.com>
 <20210914144706.GA3457579@roeck-us.net>
In-Reply-To: <20210914144706.GA3457579@roeck-us.net>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CEXWo5hg4vYg+4/pV26VS/sAXHwqVaSuyvaTfaIUpr7OgNkBwnr841Y/YNQ9?=
 =?us-ascii?Q?mvsh9eB81WOHC7g0Wairpu3U/BeL7HY8hfCKOfplUiYHIyNeMEFoqy1rpypr?=
 =?us-ascii?Q?Z3JIimOlf5t2cwEkaBAUJgsuz5jgtfDMM6ucncvE35r3DxgiOeGgxp5zV2g1?=
 =?us-ascii?Q?QSBQYepJdz7yipph3hm8f4FqFLHXJ81LbWiNM/NfnULjR4Cy+baOVe0IWKu4?=
 =?us-ascii?Q?Ii4/xMbZMJ1CszLobxdm0FFNU1II5Ip4QgC6KvwfnEHS8P9bH5MAz/gKMTrg?=
 =?us-ascii?Q?w03xF2xX4ytPiFbnzoPcQnenOz9rS1/rP2zeAyIclKW04ZKZGABWLEkYOPoV?=
 =?us-ascii?Q?Nwgzf1fh/TuDfXEw8hsl+L+EJ1Hf2p+tDfehJt5Ik9CZ6q+JttV5+/ZttVlL?=
 =?us-ascii?Q?jgxZtFbYX67+GGv+wQWOmnNYLtaaCVNWBXpCb4ruFx8YpGX2+tsMoUuHsdrz?=
 =?us-ascii?Q?ap/21uhEBrahOvTcxBQI+GjSXN/RmIA1lpsUsunBCExTtubTtK0neWrwBv2R?=
 =?us-ascii?Q?USFnmXW4ofw1Bzzfzn1bZWZzZJ2cpwPR3/GPNqNywAKaDJudY5sb/bLQvJxi?=
 =?us-ascii?Q?tOqiWQohRlzkeMQ5D9tQFrDVW/X7bbJY5kbxKQyw4mxRSN2suC4/1GKk/ppf?=
 =?us-ascii?Q?AFkPWjzZgaDtpmWrMt7NqO81iWeCkpj2ItVwmHn9SxvG5Dx5oZT3f+v4HdxO?=
 =?us-ascii?Q?vQUwbld1lmdKjae4DzUfY4J9pW0Jnx3+WoipekTMejEnWewjZ6df/I6v6zzK?=
 =?us-ascii?Q?bTKxYXltsGlsuY9yBP4y6174EPQI3lpaJ8vMKAXVMA8YS+CzpeER53ZlRLYS?=
 =?us-ascii?Q?oaHg0K5CKBxSnaWUG6NVI1sdvMMKM/5gOGJ96ZhX6vUNFkn63JMpm+DARUt0?=
 =?us-ascii?Q?80yGq6dPhUr+dkDMU7P2TP4J7GTjCKEBErUO9df0ejX0SJs4mXme3u0d4wcf?=
 =?us-ascii?Q?PstvI2mz7dtVTUiCDYRH2+8Cs8j6mevS8kDAdoqaZTgTyuhNycQEEGsXFLXU?=
 =?us-ascii?Q?SDNuT5JLNwL3r1YthUxsEpim6uhvqrdXudmJYfhjd3Da60LbWX/4hFUZV0SV?=
 =?us-ascii?Q?bcpsZxPfi/rkCoz66wzDNxT9JazV/CVz+/ZInLhFrX0veVuIPbHrQHr31a1U?=
 =?us-ascii?Q?hIXH5GPwekYEIXA9HpyWuYXQmcwNppMtBXLxWZzaQVeO1NUajrvlodjz1hCG?=
 =?us-ascii?Q?o/IrVEuN4N9NPs1ZFtw02DkVgcT+GkrGe32mnGjU3eqs8KsT204Nz+zsLOtu?=
 =?us-ascii?Q?uizbU8+RlIz9v1HOc+sGmiTn/O/AZTzuoQAxIHNr4AjraPl8j24p+AmZwYy4?=
 =?us-ascii?Q?bj/ELhzejXkjGum+ArZPaPY6?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 487f59d4-167a-4d7b-8f5b-08d977ba9a58
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2021 20:02:38.5727
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DqOdAKXcydMzOQoebakjtjHkoVAZ5xLCsfXjhQ86V4M2Hlo9lLTUCwhi266k2bbFhz1Si1StH3roMioTZakzwg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5081
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +static int ufs_read_temp_enable(struct ufs_hba *hba, u8 mask, long
> > +*val) {
> > +     u32 ee_mask;
> > +     int err =3D 0;
>=20
> Unnecessary initialization
Done.

>=20
> > +
> > +     err =3D ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR,
> QUERY_ATTR_IDN_EE_CONTROL, 0, 0,
> > +                             &ee_mask);
> > +     if (err)
> > +             return err;
> > +
> > +     *val =3D (mask & ee_mask & MASK_EE_TOO_HIGH_TEMP) || (mask &
> > + ee_mask & MASK_EE_TOO_LOW_TEMP);
> > +
> > +     return 0;
> > +}
> > +
> > +static int ufs_get_temp(struct ufs_hba *hba, enum attr_idn idn, long
> > +*val) {
> > +     u32 value;
> > +     int err =3D 0;
Here as well.

> > +
> > +     err =3D ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_READ_ATTR, idn,
> 0, 0, &value);
> > +     if (err)
> > +             return err;
> > +
> > +     if (value =3D=3D 0)
> > +             return -ENODATA;
> > +
> > +     *val =3D ((long)value - 80) * MILLIDEGREE_PER_DEGREE;
> > +
> > +     return 0;
> > +}
> > +
> > +static int ufs_hwmon_read(struct device *dev, enum
> hwmon_sensor_types type, u32 attr, int channel,
> > +                       long *val)
> > +{
> > +     struct ufs_hwmon_data *data =3D dev_get_drvdata(dev);
> > +     struct ufs_hba *hba =3D data->hba;
> > +     int err =3D 0;
>=20
> Unnecesaary initialization
Done.

>=20
> > +
> > +     if (type !=3D hwmon_temp)
> > +             return 0;
> > +
> > +     down(&hba->host_sem);
> > +
> > +     if (!ufshcd_is_user_access_allowed(hba)) {
> > +             up(&hba->host_sem);
> > +             return -EBUSY;
> > +     }
> > +
> > +     ufshcd_rpm_get_sync(hba);
> > +
> > +     switch (attr) {
> > +     case hwmon_temp_enable:
> > +              err =3D ufs_read_temp_enable(hba, data->mask, val);
>=20
> extra space before 'err =3D'
Done.