Message-ID: <457E9E81.9060307@tls.msk.ru>
Date: Tue, 12 Dec 2006 15:20:17 +0300
From: Michael Tokarev <mjt@tls.msk.ru>
User-Agent: Thunderbird 1.5.0.5 (X11/20060813)
MIME-Version: 1.0
To: Linus Torvalds <torvalds@osdl.org>
CC: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] pipe: Don't oops when pipe filesystem isn't mounted
References: <200612110330_MC3-1-D49B-BC0F@compuserve.com> <Pine.LNX.4.64.0612110741010.12500@woody.osdl.org>
In-Reply-To: <Pine.LNX.4.64.0612110741010.12500@woody.osdl.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 974
Lines: 28

Linus Torvalds wrote:
> 
> On Mon, 11 Dec 2006, Chuck Ebbert wrote:
>> Prevent oops when an app tries to create a pipe while pipefs
>> is not mounted.
> 
> Have you actually seen this, or is this just from looking at code?
> 
> Quite frankly, if "pipe_mnt" is ever NULL, we're dead for lots of other 
> reasons. 
> 
> In fact, pipe_mnt can't be NULL. The way it is initialized is:
> 
> 	pipe_mnt = kern_mount(&pipe_fs_type);
> 
> and pipe_mnt doesn't even return NULL - it returns an error pointer, so if 
> "kern_mount()" were to have failed, pipe_mnt will be some random invalid 
> pointer that could only be tested with IS_ERR(), not by comparing against 
> NULL.

http://marc.theaimsgroup.com/?t=116510390600001&r=1&w=2

/mjt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/