Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1054721pxb; Tue, 14 Sep 2021 15:19:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3UAx51t5peUWDSXK32gL/4rwwcbeLFtoYXk+6fKgNSxYbpx3hA5Ur/FKqjIzU2mijbHsD X-Received: by 2002:a92:d90b:: with SMTP id s11mr10932970iln.206.1631657963399; Tue, 14 Sep 2021 15:19:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631657963; cv=none; d=google.com; s=arc-20160816; b=Z70lXICXfwTujhizYrhuCuLiytN/AjWhrAVnjP5pYV4mIxQX8QaobV8msg+x4NYrfg yjcngpwzWr3+QEHBWwmodzvaXwJ8bWZ8QuztJWvPWi0dRyBvHygpPCoPy93WmINoc0Ty 2Kj8xnYjZatzBpAKvfSURmjzxdcDuHBQaijMVf6CkKSrjGoQtAgdb4Cc+skF9EsaM66q FBAx6xOamftHPgrLgqEPTxGcYzS97ygm+mLjLu75yY8iiwMrFvkFiEJcs3CHML6KRO/H LYRu3yX81JNuRsufgmZP74avzEZ+ROXE+nj9473LxZaYwVM1NONyLro/ZRwOFA5Vn/gW KYUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=Hr9cKqBBHwOk/0NXW4zjh3+K/+9PPCpQdoKHJf6XeZs=; b=VkdHy8lsjRsXeXKPW6lZttrd19v/0jWYBZVZiE0zFEB7H1IjoE2MfulcktxtWwH5FH hsO7RFLfexLPxXw3hbbrt9QE3gvyWV93VkCb6dvkxKSYrqpd/YpSa6xaf3oYipq80ncB wYCw1l93m5f9pjQLbvYaiXiaGeEN38YGgVb/sV7H0RTyUK1h1YvURXFyH9NVFK+++zyN f/hkXHUNQ8vXl8I474yCUN/yRIaPOoQlgJs8CJfL7Rj52Szn6EXOAsKNAgKdfoEbtSQw yCWhJJqbmuocPtyDYcSG937lLyra8oUtxvhmC9ukTFYg4YaOXwWlBEKehoa5sHWqYDoe 3HkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ej69gGw8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si1245891jas.73.2021.09.14.15.18.55; Tue, 14 Sep 2021 15:19:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ej69gGw8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235486AbhINWTV (ORCPT + 99 others); Tue, 14 Sep 2021 18:19:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:53890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235478AbhINWTU (ORCPT ); Tue, 14 Sep 2021 18:19:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4ED116115B; Tue, 14 Sep 2021 22:18:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631657882; bh=Hr9cKqBBHwOk/0NXW4zjh3+K/+9PPCpQdoKHJf6XeZs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Ej69gGw8jeXiptvPKmWyB5qouz35oA7AekdnmIT/74BoflpWylhp/Rmvy3MXBm3gG vYduypA82OaY5I8sftwHuFslF+LldERTR5GfHbC7dBxy3DBsqB5ruIaIsTTGNhZp2x X3vBpKuU0q/u7FaaJ0g4WlZIiVWUH5/VPSbJWkmAZci7VbBHye3715+UKXwv5/zmOJ 27t2ccKBwE8MNpUbC+dojUHBH+FRhOIjAoZuAIUB+XuX9/3Tj+QLVJppU/XdZBQL7B 2qN5UsaQveTprM6hxKuobuUyspIAnnrod30T/bbViVzktRQ7sGrq9wZWHLTBS+wJ0o AT2ESoN2Nh65w== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210914021633.26377-4-chun-jie.chen@mediatek.com> References: <20210914021633.26377-1-chun-jie.chen@mediatek.com> <20210914021633.26377-4-chun-jie.chen@mediatek.com> Subject: Re: [v3 03/24] clk: mediatek: Fix corner case of tuner_en_reg From: Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Project_Global_Chrome_Upstream_Group@mediatek.com, Chun-Jie Chen To: Chun-Jie Chen , Matthias Brugger , Nicolas Boichat , Rob Herring Date: Tue, 14 Sep 2021 15:18:01 -0700 Message-ID: <163165788118.763609.9804318993707120972@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Chun-Jie Chen (2021-09-13 19:16:12) > On MT8195, tuner_en_reg is moved to register offest 0x0. > If we only judge by tuner_en_reg, it may lead to wrong address. > Add tuner_en_bit to the check condition. And it has been confirmed, > on all the MediaTek SoCs, bit0 of offset 0x0 is always occupied by > clock square control. >=20 > Signed-off-by: Chun-Jie Chen > Reviewed-by: Chen-Yu Tsai > --- Applied to clk-next