Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH bpf] bpf: update bpf_get_smp_processor_id() documentation
To:     Matteo Croce <mcroce@linux.microsoft.com>, <bpf@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>
References: <20210914222306.52522-1-mcroce@linux.microsoft.com>
From:   Yonghong Song <yhs@fb.com>
Message-ID: <322d781e-3e69-aa5f-7b99-5c8bc768e87b@fb.com>
Date:   Tue, 14 Sep 2021 16:01:36 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <20210914222306.52522-1-mcroce@linux.microsoft.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnB0RVdONXB6R0tYM1U4RmR3ZDlXWFVXalhncFVnKzB2U3lwbG43eW1pQ2Ur?=
 =?utf-8?B?YmJEUEM5TGtYdGFVUFpDeWluZ3VEVC9qMUNhbmYyUVhTb09rY2dtYmdVVzRs?=
 =?utf-8?B?WW82R3BHTDBnZ1Y4cnlMUW5ONTFCenF3cVQrTDhaWmVXdkc2LzQvanhweGdV?=
 =?utf-8?B?Ui9WZy9zbTNZWjR2N1lDUVV1c0FWSmcybnVxZTZ1NGEzMjNhendjVTRZeHp3?=
 =?utf-8?B?eDNEdEViS3BGcUVlaXRhOGtBMGFRdmJuTkVhVkxkajJ5cUxlNjBtTS80NWFO?=
 =?utf-8?B?eHVWSUFVVnp6dWxrUzFieEpkY0lhT3JkRHlDaU90MWtaUW1QOHlHWlBxdkcy?=
 =?utf-8?B?amJULzduYjdGdTFLU0k5Mmh5MlRiMEk1L3QxRTk5VWY1UklhNnowbnRXVTdJ?=
 =?utf-8?B?WVZXS3JVUktZaTVHU3ptaXRxck93MHN3ZURIa3dSQlRyYU9HTFdjU2JwT0pB?=
 =?utf-8?B?aEIyczdrZWZoWlNZd0F5a0VwV0MvS3R5UmhXaEpOZTh3RlMvaERRS2R2L2pM?=
 =?utf-8?B?OWxXYUZidVVjSlFyK3NhU0tzeGxrMGFFeTVhVXN0LzY4N1BQbUdteWR1VGs2?=
 =?utf-8?B?MmxWSFRwKys0YmZ6OUlPemExRmZJUlZJdmp2THRGTGg1QUorbGp5WXo1V3FI?=
 =?utf-8?B?MFEwWUNRS1BobVhidFI3eE11bVJPbDBrMUdtN1VjL2NvZnZobDcxbnk0WWRn?=
 =?utf-8?B?amdVdFZHR1BRZG16NFpKdzZHUU4raVlWZVF4TnFDS1orZkpobUo0L3BkWTJi?=
 =?utf-8?B?YXpxcXpoTFVCa3EzNmJaclByczZ5WXFOelFOdG5TaDZnZjhHMUhzSUFsbktK?=
 =?utf-8?B?L1BjK2JZQXU1ZFc4TllBd1lLcmMwSGtPUGFQc0J0eEozaGhURXM0NUpwTWxl?=
 =?utf-8?B?dTlCTUlGRUc0dHNlWUgxNzFjQkE0OExjSVBZdGMwbjhITlZ1VkRueUpENUVn?=
 =?utf-8?B?TGQ0R0pVaVhwdVFHUW9kT1V4Q2hZMFNUendYNHFiemdBbVovTXBTSm1zck9P?=
 =?utf-8?B?NFJwWmZDSmpWWGdJMkI5MjhaQ1JTQ2c4aWt6MG82aXVlT2JLNHQ0dVlmdHRY?=
 =?utf-8?B?Qm9ZNWozRE5LY0tzS1RKRHVzRDdtRzhtbkcxVm5vSFBXQ2tlYUE3WXFPd2Fw?=
 =?utf-8?B?V0NTZmQxMG1KRWhqRUlFM3Vaa0syTkhaRkN0V3RrQlZHenR3TVFrcWJocHBE?=
 =?utf-8?B?Qkhtb2k2Q21qZkVLRk5GOEkwTS9SejZiOWlQVVYrdEdUclVFa0lvTTJxa3Y0?=
 =?utf-8?B?S1FHbThNYzFsMkNrVUdIeDA3dmJwVjhXTDR3NkkvWndQZWhKQXlYTm5Ea0sv?=
 =?utf-8?B?SnliSnhIMEI2UWV2aDZvc1c2akE1azZRQmJVOUtrTkhNTnhCMWhxZ3h3aVd5?=
 =?utf-8?B?WnByNWRieG96MVVpd0pYZ3BnSnBsdlJSQkluSlNjUXZNeUZJV0JubTlYSVFP?=
 =?utf-8?B?WHlCYUp6MEc3MkROYmt3Uk5YSWhqTldwU0VCeDBWS1FUMU1YRXRRaSsxQUZs?=
 =?utf-8?B?ZytNd0sxRDl6YlpHWFNQM1k3YmhodDVUWDZIQkNVaHBCeXpOR1g4WXkyUTFN?=
 =?utf-8?B?aDNzS2FxRGFYRU1pdnhCSXF0aDAreXpPcFIzaHZ3MXlKMTQ3alM2T1o5Z3hr?=
 =?utf-8?B?Wk0rU3JVOU9UbS9CcUZqcFpma2tmeit5N0RhMzdHZG5TeVdubkVqWXgzK0ZG?=
 =?utf-8?B?Nm9CNE90Q3lzL3VPRTlyaWNXbEtvMlpzWlNhVklxTDk4a2g3UjJOSXhVWWhW?=
 =?utf-8?B?L0tvN2I0YktBM1B4bjlPU3oxbThXYkdIQXB5aUJldmF6MThjb01mLzdmTXIy?=
 =?utf-8?B?cVV3S0Z3aERudFVKOU1WQT09?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8927d2d2-9148-4d8d-61a8-08d977d39c7e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2021 23:01:39.8338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fptk2lGY3NSqE++xXxFCcdJamcZqk+gQjSk7Romi367QDaHu0xKs1SwKQS1Z6uri
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB4419
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: GolIvVTjMWCPIYwHpTKGtp5oQsWqgAyA
X-Proofpoint-GUID: GolIvVTjMWCPIYwHpTKGtp5oQsWqgAyA
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475
 definitions=2021-09-14_08,2021-09-14_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxlogscore=941
 clxscore=1011 bulkscore=0 lowpriorityscore=0 spamscore=0 adultscore=0
 mlxscore=0 impostorscore=0 malwarescore=0 priorityscore=1501
 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2109030001 definitions=main-2109140132
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/14/21 3:23 PM, Matteo Croce wrote:
> From: Matteo Croce <mcroce@microsoft.com>
> 
> Since commit 1e6c62a88215 ("bpf: Introduce sleepable BPF programs"), BPF
> programs can sleep if the BPF_F_SLEEPABLE flag is set.
> Update the documentation accordingly.
> 
> Fixes: 1e6c62a88215 ("bpf: Introduce sleepable BPF programs")

I think we don't need this Fixes tag as this patch should target to
bpf-next tree. There is no need to backport to bpf tree since it is
just a documentation change.

Based on *current* implementation, referring to sleepable BPF
program commit is not needed any more. See below for the suggested
change.

> Signed-off-by: Matteo Croce <mcroce@microsoft.com>
> ---
>   include/uapi/linux/bpf.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index d21326558d42..5e3b2fb62d84 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -1629,9 +1629,9 @@ union bpf_attr {
>    * u32 bpf_get_smp_processor_id(void)
>    * 	Description
>    * 		Get the SMP (symmetric multiprocessing) processor id. Note that
> - * 		all programs run with preemption disabled, which means that the
> - * 		SMP processor id is stable during all the execution of the
> - * 		program.
> + * 		programs run with preemption disabled unless BPF_F_SLEEPABLE is
> + * 		set, which means that the SMP processor id is stable during all
> + * 		the execution of the program.

Currently, migrate_disable() means true migration disable and preemption 
is possible, and BPF_F_SLEEPABLE programs are also protected by 
migrate_disable().

So the patch should just change "with preemption disabled" to
"with migration disabled" to reflect the new implementation.

>    * 	Return
>    * 		The SMP id of the processor running the program.
>    *
>