Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Sep 2021 19:28:15 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Shai Malin <smalin@marvell.com>, Adrian Bunk <bunk@kernel.org>
Cc:     Ariel Elior <aelior@marvell.com>,
        Sudarsana Reddy Kalluru <skalluru@marvell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bnx2x: Fix enabling network interfaces without VFs
Message-ID: <20210914192815.0376cb73@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <SJ0PR18MB3882AD2C9F93E24C35A2E6FECCD99@SJ0PR18MB3882.namprd18.prod.outlook.com>
References: <SJ0PR18MB3882AD2C9F93E24C35A2E6FECCD99@SJ0PR18MB3882.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 13 Sep 2021 11:18:33 +0000 Shai Malin wrote:
> On 9/12/2021 at 1:42PM, Adrian Bunk Wrote:
> > On Mon, Sep 13, 2021 at 08:14:33AM +0000, Shai Malin wrote:  
> > > Thanks for reporting this issue!
> > > But the complete fix should also not use "goto failed".
> > > Instead, please create a new "goto skip_vfs" so it will skip
> > > the log of "Failed err=".  
> > 
> > Is this really desirable?
> > It is a debug print not enabled by default,
> > and trying to enable SR-IOV did fail.  
> 
> I agree.
> 
> Acked-by: Shai Malin <smalin@marvell.com>

Applied, thanks!