Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp120601pxb; Tue, 14 Sep 2021 20:42:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwl7k+/4cfSc4L3pDyPvdAVZoSkG77FJUua7zgrg5vOtY7aglKmOT7RHs9qBEh1d22zNiHN X-Received: by 2002:a6b:2c14:: with SMTP id s20mr16661256ios.218.1631677321666; Tue, 14 Sep 2021 20:42:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631677321; cv=none; d=google.com; s=arc-20160816; b=KuOunpargv8c/WTc99RzBhuOWOpMhs/zpsE08RhQMMFzBoIqMmlsAcvXhl/n3sLOo6 FhMeNloZZVCj62W8HokGBdg2+nJtxTAFW1abVHM6vnOQStqAVBQRUlkUT8hGckmIWbyu /TiBxtjNgzwsmMyzWX0YZLA6tBA+LnWn99wlt7qzR1KwDhyQBizc/TSbxWkk/ug6MGcU Gvt+u13qLPZXCKUuwrnJhXjObZ8wtNMDOsSQWl3vzhTFrgiku+iXSafTYMYnZ5tXcr2o 3Ld1vExx6Fg9w2pGz7q4Yj27+mq19em5woHjjFZHDXrj9JhgXFOyyjE+jYPV9MLINzVT Pc6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FLdCZwYoQQt71LYycl1xci0UnEwGcCxnzG90Vzhwa80=; b=r+i1xZL7zWpjDJS5w/2Vjc1J0mrkyR0nFxsxCnWH2QX6dtyw9INa3nEp7lqKzzYEo6 zVHWJvY8wf18riepEVK9jCbl8aT2lH1z/JY+e4QkOtG2yYht9KiRHVSvnhFIRH11kCBv 3nXec86R//tkUXTtHSd2pGCTqcmHmTmfd3xfMYdJkX+xE3QrtkPmDkOR8Ui3N9piJlRy Y9GlYon55iazldp6m/7R+w8gcYyqxwfhOkxniOmPzaQkEA8srqnsqSmjYed6X5MvEcX2 ejvgAeqg3uPkH6ffxRnOL1LZamng4xdz6GsTwNBcxLNmssUHVIs3b6oMFflxI7GRwbph Ddsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v189si11061075iof.75.2021.09.14.20.41.50; Tue, 14 Sep 2021 20:42:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233232AbhIODlz (ORCPT + 99 others); Tue, 14 Sep 2021 23:41:55 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:19978 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230076AbhIODlv (ORCPT ); Tue, 14 Sep 2021 23:41:51 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4H8QqY74ryzbmWC; Wed, 15 Sep 2021 11:36:25 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 15 Sep 2021 11:40:31 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 15 Sep 2021 11:40:31 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH] usb: host: ohci-tmio: check return value after calling platform_get_resource() Date: Wed, 15 Sep 2021 11:45:44 +0800 Message-ID: <20210915034544.2398636-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang --- drivers/usb/host/ohci-tmio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c index 08ec2ab0d95a..68e769b82061 100644 --- a/drivers/usb/host/ohci-tmio.c +++ b/drivers/usb/host/ohci-tmio.c @@ -202,6 +202,9 @@ static int ohci_hcd_tmio_drv_probe(struct platform_device *dev) if (!cell) return -EINVAL; + if (!regs || !config || !sram) + return -EINVAL; + if (irq < 0) return irq; -- 2.25.1