Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp211774pxb; Tue, 14 Sep 2021 23:41:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNa9P8iZoxPqXMp/8ASFfba15s3gViv7ecpseMAf0+QkvfudbkrJexeR+yLWkWY2RMIRXW X-Received: by 2002:a6b:8f94:: with SMTP id r142mr17052731iod.183.1631688077782; Tue, 14 Sep 2021 23:41:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631688077; cv=none; d=google.com; s=arc-20160816; b=XpdaWOi4tACCuCVEMFQZm3KnibgNnKenOCVnE0SWS5HrYxsQK72PY7MmhOBqr4sCN+ zhEupzQGm24bkZWHa+hetsbi2Xr7BPZI+L89JT5g5wfWWD+ax/Pp09jY5h5UKWkZwttx Y+RGSoVhTC2D/egc5IUgA/2sf0r/gs3hW73DGBn835gsvGgo6mpRCA7Mkv4R//rM+eJk uyiOevr21VjasCdVp5Y4FtcI9YqL28XNRVjtG4w2XXhV40gG6c4A4ko/NM54MT/1Zu6l txYv0u+hPHlumezMzQWQbamdWztRzjanS4v2fpbCvVnEk7F0Kq/+FSfhLBwuby1eY/B1 zTOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2jrv4qpH+SsfqVOrOyTWjCAMipmK09EdyvQxDfD9z+o=; b=XX23ThyQ7q1JqWAVpvrKhEm9L2f3tzv2thSjdwNK5jA4JPJQgClx/g9gouJ66YHTqd bsVwcRxv1uHquI4uAvxQO6MG3ogqUFR6J88cmjjJmPyWr/j9eHZMT6Lx3VnKdbLDWAoD jiizPk5rWXhzktbYK18X/HaS1KlUMXoUd6HTWrCm6YT+26RftT1Yv9lGAqULUxZ0SeRI J6GTpY9AsZI5/hlQt2wk5so/WpWyCAxYc84DQ305YUQw5daS7jYTwAOoXs5pGHweuZb7 XDbpAZKV+ZM2A1jIa4TMH3xT51582HdNG1bEERKFLSBToig9AexcIm6lRJfNpA7Hgn4i u/zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PVN7GqOI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a21si12057117jao.47.2021.09.14.23.40.45; Tue, 14 Sep 2021 23:41:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PVN7GqOI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236356AbhIOGkJ (ORCPT + 99 others); Wed, 15 Sep 2021 02:40:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40230 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbhIOGkI (ORCPT ); Wed, 15 Sep 2021 02:40:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631687925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2jrv4qpH+SsfqVOrOyTWjCAMipmK09EdyvQxDfD9z+o=; b=PVN7GqOITNaYTWkFZkDSvpJlXbhBshvrYLFwF4fSMHLYuqbUqycvBvfQcoFZ3YHQnL3K5B 1SWKzHnwi3p/eHQ+w5DEBGJPct6qVZHWVizYhzu2iGON6GfPvCYgNhjVM/3Q7bVD2Xw9/7 uFKPGIi6zvDPb4TP0/yA8A0jotSbbwM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-7qemqFm_PtCHmUhwK6aNNQ-1; Wed, 15 Sep 2021 02:38:41 -0400 X-MC-Unique: 7qemqFm_PtCHmUhwK6aNNQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A72684A5E0; Wed, 15 Sep 2021 06:38:40 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A210C5D9D3; Wed, 15 Sep 2021 06:38:36 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 290BE18003BF; Wed, 15 Sep 2021 08:38:35 +0200 (CEST) Date: Wed, 15 Sep 2021 08:38:35 +0200 From: Gerd Hoffmann To: bibo mao Cc: Dave Airlie , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/qxl: Add qxl dma fence release function Message-ID: <20210915063835.36bhpadzbzuj7shw@sirius.home.kraxel.org> References: <20210914062352.6102-1-maobibo@loongson.cn> <20210914062352.6102-2-maobibo@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210914062352.6102-2-maobibo@loongson.cn> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 02:23:52AM -0400, bibo mao wrote: > Add qxl dma fence release function, previously default dma fence > release function is used, and fence pointer is used to free > the memory. With this patch, actual qxl release pointer is used > to free memory, so that dma fence can put at any place of > struct qxl_release. Why? Is there a problem with struct dma_fence being the first element of struct qxl_release? take care, Gerd