Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   DENG Qingfang <dqfext@gmail.com>
To:     Ansuel Smith <ansuelsmth@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Rosen Penev <rosenp@gmail.com>
Subject: Re: [PATCH net-next v2] net: phy: at803x: add support for qca 8327 internal phy
Date:   Wed, 15 Sep 2021 15:27:33 +0800
Message-Id: <20210915072733.1494-1-dqfext@gmail.com>
In-Reply-To: <20210914123345.6321-1-ansuelsmth@gmail.com>
References: <20210914123345.6321-1-ansuelsmth@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, Sep 14, 2021 at 02:33:45PM +0200, Ansuel Smith wrote:
> +}, {
> +	/* QCA8327 */
> +	.phy_id = QCA8327_PHY_ID,
> +	.phy_id_mask = QCA8K_PHY_ID_MASK,
> +	.name = "QCA PHY 8327",
> +	/* PHY_GBIT_FEATURES */
> +	.probe = at803x_probe,
> +	.flags = PHY_IS_INTERNAL,
> +	.config_init = qca83xx_config_init,
> +	.soft_reset = genphy_soft_reset,

How about setting .suspend and .resume? Without these, the PHY cannot be
powered down/up administratively (via ip link set xxx down/up).
See commit 93100d6817b0.

Off-topic: When is .soft_reset called? The MediaTek PHY driver seems to work
fine without it.

> +	.get_sset_count = at803x_get_sset_count,
> +	.get_strings = at803x_get_strings,
> +	.get_stats = at803x_get_stats,
>  }, };