Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp253343pxb; Wed, 15 Sep 2021 00:56:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyXjH0xX3r8iervzXsLyVCe31m2IA3ulnXh9/A37hpcZHkfYUDC+DTi61Zj7oCDZyn/bFq+ X-Received: by 2002:a05:6638:4122:: with SMTP id ay34mr18675588jab.131.1631692591168; Wed, 15 Sep 2021 00:56:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631692591; cv=none; d=google.com; s=arc-20160816; b=uNWcO+F4XSQgIzeISMXMJLm3cDoLcVkb4qjLsmbF2B5NeiyRzHUlSuya4EnB8w0Eep hETKG0CDEcD//JSj3DjqApAF9JPYu8VTIKSLuHk2jKsmrGUP9BHPI9rr9maP+UWh4d4W B2XjfiW6Nkocb4iGSH736TQ67Ez3N3Q0geO47ILaL3qtd41wUTdiMv7CliywFIjStQJy QTWVL1YF06kA+Gxg/Pof+pklMsyxDTBLMr+JPH50ocAzSTxlTfsL5yy6v7bl0VDt46DM HCG3XX7q+6ULjAuAPsvRnvA0ysFXzfyKYP1JZnfejIoDrdA7e7HuzxoTlJfuWvfhOLhT 9DhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=tIta2I9XsXZcxTWSHaAC7NHANPAr0ZPeLNepZ3aW9Lg=; b=eplvWPPiMFKj9Z2+qOBoVs+8LhMISCa3Lbe65gbzgsqNDlG/SFgBOd/aevoLw6XoSf Y6qWvBr8qqyk5wxfL9O4ckUvHzBIIbRrGfGx+Tp7W14VHyjcbiP+2lAz78sy2v/sY1/4 wJfOM+Gxrw2foX2zhH0JDA3q5bfKsV35qMsL/LDEadimJ5T84n5dSwfUHE+/VEuo8k1p c4yQ9V1eM7GQMTmoMLpSBFVghEffDfocKABBfx/c35pEDcbvEHkLmbIfdQ66uqpy5V5d pBA+63GN+aDB3VuaLJ99ukOUd+eKmmk/xaP0TJH0aJU99FoK7zO0RzJPVFe7KWtOLiQc Ln1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=rI1PEFSs; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h15si14160079ili.51.2021.09.15.00.56.20; Wed, 15 Sep 2021 00:56:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=rI1PEFSs; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236721AbhIOH4V (ORCPT + 99 others); Wed, 15 Sep 2021 03:56:21 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:60070 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231635AbhIOH4T (ORCPT ); Wed, 15 Sep 2021 03:56:19 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 24EE32214A; Wed, 15 Sep 2021 07:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1631692500; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tIta2I9XsXZcxTWSHaAC7NHANPAr0ZPeLNepZ3aW9Lg=; b=rI1PEFSs/PUrf2oumXj3vZDGm+ltc0tNMU4uzKp3U/GU2iOf1TC7Y72CmwBYvk9YgMh00d Eq3ajMXzv386ClWpr9o4aYX042chvIMiXmc+PCOyi5gxsgb1SA6bzVHep5h5HuoIF6wtci 1YozgA75XPtvBL1ONbdChK3cLfOIlWc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1631692500; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tIta2I9XsXZcxTWSHaAC7NHANPAr0ZPeLNepZ3aW9Lg=; b=xJmi+WxpS10EZ66ojlThwqq8+WfAE+5Yv0MpbU9X2jy2o58GrnEq/b9+vuq+IFk1nxOUEQ fa2v4Eeh0uGIHmDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9B93213C21; Wed, 15 Sep 2021 07:54:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iLLwGNOmQWFwJAAAMHmgww (envelope-from ); Wed, 15 Sep 2021 07:54:59 +0000 Date: Wed, 15 Sep 2021 09:54:57 +0200 From: Daniel Wagner To: Sagi Grimberg Cc: Christoph Hellwig , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC v1] nvme-tcp: enable linger socket option on shutdown Message-ID: <20210915075457.sdj3oq3bhn7itqop@carbon.lan> References: <20210903121757.140357-1-dwagner@suse.de> <20210914084613.75qykjxweh66mdpx@carbon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 05:20:46PM +0300, Sagi Grimberg wrote: > > During testing the nvme-tcp subsystem by one of our partners we observed > > this. Maybe this is perfectly fine. Just as I said it looks a bit weird > > that a proper shutdown of the connection a RST is send out right after > > the FIN. > > The point here is that when we close the connection we may have inflight > requests that we already failed to upper layers and we don't want them > to get through as we proceed to error handling. This is why we want the > socket to go away asap. Thanks for the explanation. The RST is on purpose, got it.