Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Sep 2021 10:05:37 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Jiri Slaby <jslaby@suse.cz>
Cc:     gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Andreas Koensgen <ajk@comnets.uni-bremen.de>,
        Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 05/16] tty: remove file from tty_mode_ioctl
Message-ID: <20210915080537.mcndyf6oot4v6hew@pengutronix.de>
References: <20210914091134.17426-1-jslaby@suse.cz>
 <20210914091134.17426-5-jslaby@suse.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2wqqhlezubhyee7b"
Content-Disposition: inline
In-Reply-To: <20210914091134.17426-5-jslaby@suse.cz>
Precedence: bulk


--2wqqhlezubhyee7b
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On 14.09.2021 11:11:23, Jiri Slaby wrote:
> The only user of 'file' parameter in tty_mode_ioctl is a BUG_ON check.
> Provided it never crashed for anyone, it's an overkill to pass the
> parameter to tty_mode_ioctl only for this check.
>
> If we wanted to check 'file' there, we should handle it in more graceful
> way anyway. Not by a BUG == crash.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Andreas Koensgen <ajk@comnets.uni-bremen.de>
> Cc: Paul Mackerras <paulus@samba.org>
> ---
>  drivers/net/can/slcan.c       | 2 +-

For the slcan.c:
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

regards,
Marc

--
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--2wqqhlezubhyee7b
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmFBqU8ACgkQqclaivrt
76muZgf+MUl8Y9j/6pTFNjbSF5vBrZhE1PXzkvVTwWonq9eouUYLtNgMEIqh0IC7
NWPnQOZf916t2rb6OuQEQlgp/AV1MFmfeLoSK1LfLKDj+075eSu7CIn2MGeeoC/7
wllxFuOXkiJpMe0EXhzHsPj+yBXO3P0ZsZyfEsJ3eBMLu4kc7hu6LzbYCtVj50VS
biN+g7QUOgGBi5TI4+rA/LeRF4uzvAufuukV9vGEKLX5Y7dbyy2p/mtnNiCdNnZt
E/BZIuBTVTd5Unzk8K51oM9DFVSnbC3Q+wQhlKB21epWE03gUH/G4asomwbegWVq
3k9JL+FQW1trObJ2HblArdqZ7ZLcyw==
=kmTG
-----END PGP SIGNATURE-----

--2wqqhlezubhyee7b--