Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Sep 2021 10:05:05 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Jiri Slaby <jslaby@suse.cz>
Cc:     gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paul Mackerras <paulus@samba.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Peter Ujfalusi <peter.ujfalusi@gmail.com>
Subject: Re: [PATCH 04/16] tty: make tty_ldisc_ops::hangup return void
Message-ID: <20210915080505.rq2gj4e3ltfzinbm@pengutronix.de>
References: <20210914091134.17426-1-jslaby@suse.cz>
 <20210914091134.17426-4-jslaby@suse.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="iopoaeuqhybpk76v"
Content-Disposition: inline
In-Reply-To: <20210914091134.17426-4-jslaby@suse.cz>
Precedence: bulk


--iopoaeuqhybpk76v
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 14.09.2021 11:11:22, Jiri Slaby wrote:
> The documentation says that the return value of tty_ldisc_ops::hangup
> hook is ignored. And it really is, so there is no point for its return
> type to be int. Switch it to void and all the hooks too.
>=20
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> ---
>  Documentation/driver-api/serial/tty.rst | 2 +-
>  drivers/input/serio/serport.c           | 3 +--
>  drivers/net/can/slcan.c                 | 3 +--

For the slcan.c:
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--iopoaeuqhybpk76v
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmFBqS4ACgkQqclaivrt
76khdgf/X14fNFG2Wsnq+ToDU18WpqftWFAPePHwvLjLnzpK8zeLdyW8zCQWTWPH
q+B9F6gKwLMUefIXBFwlqTANCa/YNUdfA0EgTBU4M2m5J4VTMNso+ysHCdj07b3T
4v3dMBevFhWlyRgmUczwGMjCG1TGghaIvhOqv2VQiJBrD51sXIoGcAIToMiUCZaX
xx1Uxh5UBQb59OtRTmJPiMieQToImQrUUYDRMUMJP4ObGWUOS1Bjo5xlMxLl8yot
CC1nGYy5R2BwKSJ56LFHuYQn8HWRYBjV09oxqB5k9MF3B4g6xYSJjItQ5N76zeXy
5s5+s9JQpy/y3/C+14KLSoEV2Mg6jA==
=ADnc
-----END PGP SIGNATURE-----

--iopoaeuqhybpk76v--