Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC 01/19] dt-bindings: interconnect: imx8mq: Add missing pl301
 and SAI ids
To:     Abel Vesa <abel.vesa@nxp.com>, Rob Herring <robh@kernel.org>,
        Dong Aisheng <aisheng.dong@nxp.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc:     Pengutronix Kernel Team <kernel@pengutronix.de>,
        linux-serial@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <1631554694-9599-1-git-send-email-abel.vesa@nxp.com>
 <1631554694-9599-2-git-send-email-abel.vesa@nxp.com>
From:   Georgi Djakov <djakov@kernel.org>
Message-ID: <096f0e8a-2215-6506-330f-a9cbfc8ddfe6@kernel.org>
Date:   Wed, 15 Sep 2021 11:09:40 +0300
MIME-Version: 1.0
In-Reply-To: <1631554694-9599-2-git-send-email-abel.vesa@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Abel,

On 13.09.21 20:37, Abel Vesa wrote:
> According to the bus diagram, there are two more pl301s that need to
> be added here. The pl301_per_m which is an intermediary node between
> pl301_main and its masters: usdhc1, usdhc2 and sdma. The pl301_wakeup
> is an intermediary node between pl301_main and its masters, in this case
> all the SAIs.

Thanks for working on this!

> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
>   include/dt-bindings/interconnect/imx8mq.h | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/include/dt-bindings/interconnect/imx8mq.h b/include/dt-bindings/interconnect/imx8mq.h
> index 1a4cae7f8be2..1953de8af5cb 100644
> --- a/include/dt-bindings/interconnect/imx8mq.h
> +++ b/include/dt-bindings/interconnect/imx8mq.h
> @@ -44,5 +44,14 @@
>   #define IMX8MQ_ICM_PCIE1	26
>   #define IMX8MQ_ICM_PCIE2	27
>   #define IMX8MQ_ICN_MAIN		28
> +#define IMX8MQ_ICN_PER_M	30

Is there any reason to jump from 28 to 30?

Thanks,
Georgi

> +
> +#define IMX8MQ_ICN_WAKEUP	31
> +#define IMX8MQ_ICM_SAI1		32
> +#define IMX8MQ_ICM_SAI2		33
> +#define IMX8MQ_ICM_SAI3		34
> +#define IMX8MQ_ICM_SAI4		35
> +#define IMX8MQ_ICM_SAI5		36
> +#define IMX8MQ_ICM_SAI6		37
>   
>   #endif /* __DT_BINDINGS_INTERCONNECT_IMX8MQ_H */
>