Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <02637d38dcf4e4b836c5b3a65055fe92bf812b3b.1631687872.git.wuzongyong@linux.alibaba.com>
In-Reply-To: <02637d38dcf4e4b836c5b3a65055fe92bf812b3b.1631687872.git.wuzongyong@linux.alibaba.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Wed, 15 Sep 2021 16:34:34 +0800
Message-ID: <CACGkMEvnG40752Ksw7AMQrg9NpkYz_0Hmw8nKEskLNNOuKNTGw@mail.gmail.com>
Subject: Re: [PATCH] vhost_vdpa: unset vq irq before freeing irq
To:     Wu Zongyong <wuzongyong@linux.alibaba.com>
Cc:     virtualization <virtualization@lists.linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        mst <mst@redhat.com>, tiwei.bie@intel.com,
        wei.yang1@linux.alibaba.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Sep 15, 2021 at 2:39 PM Wu Zongyong
<wuzongyong@linux.alibaba.com> wrote:
>
> Currently we unset vq irq after freeing irq and that will result in
> error messages:

Nit: I think for 'we', it actually means the parent driver can free
the irq during reset, set_status(0). vp_vdpa is one example for this.

>
>   pi_update_irte: failed to update PI IRTE
>   irq bypass consumer (token 000000005a07a12b) unregistration fails: -22
>
> This patch solves this.
>
> Signed-off-by: Wu Zongyong <wuzongyong@linux.alibaba.com>

Other than this.

Acked-by: Jason Wang <jasowang@redhat.com>

> ---
>  drivers/vhost/vdpa.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index f41d081777f5..15bae2290bf9 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -173,6 +173,10 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp)
>         if (status != 0 && (ops->get_status(vdpa) & ~status) != 0)
>                 return -EINVAL;
>
> +       if ((status_old & VIRTIO_CONFIG_S_DRIVER_OK) && !(status & VIRTIO_CONFIG_S_DRIVER_OK))
> +               for (i = 0; i < nvqs; i++)
> +                       vhost_vdpa_unsetup_vq_irq(v, i);
> +
>         if (status == 0) {
>                 ret = ops->reset(vdpa);
>                 if (ret)
> @@ -184,10 +188,6 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp)
>                 for (i = 0; i < nvqs; i++)
>                         vhost_vdpa_setup_vq_irq(v, i);
>
> -       if ((status_old & VIRTIO_CONFIG_S_DRIVER_OK) && !(status & VIRTIO_CONFIG_S_DRIVER_OK))
> -               for (i = 0; i < nvqs; i++)
> -                       vhost_vdpa_unsetup_vq_irq(v, i);
> -
>         return 0;
>  }
>
> --
> 2.31.1
>