Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp353437pxb; Wed, 15 Sep 2021 03:44:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy02QHosQJo1hyub0cpvcE1Oq8R482vimLyN2+LmcKPuDdNdhLTrhBfkKiubNOyIP0V0NjG X-Received: by 2002:a05:6512:3e2a:: with SMTP id i42mr17427088lfv.45.1631702694334; Wed, 15 Sep 2021 03:44:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631702694; cv=none; d=google.com; s=arc-20160816; b=IunQWmHYYYMUodUK/h7Zvf4GCEhVC8aGAmuggdFtq5A4BemXC+jisBaLQsJGMiW9rK hl2jQapkmn/A7gR9v34mt7w3b9KRXVwwF/nT/0GZbSAZVya6rg4rXkvskSfxticESL1E FkUaKAkeyMDEcktHuRrCjFwrpwqnluhAFkF65EObP//owhGGqrnXchmsB2ScttjtLLd/ 9GpO8p9cjLdlRsQOikYOUmxf1b6L3Ka3/j36wRLpPgUuz7pBqUlV34s7gcWfOZTLNi4r 0af42ZCnpNFGGqvJUk4/I52kgaaTDb38yduchNP1xg40HnKBoncCJbUOcmxskDjM+qDo AmkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=a/GCtVpvhwVIk1SywYX5YYFVF3L25bb3Bu0j55SRB24=; b=T7SlzvBaM93pDH78qvGOG4iaUbaymhGgHOtfbw7CfvPN4JLRJgF1m6NuCmVWTGaMOQ A/Sv6Cas5FLta3Ztea/OkeLC3SUK9STvteGYhAIpvp/9x9t84dw7hA5ER9Afehd7xzsh RJ36HNKk8KHxOp4kgsS9W6v+Ahwwxi+kKgkl/hBKYXYfpDmPm0YnUzBlkL4Z/2S9RKAl XqQlfowaBF3yhCXMvZ/0lFtRN9oVOxCRXeKxlN5riPTc+j0gXkA+dq1RnJKWZZTkAs3a 8J/X0/dhEdx1Lg+yJxNgnsq+yfN1X4n6AqDo1I1XeSTjc8cLBh+zBWMk3R0dlpWHYetr o8iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=F4X13sv8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o10si16237685ljp.65.2021.09.15.03.44.25; Wed, 15 Sep 2021 03:44:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=F4X13sv8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232286AbhIOKlr (ORCPT + 99 others); Wed, 15 Sep 2021 06:41:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232054AbhIOKlq (ORCPT ); Wed, 15 Sep 2021 06:41:46 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE63EC061574 for ; Wed, 15 Sep 2021 03:40:27 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id a4so5092902lfg.8 for ; Wed, 15 Sep 2021 03:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=a/GCtVpvhwVIk1SywYX5YYFVF3L25bb3Bu0j55SRB24=; b=F4X13sv85qlRDDGNT934A1gwgVq152F28CjwxEmHWp5QoNhFlLfGtaqRmrbtgwFI4g RcQmXbvtmgFuhw3kwUj511XOgpddIwKvyro1pjK6LdK1Wvt1CQqiwtE95uaewMmG4gjT CtYQUT7gTVilccItlvMr+/R4kkVzMMX62w7b13NNca2Wm5wx83Md4QNlU1CUXkPdI8Ha GUmk1lbIcUs/H6JEkz7Z5B1XrmqfJlMcxF8D+LqP0aTsafCY2WOmKZNXJ6/PpeJoRiQw kxc/mSdxkYFkx652FozpJZgkSFN2SqCP5zKQip4upN84qh6+u667sOBV8IIpRCvvUkfD DrKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a/GCtVpvhwVIk1SywYX5YYFVF3L25bb3Bu0j55SRB24=; b=EKx9Kmy/Y6wD/mpVp4RV17xR8GMmV4GJFvbAOBGJthrBBcCk6UYWpGQ9FXJ+26gs/M yykEhU5wKiVWJvrwcYZL0ahT2MmbH/GYjdapAd9506Eq3MFTI45hd73dcmyIAUxsptSA NUTTSSfguIJcn239Co3Mox9GqUXtixFRIcvl77TkbYAtysJkYg2ZYAFDARoa8kbnigPv i7DUHqlQ5diedM8uWT/D87cOJn4Mw8Gcq9pF4sH2W8tC9pEawNg1vqpyMo2/XierR3Ir jX/WWM8rwEE9f6Qwi/lD8ntmeG0KyE/L4hALbUR5Gzi0/fBclJ2HpLoHE8+gBuYDb9oG dCew== X-Gm-Message-State: AOAM531g7wqrLwAVnnW2RfbHHHwCHKEeDrDgKgBHgh/yUcOs0GEogsM7 Ub7e0clJq56etUDKloWpIkHrhg== X-Received: by 2002:ac2:5d71:: with SMTP id h17mr16352495lft.670.1631702426202; Wed, 15 Sep 2021 03:40:26 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id q7sm1673012ljg.137.2021.09.15.03.40.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 03:40:25 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id C2AFB102F4D; Wed, 15 Sep 2021 13:40:28 +0300 (+03) Date: Wed, 15 Sep 2021 13:40:28 +0300 From: "Kirill A. Shutemov" To: Amit Daniel Kachhap Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vincenzo Frascino , Andrew Morton Subject: Re: [PATCH] mm/memory: Avoid unnecessary kernel/user pointer conversion Message-ID: <20210915104028.77qwldwnwpcbjds6@box.shutemov.name> References: <20210914150820.19326-1-amit.kachhap@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210914150820.19326-1-amit.kachhap@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 08:38:20PM +0530, Amit Daniel Kachhap wrote: > Annotating a pointer from __user to kernel and then back again might > confuse sparse. In copy_huge_page_from_user() it can be avoided by > removing the intermediate variable since it is never used. > > Cc: Andrew Morton > Signed-off-by: Amit Daniel Kachhap Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov