Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp399262pxb; Wed, 15 Sep 2021 04:50:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzciPAW8iYu6G+EwPBVI9IFfJJ5rxhRFl5AUHG83kuG5K7XpPB96e7s/mMtzIDKsmL6dff X-Received: by 2002:a02:3b58:: with SMTP id i24mr18664370jaf.144.1631706615938; Wed, 15 Sep 2021 04:50:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631706615; cv=none; d=google.com; s=arc-20160816; b=CsDpXsOKbx8Nq9j9W5XoI7r2kgMKKoxQo7TIeDyKL6t/CJ2qs1AeHYBx+fnjUIDY3A gXCGdncxk+mauueYesOlLvfFog4Y1rYuXzlS4FcHuh0Mh143FSQduNlRbPLaN1jHqPTI nsMHppR3Z0JucLaJgjdDHEwyfU/qC5ooh9V1Aq8fpxQFn957K+MOqoiiJVlCTvdJNra9 UMzYvhzlQ78+hdwoYUbflQEjtg53iQEAsbDMq+LTtyNbnRqsPfEOBGWHtAcTf52UJ6j9 7iq5woqcVLPkzAo1Q+0jr+0RgGAwkx1H2zw0rjamSKYMGKu6Rfv5/i3pIdy9bAb+xYSB bO5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ULt7y7tlP2cZHmwB9aO/zjfoepDHbhQXuJJhhHwwVfo=; b=hrBa+awz0JYjtg4SYmtmT53GcvS5rfAcX1QGCfMjagLrVPB7sU9jReY4E9CBKh8lCZ EL3dHcVgZrvg4yrERjia66sEV0/AgshY/IrltJ/lUSGRW1R3HjHWPxryS/acO43/hJUz XdGo0bBp43pM9uwQFMcvJcwXNHbrxQRGK9rBdvHLIGqYJDSbeJvKgFQwaC/FpHvrp0UI Vz1u00EwZybmO3corQaBJB0HWzJabNXp5ofyQRUNicjhCYcZ6u+D0rXdAR82Dcj7stkE XojXOcEZneXb3acsHS3b41y9aGO3KNr2GRWOFGjU6aTzK0vY/8wDSiqyOeUUPMzfJoIW 2a1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BrbbakUZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d27si12671114jaa.121.2021.09.15.04.50.04; Wed, 15 Sep 2021 04:50:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BrbbakUZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232774AbhIOLuP (ORCPT + 99 others); Wed, 15 Sep 2021 07:50:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:33400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232586AbhIOLuO (ORCPT ); Wed, 15 Sep 2021 07:50:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AA04761246; Wed, 15 Sep 2021 11:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631706536; bh=ULt7y7tlP2cZHmwB9aO/zjfoepDHbhQXuJJhhHwwVfo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BrbbakUZO/UiFPHZPDIrXQMt6Hd3ECtoD0+UmLKzNepXxi/s0Tgh0CFCILmJ3uQFc nv4KnwoKbtAogsmbjUJlgwVO2vViafyjsJ4Hq1iIAHkWQS9dGjtBCRvF7Ib+YXkRHd ENgzdWuw65sq8nw3xLOc51Ovn9mk1bBUapSarCfR1bkg0hoQIgw3D0XYFEaqFCidLP kvMxbQSPnjphSmrGX0XAO8KfWGaOK6Gr44X46CBt5TZFhZA646QvdB4K+QYJWZhqFk 5uu8jvE1VXaXQHp+yKif0Pr6mcUW7UosGas93Cskl6IokuYRffJpc4+EHDkr2efYuC rT1CwPxnFTtug== Date: Wed, 15 Sep 2021 12:48:15 +0100 From: Mark Brown To: Jiri Slaby Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Paul Mackerras , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Peter Ujfalusi Subject: Re: [PATCH 04/16] tty: make tty_ldisc_ops::hangup return void Message-ID: <20210915114815.GC5389@sirena.org.uk> References: <20210914091134.17426-1-jslaby@suse.cz> <20210914091134.17426-4-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/Uq4LBwYP4y1W6pO" Content-Disposition: inline In-Reply-To: <20210914091134.17426-4-jslaby@suse.cz> X-Cookie: Absence makes the heart grow frantic. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --/Uq4LBwYP4y1W6pO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 14, 2021 at 11:11:22AM +0200, Jiri Slaby wrote: > The documentation says that the return value of tty_ldisc_ops::hangup > hook is ignored. And it really is, so there is no point for its return > type to be int. Switch it to void and all the hooks too. Acked-by: Mark Brown --/Uq4LBwYP4y1W6pO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFB3X4ACgkQJNaLcl1U h9DDoQf/QaVYNcPoOnOAsOBcNtUmh0pOeb5CqVH3nYyw3lZ81HrC6mbb2BNeBptU bXkoe19bi4VOCVDTblT77YP3A9+oMI4VqPeYQ9Q5oePhKlS9mK4B2IC5P1ZIxXFe y7xtmFtyVfA/3TGFJXHGS39xliSQlSkaWYGfDrjarR+Vsci2+TIlEaD2c0IaHFqy 8xnWfnvhTDDdlnM/NIYqAwJ9kJk8CrsODwiW4JZMUhCreELTSDpRihSEn8jblyrG xlEJVf0wpBpl+E/K4U3KDbI1XCgyoN5pYouXnPc0ThXDNcCDDqpPZeKNlFtnPhkN R9Nocu9JUmTaLRjg+lFALleZCYgcbQ== =/6qu -----END PGP SIGNATURE----- --/Uq4LBwYP4y1W6pO--