Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp412827pxb; Wed, 15 Sep 2021 05:07:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGtNk6NoZEHqLxqvyQFrhe5e/hLygyXqMha9Nqts7e+tOPXeFmaUtLminySPJ0DW9LbP/3 X-Received: by 2002:a2e:9256:: with SMTP id v22mr20264140ljg.150.1631707675537; Wed, 15 Sep 2021 05:07:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631707675; cv=none; d=google.com; s=arc-20160816; b=1FkXvcFXnpyn2up3EtosaiHG70A7ZumASVvuZlQ3iALHJOQwYU62rNtf8JpI+6jwNe udPtrZDW4tWE3RuSl0Gq6DYvY3igokLbi5tl96KXouQeszsX5MblMbrQrXMWR9GneAB5 Fy0YCxL5zGue5oYtDuo764xYpJp4D+78B1kwk61NG780Ul/hIzSQBHypfkqsTbIzmIQc S3kc2nTXruD0ZMDShF10GPKnhLbxsHBEeHPdsOnNaAcLT6PRA4dFfaLu3dIcJQGM0tvC hPAcekJBtqM0nb9ZuG2Ji1cfc0J2qmRuQ1P9HHw7apPceoH0jN8inxGeHxgYJJJcHIPm xPMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kT+jpdgHUgB8WmXpX4IK0Fq/UD51pryiZLI1p3AwL4s=; b=urXfPZGsNlvUtuPjPTVKN6KBsYO5bNazZRNCO5CS0zruuXsFE8rMnc/GAUHK6s737R AapJ8MxZ/yMOa7ppAoe8CxlJ80bhOh5uDVlzXro+CiEcGglAYyz4ysPMTaB2a8toJTse XVn/BcdcQda8LZFDwTUHddB4QwC1gtou29uxEQFat1NlRev6mu84VjkSrXo93vyH/Xvr F3lET2G5/Ga4ymoaCVZ4iuSF53C2IYU1ZzZfhJ4yuf9mki/vYtRGIlBcuojj8a0Snzjx iyS46WRkOFm6FZSv/VhkC9yYQ6O1inMZNX4eyVle7Jyv4Sz62puBD73SPCy3CZDWiZ9E Yqwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="pq/klfE0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c20si14722357ljj.131.2021.09.15.05.07.27; Wed, 15 Sep 2021 05:07:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="pq/klfE0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237734AbhIOMEh (ORCPT + 99 others); Wed, 15 Sep 2021 08:04:37 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:55202 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237772AbhIOMEd (ORCPT ); Wed, 15 Sep 2021 08:04:33 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 18FC3AlY085483; Wed, 15 Sep 2021 07:03:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1631707390; bh=kT+jpdgHUgB8WmXpX4IK0Fq/UD51pryiZLI1p3AwL4s=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=pq/klfE0Nviq3z3e3+xMhqSQ+Gdx0kdUI/1WICeXTkUTGPUC8BTpEC1CjuSkTqYLz nzZuyVLcfsGLnOKJ9PgpOyzBFB9ob7f06GhFKOK7ra4JtLk/k66GRMgykyFSNGDkGt JUPuE/jDmA24jpXWNzJXuvr19+P+npWox8Qyjeso= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 18FC3AhA048962 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 15 Sep 2021 07:03:10 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 15 Sep 2021 07:03:10 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Wed, 15 Sep 2021 07:03:10 -0500 Received: from pratyush-OptiPlex-790.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 18FC2fD7019246; Wed, 15 Sep 2021 07:03:06 -0500 From: Pratyush Yadav To: Mauro Carvalho Chehab CC: Pratyush Yadav , Laurent Pinchart , Nikhil Devshatwar , Tomi Valkeinen , Vignesh Raghavendra , Benoit Parrot , Maxime Ripard , Rob Herring , Sakari Ailus , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , , , Subject: [PATCH v4 06/11] media: cadence: csi2rx: Populate subdev devnode Date: Wed, 15 Sep 2021 17:32:35 +0530 Message-ID: <20210915120240.21572-7-p.yadav@ti.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210915120240.21572-1-p.yadav@ti.com> References: <20210915120240.21572-1-p.yadav@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The devnode can be used by media-ctl and other userspace tools to perform configurations on the subdev. Without it, media-ctl returns ENOENT when setting format on the sensor subdev. Signed-off-by: Pratyush Yadav --- (no changes since v2) Changes in v2: - New in v2. drivers/media/platform/cadence/cdns-csi2rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c index edd56c5f2e89..7c3183069db0 100644 --- a/drivers/media/platform/cadence/cdns-csi2rx.c +++ b/drivers/media/platform/cadence/cdns-csi2rx.c @@ -602,6 +602,7 @@ static int csi2rx_probe(struct platform_device *pdev) csi2rx->pads[CSI2RX_PAD_SINK].flags = MEDIA_PAD_FL_SINK; for (i = CSI2RX_PAD_SOURCE_STREAM0; i < CSI2RX_PAD_MAX; i++) csi2rx->pads[i].flags = MEDIA_PAD_FL_SOURCE; + csi2rx->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; ret = media_entity_pads_init(&csi2rx->subdev.entity, CSI2RX_PAD_MAX, csi2rx->pads); -- 2.33.0