Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp473148pxb; Wed, 15 Sep 2021 06:23:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxa6QpEAC/OET7hfjMg0VhVcRcljYVoBLEAYHlVRz4PHnxkjDvRtES/u0OT3qvuRdtQr6cv X-Received: by 2002:a92:3012:: with SMTP id x18mr16560716ile.249.1631712198219; Wed, 15 Sep 2021 06:23:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631712198; cv=none; d=google.com; s=arc-20160816; b=IY0bR/kfxX5mePXC4eHXnNUxyxoTcdLO7CpwAHoi8FQwRHHjZg5817onskDlyDgdol mb0mnSeY9JytmVIls1SEIzEp7RNiQkaohICK50z7Gw2RrI4FfN/CYpr16lwQ62GOlAih 6mE33bCtw1buAR6n30P4Jd3WgkisfvCePPffZyF+sCVlEW/vhY307Mh2n7jYc4G3Pq7t SS2weuf0R6w3sVydMr/g2lkAC7aC/Gko8Cdjr99gqpN4wb65OlXB7BpHLOWt7q3Wbh0Y h2ZZcRmNpyjQMZ/j+vw3zd0leA6DNRCdK959CZvAbpQIYXQf0AjnEfyq+rk7dcgtR8aY /lbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=SeynnRPlPwaNcLGVtVg/JkTYoGGgEmGcdMAap718d0A=; b=px8hDeqGwlj6kOmMscifXW62hQiDeCjdrk/f5BIYR0UKbdb/If/0whmYi2jB0lynHT jteBLEklnOGfUYSCnNDLfN0t+5Ngf/Xqi/kfbeVKx2NlOYIoITb0FBnX7Hp9qXlTSHu7 DHWOfon76ek//oP75OBj3ftxUUU3I1voOvOjuieICIiovN9lGSlpoefhC/ZQp7c2za+Z udsfBt0TDDKDEabOPO02zY4JXFU2GTp8oJIqy806RGwYFrYhYpGMxuthaIgjxzQH3G7C 8lT9TQzI7rmwvl7haFozHY1HsQrcC5Emx6ytoqGAa2JTzw/CBqM3QvriclRLkqxMzTIq 0WlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si13356729jao.55.2021.09.15.06.23.06; Wed, 15 Sep 2021 06:23:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236741AbhIONVp (ORCPT + 99 others); Wed, 15 Sep 2021 09:21:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234657AbhIONVl (ORCPT ); Wed, 15 Sep 2021 09:21:41 -0400 Received: from albert.telenet-ops.be (albert.telenet-ops.be [IPv6:2a02:1800:110:4::f00:1a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF7E5C0613DF for ; Wed, 15 Sep 2021 06:20:22 -0700 (PDT) Received: from ramsan.of.borg ([84.195.186.194]) by albert.telenet-ops.be with bizsmtp id uDLH2500s4C55Sk06DLHoU; Wed, 15 Sep 2021 15:20:20 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mQUnf-004eT9-TO; Wed, 15 Sep 2021 15:18:07 +0200 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from ) id 1mQUT7-002gSI-H7; Wed, 15 Sep 2021 14:56:53 +0200 From: Geert Uytterhoeven To: Greg Kroah-Hartman , Jiri Slaby , Johan Hovold , Shawn Guo , Li Yang , Scott Wood Cc: linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] serial: 8250: SERIAL_8250_FSL should not default to y when compile-testing Date: Wed, 15 Sep 2021 14:56:52 +0200 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") added compile-test support to the Freescale 16550 driver. However, as SERIAL_8250_FSL is an invisible symbol, merely enabling COMPILE_TEST now enables this driver. Fix this by making SERIAL_8250_FSL visible. Tighten the dependencies to prevent asking the user about this driver when configuring a kernel without appropriate Freescale SoC or ACPI support. Fixes: b1442c55ce8977aa ("serial: 8250: extend compile-test coverage") Signed-off-by: Geert Uytterhoeven --- Yes, it's ugly, but I see no better solution. Do you? drivers/tty/serial/8250/Kconfig | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index 808268edd2e82a45..a2978b31144e94f2 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -361,9 +361,13 @@ config SERIAL_8250_BCM2835AUX If unsure, say N. config SERIAL_8250_FSL - bool + bool "Freescale 16550-style UART support (8250 based driver)" depends on SERIAL_8250_CONSOLE - default PPC || ARM || ARM64 || COMPILE_TEST + depends on FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || (ARM64 && ACPI) || COMPILE_TEST + default FSL_SOC || ARCH_LAYERSCAPE || SOC_LS1021A || (ARM64 && ACPI) + help + Selecting this option will add support for the 16550-style serial + port hardware found on Freescale SoCs. config SERIAL_8250_DW tristate "Support for Synopsys DesignWare 8250 quirks" -- 2.25.1