Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp495797pxb; Wed, 15 Sep 2021 06:53:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEu5/ICAg8RQOeY8Tgo/FFc4JPmhrow0fS2grcXIe0DQftjMH9VqRBE7FF4AdqWTIhPOh4 X-Received: by 2002:a02:662b:: with SMTP id k43mr89186jac.1.1631713983086; Wed, 15 Sep 2021 06:53:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631713983; cv=none; d=google.com; s=arc-20160816; b=TsTZITqEUMe80+OkBkD/f3qV0SkX7temQifDCfY8/MD1euaQZ8obOkQZJl1KynwQHs R3+yW2C27nDfN/G+pQB/1FDvOaw/Jq4RJtE2o0xUWs8LqJdX+QEFHSSpXFSAfeB4MsGW Mpe5UyGR/Wa2PUyskrP90L+ewNYRrpgb7BbO5ZBpQQa1zLcnepdcWVfgneK+roIU3Qpj dfAcx6OxH60iFQJCnro8AxZcJ7ZJbRgdRjLZlsrzcYGDjzeHYmxammvDsiJGWHBOYBaR 3zJIkZ1UMN4+QuChUwohrqU5/E/gClzWftgyn6Qe/qLUINzqfmxGMnIU0CdshKl3LMIe oCtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=5AsrvS/QlJP2sVcBnOnTMG4R24cPJ6CmHAP1sRYdcGI=; b=osdDM+CkjxB0bA81ZyIQd6QNurcwx1Ma7E/UR0AMm808d6GXzBKaKg9PhhiKnb7PU2 RIkxTr63E+drhS/a+Q2PrQ4p8gTjiJ/UmB0hUpw4U/NDPJlQkcsdDPKpdtj1eUUe01uY fgyL/inpUzsNXHIO5n2isavjje2TMmV3Y6BYHYesbIQ6ahXuJr7Pn5K+g5tOhol3qZml DBwyhSRdLAl2TY0kvKJiV8DUaFKrLrZwp1g4NbAc/zBs0Ioecf6MHToAv13B0TrCCQmK ZS9tEn31outBVgPY1OZso5q37lxW2jQqSkh3U/ayNUtFToX3ow6+3INFBKTsgk90e+bU nI4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r11si18144ilc.144.2021.09.15.06.52.51; Wed, 15 Sep 2021 06:53:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234561AbhIONxY (ORCPT + 99 others); Wed, 15 Sep 2021 09:53:24 -0400 Received: from verein.lst.de ([213.95.11.211]:36435 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234453AbhIONxW (ORCPT ); Wed, 15 Sep 2021 09:53:22 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C0A0867357; Wed, 15 Sep 2021 15:52:01 +0200 (CEST) Date: Wed, 15 Sep 2021 15:52:01 +0200 From: Christoph Hellwig To: Vasily Averin Cc: Christoph Hellwig , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@openvz.org Subject: Re: [PATCH mm] mm/vmalloc: repair warn_alloc()s in __vmalloc_area_node() Message-ID: <20210915135201.GB14571@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 15, 2021 at 02:43:10PM +0300, Vasily Averin wrote: > Commit f255935b9767 ("mm: cleanup the gfp_mask handling in > __vmalloc_area_node") added __GFP_NOWARN to gfp_mask unconditionally > however it disabled all output inside warn_alloc() call. > This patch saves original gfp_mask and provides it to all warn_alloc() calls. > > Fixes: f255935b9767 ("mm: cleanup the gfp_mask handling in __vmalloc_area_node") > Cc: Christoph Hellwig > > Signed-off-by: Vasily Averin Looks fine, thanks. Reviewed-by: Christoph Hellwig