Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp531170pxb; Wed, 15 Sep 2021 07:36:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfz3IATDe9y7H1/OTIv9cwRALv6j2KTrKYylgGph63yzulfzNKMfnsTBkPoDIFT/xMzeTw X-Received: by 2002:a50:c006:: with SMTP id r6mr297351edb.289.1631716568918; Wed, 15 Sep 2021 07:36:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631716568; cv=none; d=google.com; s=arc-20160816; b=HBrrTkn+hoQASrsDW7U9b6Wt6xc/zlzb+7ZNhgKgRJyw8rvs8iJTQHk9AWk+7ATCQ0 q1HCczD11ZDvLYhPLPf2jG0Qnhjk16/KomMvzbsDuis51uB9y2x4hFvPaoLpaFphh6aB rDMagLUbxuBDfFp/mlfzHyM/N13KPoB/iLFwxCANBDmAxPA+JE23AzAwoFABFJ1hhU55 68pj3ZwcdGg+cd7zGc8QPWb6hmF44wdMg8AP1OxWUyrqXGfdEVm79MLE3JG8igK2+ye+ +iwI6M2iZppf7orGYxXO/82TwgMk0XsQFWu97LEFVOFsDBuwPZv4hq212o2hzdQnZU03 eKKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=fiGkc1mrnvxr6x+MOFuhvXES/mruUvwE3KBL4cbUScY=; b=NdJiD+uRaMAqvXhLfb0Ir80tHUtj8CspzM29HdXTMeH5kDE5XezN4jjS5TG4G/ECTU k4oAbF0uML7Mks8znzMbqWTSRT40ktfNKPCNZrzHhQRTZoEPGpeHFb7Yd6rw20Aiq6/Z FWZj3nCyE8NEW4ss8rRFDcDEqiHeb07YQWkgzyaG0W9mcrW5Tvtpawg/WeQZeylpPTeQ JBrY//fac7+VJgJH8wC93YiglK/+RdDI0IoGpmNIlJBc0v/GYb62U1xOKEiIU7jbyfv0 7cLPainJZ/lK0ZtYcWZiNYV9EY9Sa1LtijnAYGcEgcEjxr7lpWGtr445nSgMsrsZ8KGF rYSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Cd+aAokz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si116691edf.622.2021.09.15.07.35.44; Wed, 15 Sep 2021 07:36:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Cd+aAokz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237948AbhIOOdK (ORCPT + 99 others); Wed, 15 Sep 2021 10:33:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:39574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233771AbhIOOdJ (ORCPT ); Wed, 15 Sep 2021 10:33:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E8F3D6044F; Wed, 15 Sep 2021 14:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631716311; bh=YkclizvbWMmiIkvXewz1CSndv/hj5phCYHjaoOz0nro=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Cd+aAokzBr430sd/rBB8OtMsmd7hYvE6h+I8Xe7r1UjQeh7R10kFKJf574U4ze2fl 3zIJ8iG40SWHAc3VwM3pqtbswxIuibRj21eqLa0Idd7UwmKV+pywSEKxbKOhb9aipd hZWa2rNOt7Rq7ZLb79kG9dhc9Qd0A8Alj7mm0W47UOOL4pmmUdXHazYueHu5upbyYB ofCF/mVTYC/NpeoFpC/WackmXbEW0zduOGvlz/Q7znqJsruhife4SrOnMoyTmu0yNm i4bfpWqP8Uj69zIJSyFIvgM/px74ZEqT+rtN1pLtTW1j53F+b0yxwONKdHIYJ0taf2 u6lY1t12EpTxg== Date: Wed, 15 Sep 2021 16:31:48 +0200 (CEST) From: Jiri Kosina To: "F.A.Sulaiman" cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, paskripkin@gmail.com Subject: Re: [PATCH v3] HID: betop: fix slab-out-of-bounds Write in betop_probe In-Reply-To: <20210824150730.9118-1-asha.16@itfac.mrt.ac.lk> Message-ID: References: <20210816201544.26405-1-asha.16@itfac.mrt.ac.lk> <20210824150730.9118-1-asha.16@itfac.mrt.ac.lk> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Aug 2021, F.A.Sulaiman wrote: > Syzbot reported slab-out-of-bounds Write bug in hid-betopff driver. > The problem is the driver assumes the device must have an input report but > some malicious devices violate this assumption. > > So this patch checks hid_device's input is non empty before it's been used. > > Reported-by: syzbot+07efed3bc5a1407bd742@syzkaller.appspotmail.com > Signed-off-by: F.A. SULAIMAN Applied, thanks. -- Jiri Kosina SUSE Labs