Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp548886pxb;
        Wed, 15 Sep 2021 08:00:38 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxTL/RjTbjQiiAQFanylBVIiE7sqHmYtbvVYBWcB0DKIILMVAZEzVbMd+8wKzl4zdkdUnad
X-Received: by 2002:a05:6e02:eb0:: with SMTP id u16mr347812ilj.178.1631718038012;
        Wed, 15 Sep 2021 08:00:38 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1631718038; cv=none;
        d=google.com; s=arc-20160816;
        b=QV4EgTS25AV7Iw4g2XhF6Ov3JmYfv8shcBVnFtZ/Z8JOb8wIx0oO0oXxPX9wPPVdKH
         kRZlWIgWqUvJWVEb+HXbxcs6hIJdjkEurW+UA5YnDiCGZcYv5ywLlUiRv2BKBm3OT/+o
         QzQv7tJcmYuDs9udLoJ3IjNap4OST4okthiOFewujDxzqGuzJNDzDZQyr0rc+G7hrcjH
         STzh2KBF6oqhiSEuAYXtUwdLp4dhG3eeohE3XkOjx3zlYE5A9j9oRxSnfshp8Al7G68q
         Y8fuwGYoZqn9yg6MC80EHbcTGOfQHjeL1BYHzlRJE4fFv7PGNsiQCwehASNeig4hLthn
         YOgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent:references:message-id
         :in-reply-to:subject:cc:to:from:date:dkim-signature;
        bh=JApruABns0hUfytxPifauSITz+Xn0t60zq0iqoH90Z0=;
        b=Uc+h1SCtVu/jPa3HJCLp3F/pz0MDNvgCttYFNDTD+vTB1ppNniaYEB/7OsJfB8RNyM
         eD+q4qj2mf1ZvIU54WUtmQtEBEtJ4UlIL/zTbEUU3Cwj7izo+/mA/TGbiAoz8brA/JuV
         eWPRBNeZPCy91sw3pwa+6chxlsDuJIEJcxMuffah+pBQW/K5mFFM23RWIvI940LHM5DV
         ajmtQs0vsJodEo3XJW5ykkkFgXUh9rqslBDnnPiZfMLaCtdqgjzHss7zzQ/yoS0WvR2z
         rKmZ/AMbbkogo2XWD2WrPC4UXjHRzsiiOsTL1DxRyrf7FrJtPqVJXmMlvg069zvsxQSi
         JEMQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Rd8rFSXf;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id i12si85495jaf.41.2021.09.15.08.00.25;
        Wed, 15 Sep 2021 08:00:38 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Rd8rFSXf;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S237956AbhIOO7q (ORCPT <rfc822;lkml.email@gmail.com> + 99 others);
        Wed, 15 Sep 2021 10:59:46 -0400
Received: from mail.kernel.org ([198.145.29.99]:46976 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S237842AbhIOO7m (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Sep 2021 10:59:42 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 1C39261242;
        Wed, 15 Sep 2021 14:58:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1631717903;
        bh=/ZfMlzHl86RUkY+mAXoq6ryeWsjRe4PlpqtUqEFs9/o=;
        h=Date:From:To:cc:Subject:In-Reply-To:References:From;
        b=Rd8rFSXfisp6imty9F4sAx9FSrFdJLaQYpHNueuUKT9pHHi46LkxS1P60qC3GmYxP
         QPVmKC/bvBJ6AqyQibt1rIl+D+fUuSY2iei54seugf4JpWQJACTX3iNo3cRGnCP4Ns
         5MZjA+t3rBcbKoLcxrR00p8ZqIIoBwJzfJxGve7u3+oSm3oIMBCUOQNJonk3wyuim5
         OhsZMpa/A+tBceGZNjYxtHrUwf3eht0AFvdNOXI7uro0pdY3/LZsXtTsVFPCdPd7f4
         8a5KrMyKSOpKtTyWEeMAbjValr/pKR79BUcWesG0wnBbWWDtA2lyu4ASX6dqbiCY1B
         3a6Bp/i5oBwJg==
Date:   Wed, 15 Sep 2021 16:58:19 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Evgeny Novikov <novikov@ispras.ru>
cc:     Nehal Shah <nehal-bakulchandra.shah@amd.com>,
        Sandeep Singh <sandeep.singh@amd.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        ldv-project@linuxtesting.org
Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference
In-Reply-To: <20210601163801.17848-1-novikov@ispras.ru>
Message-ID: <nycvar.YFH.7.76.2109151657580.15944@cbobk.fhfr.pm>
References: <20210601163801.17848-1-novikov@ispras.ru>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 1 Jun 2021, Evgeny Novikov wrote:

> devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at
> registration that will cause NULL pointer dereference since
> corresponding data is not initialized yet. The patch moves
> initialization of data before devm_add_action_or_reset().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>

Nehal, Basavaraj, could you please Review/Ack this one?

Thanks,

-- 
Jiri Kosina
SUSE Labs