Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp624538pxb; Wed, 15 Sep 2021 09:25:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynFI28ui2CYfZF8KZEh0K0jvS4DWpLp+qdicZ056MmPVxAcpJNrSXGgmsR+djWMOFn2k2M X-Received: by 2002:a5d:9bd3:: with SMTP id d19mr736691ion.202.1631723126728; Wed, 15 Sep 2021 09:25:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631723126; cv=none; d=google.com; s=arc-20160816; b=u6B3gdT/ryU8nEgA2+T/0yB/Oi6pUTGnw+KWuCCb+CL94GjX4Z0FVKmdki9PkoUMAs 4OVykBVSXg9uhDEpJ/q2ZG3dTuizXfq+k1XA5AUCqNN4mSwHS6B4vohic5c+yYHIP3d2 uFFKIaGqIFEDbEZOXX2btj5CVLlzUXNwzQS6YXH2YWlB+GhCoXYjFp7rSOXHSGrpotDx 3Onz2WbBvKMY7nxvRZVwqeaPh42Kr30Pvb3G3mHWAx50PM9W62tc8kghdDX1k/5axs4W t9aWTiZFwblayhS9GEfLq0DyxwKMumTmCRJHGM+wHJnQVzCvouTZuoZRGWZz7WuC4fTN XW3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:in-reply-to:message-id:date :subject:cc:from; bh=fWBP5S/w1RstuvVe25hnr++TZz9W/vyfY1EAG8kwEjo=; b=HH81Yb5BnCwRA2rTgH5DXSUuUrM8t2dHkBBp4Ne//lfJ+OuOPiMkN48h6oZM2Feztj nULwHOsi67ilqYZAlWnx9uzftju69gwarzYRXihJLSH2dvkyZuo1Q+am5n0gneYJATCt LYZlPIhEbKbK8Bnvw6ioTbxB5fSXYVGgSPHM4Hny9Rlyy47ft1kcyncp9yC+mNUFrO9c 3ZUFk7VsHlv9x/lVA69goiSGRTbKt2jjesBgvPj1e+4luz6j+kPIITHfCztQY+MnbXNM 3fuoQzE9tW5PEyidVUiqlmtMY2H5ctukkIj6pLEYMO5hzvr1xB8TWnmYHcV1hFci0jya 18ZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u20si260010jao.113.2021.09.15.09.25.15; Wed, 15 Sep 2021 09:25:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbhIOQZR (ORCPT + 99 others); Wed, 15 Sep 2021 12:25:17 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:42862 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229672AbhIOQZI (ORCPT ); Wed, 15 Sep 2021 12:25:08 -0400 Received: from guri.fritz.box (unknown [IPv6:2a02:810a:880:f54:6886:1a1c:e30b:c0f1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 04D6A1F43794; Wed, 15 Sep 2021 17:23:47 +0100 (BST) From: Dafna Hirschfeld Cc: Dafna Hirschfeld , Robert Beckett , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)), linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list), laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, kiril.bicevski@collabora.com, Nas Chung , lafley.kim@chipsnmedia.com, scott.woo@chipsnmedia.com, olivier.crete@collabora.com Subject: [PATCH 4/6] staging: wave5: Add TODO file Date: Wed, 15 Sep 2021 18:23:22 +0200 Message-Id: <20210915162324.25513-5-dafna.hirschfeld@collabora.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210915162324.25513-1-dafna.hirschfeld@collabora.com> References: <20210915162324.25513-1-dafna.hirschfeld@collabora.com> To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a TODO file listing all that is need for destaging. Signed-off-by: Robert Beckett Signed-off-by: Dafna Hirschfeld --- drivers/staging/media/wave5/TODO | 42 ++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 drivers/staging/media/wave5/TODO diff --git a/drivers/staging/media/wave5/TODO b/drivers/staging/media/wave5/TODO new file mode 100644 index 000000000000..7e94e8dcedcf --- /dev/null +++ b/drivers/staging/media/wave5/TODO @@ -0,0 +1,42 @@ +* Test on real silicon once available + + This driver has so far been tested on pre-silicon FPGA and on the beta BeagleV + board which uses the StarFive JH7100 beta SoC. + + Testing on FPGA shows it working fine, though the FPGA uses polled interrupts + and copied buffers between the host and it's on board RAM. + + Testing on BeagleV shows buffer corruption that is currently attributed to a + known silicon issue in the SoC that makes the cache coherent interconnect not + so coherent. + This can likely be solved when the riscv non-coherent dma support lands and + provide optional v4l2 non-contiguous allocator, though it remains to be seen + whether support non-coherent use cases will be useful in real world hw. + + Until we can test and resolve any issues on final silicon (due 2H 2021) + this driver should remain in staging. + +* Handle interrupts better + + Currently the interrupt handling uses an unusual design employing a kfifo to + transfer irq status to irq thread. This was done as a work around for dropped + interrupts seen with IRQF_ONESHOT based handling. + + This needs further investigation and fixing properly, with the aid of + C&M and StarFive engineers. + +* Fix early end of stream handling + + When using a gstreamer pipeline like this: + gst-launch-1.0 filesrc location= ! parsebin ! h264parse ! v4l2h264dec ! jpegenc ! identity eos-after=3 ! multifilesink location=%05d.jpeg + i.e. forced eos after 3 buffers + the pipeline stalls on exit waiting for end of job. + We need to add some form of early exit detection, instead of the current + behaviour of only considering a job finish on PIC_END. + +* Support more formats + + The current frontend v4l2 layer only supports V4L2_PIX_FMT_HEVC and + V4L2_PIX_FMT_H264. + The backend logic supports other formats, so we should wire up the support + for further bitsream formats. -- 2.17.1