Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Imran Khan <imran.f.khan@oracle.com>
To:     vbabka@suse.cz, geert@linux-m68k.org, akpm@linux-foundation.org,
        ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com,
        dvyukov@google.com, maarten.lankhorst@linux.intel.com,
        mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie,
        daniel@ffwll.ch
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        intel-gfx@lists.freedesktop.org, linux-mm@kvack.org
Subject: [PATCH RESEND v2 2/3] lib, stackdepot: Add helper to print stack entries.
Date:   Thu, 16 Sep 2021 03:53:20 +1000
Message-Id: <20210915175321.3472770-3-imran.f.khan@oracle.com>
In-Reply-To: <20210915175321.3472770-1-imran.f.khan@oracle.com>
References: <20210915175321.3472770-1-imran.f.khan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N/JrJ7PVGJYPqF9xroHqOLGoVrkHurGfkqXwIoDM433gQE8OWed1nbv+oirD?=
 =?us-ascii?Q?zWPex3yjpi2sk2cAoSMglh+KP93efeZTm+QM8TCjodfWTA8qqn9NH8qSf1B7?=
 =?us-ascii?Q?4Ucb63jQY89hby3WifeIMrFID1mbaUwqviGxnDCx3wNr0lORWTANpomrT6Z6?=
 =?us-ascii?Q?V5gncLZwmi+RrmzuWfCJnEpYPXsmqS3pqqToJo8NnY9BMKFjKQf1WHrbrtAi?=
 =?us-ascii?Q?x1iFXgbuwN/xjUO6W2mBDxb3LDe+nhB8NLHs79u+nnLhGaywMTR94oO1eeTp?=
 =?us-ascii?Q?tQsKu232iWYoE2Sk0jwMprb+rml/pK180zeZqLYTRlcM7WJERcbSk0SwYChG?=
 =?us-ascii?Q?bFo6ClMwhST57kwdXuw8bjChVEkN+4n2M1CsPOEh9eECDFKXZQtEJjjweha/?=
 =?us-ascii?Q?1f2eilcAkyrx5lC3QuvS+bIF2fhV9d1cY8DYHNxpGlodX+5E5n8ykJIat20i?=
 =?us-ascii?Q?JKn/3hEWaNVevYXFAwNyqbZdA5SXoa+saxJuvC43i/OZ9VyySQJSBuR1etYD?=
 =?us-ascii?Q?0wWIiObP4OX6XZVh8Iy1QB4ikWOKKGEVmVaUU6zXdywhZrPv8n/PCwBX30Ga?=
 =?us-ascii?Q?2Iw5X6Q4/V2MnrNUbIMKtaVaq7xklenKCJNrnNRk3DNUVXcAmQGj+Dz/wB0k?=
 =?us-ascii?Q?9EHPJIxaKD4hhLkyQFuaOO6nqRXxlW3Fc/va4XDSIVIFV7Mw1MiRCFfP3fdu?=
 =?us-ascii?Q?sEthrnBlMTTUg6+PrhFoEA9nY2WMpxyWhlVnUZ39YPUtrierLBG4arcXvd8h?=
 =?us-ascii?Q?vBjHMSY+nwWnp/s3ubYEIrsjC8dyMvBcsojUyNVg16Y253muRfiF0CykmCDc?=
 =?us-ascii?Q?PPSDPpDYmewUsVY9NPjuM9t4XxKi0WFfIl71shSsJivwpPCK9Pyvn7tz+Xq7?=
 =?us-ascii?Q?rDT/Opt+1aptuhNmQsnbp9EYqLgFDaiD3KciwhX34pHaLTDIe7LQAC4DIyol?=
 =?us-ascii?Q?+upoQ+1+pOJQokX+7eAu9FIoDcxyiWAvtZRCriWqWVS+ISlArCS55qZ8ZOYn?=
 =?us-ascii?Q?zwpvGJfe/rMIxuCk4EyKBQc80BrTIyZw6RVsHBpEPo9XJ7Ef7x+qhfXVlWft?=
 =?us-ascii?Q?KhgXBEH47vc9Bb6lu6yLVc7tSM7ZZ4Q5LsYSXJis8eDMaaPOEBHh51Y4FFyB?=
 =?us-ascii?Q?0oBi0lvp9a8EdJ6Qx3T2MN1wTwpDks59xHOh/V1C/KIQ/3/q6XQ8QlRf17UL?=
 =?us-ascii?Q?+MJ3zw5uTYoYZ6LfzC/sCym+ow/R7eN50RegPAIQVz7FW/V/FtxqhnTwjlso?=
 =?us-ascii?Q?gf37+TA8OOcR4Jsg6w/6zJFTST4y89oyXq/m88nPMptpWmHSyGK7Wg5tKqUz?=
 =?us-ascii?Q?vuQKeYW/YOHaOvUWtIO4RVed?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 00ec7627-1dff-483c-7f6a-08d97871be5f
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 17:53:37.2114
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: auBqZSnXVNp+qmx/YXiR2sP2dh1ehdW+OjVSpXXDGj/0s6AL0ddRohZg6AmFR5Ox0FdzmVa1m4zRJDPxTkaNPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1568
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10108 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109150105
X-Proofpoint-GUID: v4IUkiFq3A7L96MP7GwmVN-b7FQbPO4w
X-Proofpoint-ORIG-GUID: v4IUkiFq3A7L96MP7GwmVN-b7FQbPO4w
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

To print a stack entries, users of stackdepot, first
use stack_depot_fetch to get a list of stack entries
and then use stack_trace_print to print this list.
Provide a helper in stackdepot to print stack entries
based on stackdepot handle.
Also change above mentioned users to use this helper.

Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
Suggested-by: Vlastimil Babka <vbabka@suse.cz>

Acked-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Alexander Potapenko <glider@google.com>
---
 include/linux/stackdepot.h |  2 ++
 lib/stackdepot.c           | 18 ++++++++++++++++++
 mm/kasan/report.c          | 15 +++------------
 mm/page_owner.c            | 13 ++++---------
 4 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h
index 6bb4bc1a5f54..d77a30543dd4 100644
--- a/include/linux/stackdepot.h
+++ b/include/linux/stackdepot.h
@@ -19,6 +19,8 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries,
 unsigned int stack_depot_fetch(depot_stack_handle_t handle,
 			       unsigned long **entries);
 
+void stack_depot_print(depot_stack_handle_t stack);
+
 unsigned int filter_irq_stacks(unsigned long *entries, unsigned int nr_entries);
 
 #ifdef CONFIG_STACKDEPOT
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 67439c082490..354fe1b62017 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -214,6 +214,24 @@ static inline struct stack_record *find_stack(struct stack_record *bucket,
 	return NULL;
 }
 
+/**
+ * stack_depot_print - print stack entries from a depot
+ *
+ * @stack:		Stack depot handle which was returned from
+ *			stack_depot_save().
+ *
+ */
+void stack_depot_print(depot_stack_handle_t stack)
+{
+	unsigned long *entries;
+	unsigned int nr_entries;
+
+	nr_entries = stack_depot_fetch(stack, &entries);
+	if (nr_entries > 0)
+		stack_trace_print(entries, nr_entries, 0);
+}
+EXPORT_SYMBOL_GPL(stack_depot_print);
+
 /**
  * stack_depot_fetch - Fetch stack entries from a depot
  *
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index 884a950c7026..3239fd8f8747 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -132,20 +132,11 @@ static void end_report(unsigned long *flags, unsigned long addr)
 	kasan_enable_current();
 }
 
-static void print_stack(depot_stack_handle_t stack)
-{
-	unsigned long *entries;
-	unsigned int nr_entries;
-
-	nr_entries = stack_depot_fetch(stack, &entries);
-	stack_trace_print(entries, nr_entries, 0);
-}
-
 static void print_track(struct kasan_track *track, const char *prefix)
 {
 	pr_err("%s by task %u:\n", prefix, track->pid);
 	if (track->stack) {
-		print_stack(track->stack);
+		stack_depot_print(track->stack);
 	} else {
 		pr_err("(stack is not available)\n");
 	}
@@ -214,12 +205,12 @@ static void describe_object_stacks(struct kmem_cache *cache, void *object,
 		return;
 	if (alloc_meta->aux_stack[0]) {
 		pr_err("Last potentially related work creation:\n");
-		print_stack(alloc_meta->aux_stack[0]);
+		stack_depot_print(alloc_meta->aux_stack[0]);
 		pr_err("\n");
 	}
 	if (alloc_meta->aux_stack[1]) {
 		pr_err("Second to last potentially related work creation:\n");
-		print_stack(alloc_meta->aux_stack[1]);
+		stack_depot_print(alloc_meta->aux_stack[1]);
 		pr_err("\n");
 	}
 #endif
diff --git a/mm/page_owner.c b/mm/page_owner.c
index d24ed221357c..7918770c2b2b 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -394,8 +394,6 @@ void __dump_page_owner(const struct page *page)
 	struct page_ext *page_ext = lookup_page_ext(page);
 	struct page_owner *page_owner;
 	depot_stack_handle_t handle;
-	unsigned long *entries;
-	unsigned int nr_entries;
 	gfp_t gfp_mask;
 	int mt;
 
@@ -423,20 +421,17 @@ void __dump_page_owner(const struct page *page)
 		 page_owner->pid, page_owner->ts_nsec, page_owner->free_ts_nsec);
 
 	handle = READ_ONCE(page_owner->handle);
-	if (!handle) {
+	if (!handle)
 		pr_alert("page_owner allocation stack trace missing\n");
-	} else {
-		nr_entries = stack_depot_fetch(handle, &entries);
-		stack_trace_print(entries, nr_entries, 0);
-	}
+	else
+		stack_depot_print(handle);
 
 	handle = READ_ONCE(page_owner->free_handle);
 	if (!handle) {
 		pr_alert("page_owner free stack trace missing\n");
 	} else {
-		nr_entries = stack_depot_fetch(handle, &entries);
 		pr_alert("page last free stack trace:\n");
-		stack_trace_print(entries, nr_entries, 0);
+		stack_depot_print(handle);
 	}
 
 	if (page_owner->last_migrate_reason != -1)
-- 
2.30.2