Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Sep 2021 13:06:00 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc:     Boris Pismenny <borisp@nvidia.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Jia Zhang <zhang.jia@linux.alibaba.com>,
        "YiLin . Li" <YiLin.Li@linux.alibaba.com>
Subject: Re: [PATCH] net/tls: support SM4 GCM/CCM algorithm
Message-ID: <20210915130600.66ce8b26@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210915111242.32413-1-tianjia.zhang@linux.alibaba.com>
References: <20210915111242.32413-1-tianjia.zhang@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 15 Sep 2021 19:12:42 +0800 Tianjia Zhang wrote:
> +		memcpy(sm4_gcm_info->iv,
> +		       cctx->iv + TLS_CIPHER_AES_GCM_128_SALT_SIZE,
> +		       TLS_CIPHER_AES_GCM_128_IV_SIZE);
> +		memcpy(sm4_gcm_info->rec_seq, cctx->rec_seq,
> +		       TLS_CIPHER_AES_GCM_128_REC_SEQ_SIZE);
> +		release_sock(sk);
> +		if (copy_to_user(optval, sm4_gcm_info, sizeof(*sm4_gcm_info)))
> +			rc = -EFAULT;
> +		break;
> +	}
> +	case TLS_CIPHER_SM4_CCM: {
> +		struct tls12_crypto_info_sm4_ccm *sm4_ccm_info =
> +			container_of(crypto_info,
> +				struct tls12_crypto_info_sm4_ccm, info);
> +
> +		if (len != sizeof(*sm4_ccm_info)) {
> +			rc = -EINVAL;
> +			goto out;
> +		}
> +		lock_sock(sk);
> +		memcpy(sm4_ccm_info->iv,
> +		       cctx->iv + TLS_CIPHER_AES_GCM_128_SALT_SIZE,
> +		       TLS_CIPHER_AES_GCM_128_IV_SIZE);
> +		memcpy(sm4_ccm_info->rec_seq, cctx->rec_seq,
> +		       TLS_CIPHER_AES_GCM_128_REC_SEQ_SIZE);

Doesn't matter from the functional perspective but perhaps use the SM4
defines rather than the AES ones, since they exist, anyway?

With that fixed feel free to add my ack.